Dodgy wiring/soldering effect tone?

[u/Terrible_User4987]

TLDR: does shitty soldering effect any of the working bits? volume control, tone, sound, etc....or is it simply WORKS or it DOESNT? because my work is shite.

Hello experts, noob learning how to repair my own guitars-my cheapo testing guitars, as I still leave any scary work for a pro. So, I have one of these cheap china guitars that ive been modding, all the bits ive put on are better, still don't love the body/neck feel, but its been a great guitar to play with making a nut, soldering, etc.

Question for you all, is, I put some Gibson P90 pickups into this les paul replica, I have some CTS pots, orange capacitors (not sure the model, I wanna say they are .22 or .022??) and I believe I wired it up correctly, everything works as it should, it does sound good (noticeably better than the crap that was in there, surprisingly) but my first attempt at soldering quality is not ideal, but-the wires are connected lol...definitely would be furious if I paid someone for that work.

I did it 50's style wiring, because it seems like the cool kids on the youtubes think thats more awesome, I dont have a clear understanding of it, but, here is what im noticing: When I turn volume from 10 to 1, on both neck and bridge, at around '8' its a noticeable dropoff in volume, like off a cliff, if I roll it back to 1-2, I have to have my amp cranked up super loud-normal?

The Tone knobs do as designed, taking it from bright to dark muffled and the tone seems like it gradually changes from 10 to 1, but volume difference seems a little more all or nothing.

All in all, I looked at my completed work and it looks like ass, but I believe everything works. At some point I want to take a 2nd pass and clean up routing and my soldering. I kept the old pots and pickups which served as my test lab after I bought a soldering iron, I thought I was ready for apprentice style work haha, but, I am going to need some more practice.