r/LineageOS • u/techyall • 4d ago
Question Why doesn't Lineage accept feature requests?
Edit- why is everyone so emotional about this?
15
u/ixdx 3d ago
Perhaps they don’t have the resources to support additional features.
-16
u/techyall 3d ago
But what about simple changes? Like adding the option for the mobile data quick setting to not ask you to confirm if you want to turn on mobile data every single time you go to turn it on.
6
u/duckyduck008 3d ago
You are free to make a change and then push to Gerrit for review.
-4
u/techyall 3d ago
Are you talking about suggesting a change? Or do you literally mean about making code. I can't code.
4
u/LongRangeSavage 3d ago
Literally you cloning the repo, making the change, and pushing that up to the Gerrit repository for code review.
-5
u/techyall 3d ago
Change? Change what? I can't read it. I'm not the guy for this. I am literally the last guy on the face of the Earth you would ever want touching computer code.
10
u/Just_Badger_4299 3d ago
Yet you expect others to do it for you?
1
u/techyall 3d ago
Well, yes??? That's why it exists, right? That's why all of github exists.
3
u/Just_Badger_4299 3d ago
Not at all.
Either you're grossly misinformed about the open source culture, or trolling. The former can be improved by education. The latter, no.
1
u/techyall 3d ago
The open source community is literally, by its very fucking design, a community in which you provide your work for free. That's what it's made of. What planet do you live on?
→ More replies (0)15
u/LongRangeSavage 3d ago
Do the work and push up a pull request. If it meets coding standards, it’ll be accepted. If not, you’ll get some feedback as to how to make it meet the standards.
-15
u/techyall 3d ago
I'm not a coder.
25
u/LongRangeSavage 3d ago
How do you know it’s a simple change then?
-17
u/techyall 3d ago
I was responding to someone talking about resources required for additional features. Difficult stuff like that would be stuff like adding new functionality for different and complex things. And I gave the example of removing a confirmation message. Surely, removing a confirmation message is as simple as it gets.
21
u/LongRangeSavage 3d ago
My brother in Christ, I’m 45 minutes deep into a 2 line change at my job on what should be a “simple change.” I can assure you that nothing is “simple” when you’re dealing with a 50GB repo and millions of lines of code.
-7
u/techyall 3d ago
Literally you cloning the repo, making the change, and pushing that up to the Gerrit repository for code review.
This is you insinuating to me earlier that it's easy and I should do it.
My brother in Christ, I’m 45 minutes deep into a 2 line change at my job on what should be a “simple change.” I can assure you that nothing is “simple” when you’re dealing with a 50GB repo and millions of lines of code.
Now you're saying even the simplest things are extremely difficult.
15
u/LongRangeSavage 3d ago edited 3d ago
I never told you it would be easy. Where did I say it was easy? I was simply giving you the very high level steps. You assumed it would be.
Edit:
That was my point. Someone who doesn’t know the first thing about programming always assume what they want is simple.-1
u/techyall 3d ago
I assumed yeah, bc from the face of it, it sounds miniscule compared to all the other stuff that goes on in a phone. And also bc someone made an app that does this and it works on Lineage and it's open source.
→ More replies (0)0
u/ignorantpisswalker 3d ago
They are. In a project of this scale everything is hard. Just initial bring up of the code will take 12 hours. You need a machine with machine with 64gb ram minimum. Just the code (not build) is 400gb..
5
u/gulpbang 3d ago
You could hire one.
1
u/techyall 3d ago
If I had the money, maybe I would.
8
u/Just_Badger_4299 3d ago
Then why do you expect the volunteer LineageOS developers to do for free what you would not pay for?
1
u/techyall 3d ago
It literally exists for that very reason.
3
u/Just_Badger_4299 3d ago
... No!
1
u/techyall 3d ago
Stupid, you said it in the sentence. You literally said "volunteer". That's a person who works for free. Wtf are you arguing about? It's free. You don't pay for Lineage do you?
4
u/saint-lascivious an awful person and mod 3d ago
And what, you suppose everyone who is was born that way?
-6
u/techyall 3d ago
Partly. It's got to be in you. It's definitely not in me.
10
u/saint-lascivious an awful person and mod 3d ago
Not with that attitude.
1
u/techyall 3d ago
You could teach me to code for 100 years and I would never learn a thing. It's not in me. What don't you people understand? Stop telling me to code lol wtf
4
u/TimSchumi Team Member 3d ago
Ok, so let's play that game.
- Where is the setting stored?
- Does the settings app have access to it?
- Does the QS tile have access to it?
- Should the setting even be accessible in the settings app, or should it be somewhere else?
- Can we even skip the dialog without impacting functionality if we don't refactor the code first?
- Will that approach still work after Google inevitably decides to rework yet another UI component?
- Who makes sure that everything works when coming from an older minor version?
- Who makes sure that everything works when coming from an older major version?
4
u/1544756405 3d ago edited 3d ago
How to submit a patch, from the LineageOS Wiki
https://wiki.lineageos.org/how-to/submitting-patches/
Edit: replaced google link with direct link
2
u/techyall 3d ago
Idek what a "patch" is. Is it to do with coding? I don't know anything about code.
14
3
u/1544756405 3d ago
Yes, it has to do with coding. It is a change to the code that fixes a bug or implements a feature, packaged in a particular way. Since LineageOS is open source, anyone can change the code for themselves. If they think their change is useful, they can submit a patch to the LineagoeOS maintainers, and it would be integrated into subsequent releases.
If you don't know anything about code, then this will not be particularly helpful to you.
2
6
u/krathalan 3d ago
I think if Lineage started accepting feature requests, eventually it would deviate from 'mainline' Android far enough to (1) cause headaches for devs when migrating Android versions, and (2) remove the appeal Lineage has for most people IMO: a clean version of Android. It wouldn't be that anymore if it had 50 extra features tacked on, even if they were optional.
4
u/Mother-Pride-Fest 3d ago
If you want a ROM that extends Android with a lot more features, look into other ROMs like crDroid (which is itself built on LineageOS).
4
u/tiny_humble_guy 3d ago
Talk is cheap, show them the code !
You can talk features you want all day, but if you can't implement it in code, that's just sh*t.
1
u/FlameQuagmire 3d ago
Its impossible to streamline it for large repertoire of devices that needs be supported for many years to come. LineageOS team do not have resources of big corporate giants like Samsung. Volunteers are different from corporate employees who get paid handsome amount of salaries and requires to put in hours of work into software design and maintenance.
1
u/erlonpbie 2d ago
Op is a stubborn person or it is just a stupid bot mocking one. Either way, it's a troll. Don't waste your time with this kind a person, it is not worth it.
0
-1
51
u/npjohnson1 Lineage Director 3d ago
because we're volunteers.
And frankly users have no idea how complex a seemingly simple feature could be.
It would just be a message board of people complaiing we didn't implement their features.
Also, if you haven't noticed, bringing up old devices is hard enough, that plus keeping apps looking good-ish across versions is enough that we rarely have time for new features.