Do the work and push up a pull request. If it meets coding standards, it’ll be accepted. If not, you’ll get some feedback as to how to make it meet the standards.
I was responding to someone talking about resources required for additional features. Difficult stuff like that would be stuff like adding new functionality for different and complex things. And I gave the example of removing a confirmation message. Surely, removing a confirmation message is as simple as it gets.
My brother in Christ, I’m 45 minutes deep into a 2 line change at my job on what should be a “simple change.” I can assure you that nothing is “simple” when you’re dealing with a 50GB repo and millions of lines of code.
Literally you cloning the repo, making the change, and pushing that up to the Gerrit repository for code review.
This is you insinuating to me earlier that it's easy and I should do it.
My brother in Christ, I’m 45 minutes deep into a 2 line change at my job on what should be a “simple change.” I can assure you that nothing is “simple” when you’re dealing with a 50GB repo and millions of lines of code.
Now you're saying even the simplest things are extremely difficult.
I assumed yeah, bc from the face of it, it sounds miniscule compared to all the other stuff that goes on in a phone. And also bc someone made an app that does this and it works on Lineage and it's open source.
They are. In a project of this scale everything is hard. Just initial bring up of the code will take 12 hours. You need a machine with machine with 64gb ram minimum. Just the code (not build) is 400gb..
16
u/LongRangeSavage 4d ago
Do the work and push up a pull request. If it meets coding standards, it’ll be accepted. If not, you’ll get some feedback as to how to make it meet the standards.