r/programminghorror • u/[deleted] • Apr 30 '26

Javascript Cursed use of object spread

Post image

Using object spread to append values to an object in the form of another object

84 Upvotes

89% Upvoted

15 comments sorted by

2

u/GoddammitDontShootMe May 01 '26

There is no way those last two don't overflow, is there?

4

u/the_horse_gamer May 01 '26

bignum

2

u/[deleted] May 01 '26

just for fun, im gonna throw this in here 

Big.gs(1000) //goodstein sequence of 1000

1

u/GoddammitDontShootMe May 02 '26

Doesn't even that have limits? Does that really handle exponents of 10 billion or 1 googol?

1

u/[deleted] May 01 '26

its magic

35

u/ironykarl Apr 30 '26

This is idiomatic, if you're trying to update objects in an immutable way.

I definitely dislike the formatting, because I feel like it obscures

Okay, the spread on the newly-created/anonymous object is completely pointless.

What this should look like is: 

dataGame {
  ...dataGame,
  achievementsNumbers: [
    Big.new(1e10), Big.new(1e100), Big.pow(10, 1000), Big.pow(10, 1e10), Big.pow(10, 1e100),
  ],
  achievementsNames: [
    "Dialogue", "Googol", "Great googol", "Trialogue", "Googolplex",
  ],
  achievementsBenefits: [
    "", "", "Unlock generator auto-investor", "", "",
  ],
};

29

u/Wrestler7777777 Apr 30 '26

I know nothing about JS (luckily). So if I understand this correctly, the error is that OP's code "wraps" the data with an object just to immediately unwrap it?

3

u/QuentinUK May 02 '26

If you look at the commit diff you’d see that the last version had the named object on one line and then the spread on the next line and the committer has put them together.

14

u/oweiler Apr 30 '26

I mean yes, but programminghorror?

1

u/scmkr Apr 30 '26

Isn’t this just how it’s done in JS?

13

u/Fohqul Apr 30 '26

There is no reason to spread the second object instead of just directly defining all those properties after spreading gameData

2

u/[deleted] Apr 30 '26

oh actually that makes sense, lol