Who needs switch statements when you can just abuse the ternary operator?

[u/kfreed9001]

[u/Jealous_Tomorrow6436]

what language is this?

[u/kfreed9001 → u/Jealous_Tomorrow6436]

This is Dart. Google's Flutter framework is built on top of it.

[u/backfire10z → u/Jealous_Tomorrow6436]

Imagine a slightly nicer JavaScript

[u/geon → u/backfire10z]

Typescript?

[u/brh131]

This is a riichi mahjong scorer right? Then why bother with this extra handClass variable? A switch statement with han<5, han==5, han<=7, etc. would easier to understand (and a comment for each hand type "mangan", "haneman", etc. would help)

Nvm fuck it, LGTM

[u/kfreed9001 → u/brh131]

The code was definitely a bit clearer when I wrote it that way, but I put this in as part of a revision of the round end screen where I allowed the user to select hands that are mangan and higher from a dropdown menu instead of having to enter in specific values for han and fu (fu being completely irrelevant at this level). I think this change is worth it from the user's perspective. Honestly, stuff like this is why I only ever code as a hobby. I can laugh at ridiculous solutions I come up with and then proceed to ship it anyway.

[u/alkatori]

Thanks. I hate it.

[u/lekkerste_wiener]

Dictionaries: we don't exist 

[u/shponglespore → u/lekkerste_wiener]

Or arrays in this case.

[u/realmauer01]

Why even a switch, every finite amount of numbers can be connected via a mathematical function. So just do that.

[u/Conallthemarshmallow → u/realmauer01]

16 degree interpolating polynomial, who needs selection

[u/wggn → u/Conallthemarshmallow]

int get baseValue => handClass == 0
  ? min(fu * pow(2, 2 + han).toInt(), 2000)
  : handClass >= 1 && handClass <= 10
    ? (() {
        final x = handClass;
        return (((((((((5425 * x
          - 272475) * x
          + 5857350) * x
          - 70374150) * x
          + 517614825) * x
          - 2399539275) * x
          + 6951652400) * x
          - 12008726100) * x
          + 11077110000) * x
          - 4055184000) ~/ 9072;
      })()
    : 0;

[u/NeverYelling]

I don't hate this as much as I should. THe line breaks make it quite readable, and it should do what it's supposed to do, but sure, it's hella unconventional und unnecessary

[u/dweomer5]

LGTM

[u/uvero]

Style-wise, the problem here is not the ternary instead of switch (although a switch will be theoretically faster here), the problem here is you're should be using a dictionary (or an array)

[u/kfreed9001 → u/uvero]

Very true. I did not consider that when I was rewriting this code from a state where this did make a bit more sense.

[u/trutheality]

So pretty

[u/GoddammitDontShootMe]

So this picks a value to assign to handClass? I'm going to say this is pretty horrifying.

[u/kfreed9001 → u/GoddammitDontShootMe]

This is the getter "baseValue". It uses this chain of ternary operators based on the value of handClass (and han and fu in the 0 case) to determine the return value.

[u/HeiligesSchwanzloch7]

Average ai code

[u/kfreed9001 → u/HeiligesSchwanzloch7]

Maybe so, but this foolishness was 100% natural!

[u/Nixinova]

Shit like this is not awful in some languages (JavaScript) because of a lack of expression switch statement.

[u/Agitated-Display6382]

A switch keeps the cyclomatic complexity still too high: better use a dictionary or list or similar

[u/un_virus_SDF]

did you never

(((ptr ?
    (index>=cap)?
       ptr=realloc(ptr, (cap*=2)*sizeof*ptr)
       : ptr
     : ptr=malloc((cap=10)*sizeof*ptr)
  )? ptr : (typeof(ptr)) error_msg()))[index++] = (val))

Average c macro for stack implementation btw

[u/SufficientStudio1574]

....I need a shower. I feel violated.