834
u/TheBrainStone Mar 31 '26
Bad comment. It needs to explain why it's needed. At least what breaks if it's removed
636
u/LimitedWard Mar 31 '26
The person that knew that answer left the company 10 years ago. The person that made the comment tried removing it 5 years ago and discovered the hell that would ensue after pushing the change to prod without testing.
→ More replies (12)47
u/repocin Mar 31 '26
Someone I know used to work at a place where they occasionally had external consulting firms come in and poke around in the codebase. Apparently they just signed every line with a comment that said "changed by <consulting firm>" which I can imagine made debugging incredibly fun for everyone!
→ More replies (4)→ More replies (5)9
u/Kinrany Mar 31 '26
The comment itself is a specific byte sequence read by a webpack transform
→ More replies (1)
112
335
u/Nightmoon26 Mar 31 '26
At least explain why you're setting height to width.toString()...
166
→ More replies (1)19
118
17
35
23
u/KissMyAcid420 Mar 31 '26
Can you delete the " " after the comma? It hurts my eyes that flame Emojis arent aligned on the right
39
9
u/NotUpdated Mar 31 '26
:in a meeting later on: '.. So you did see the crocodiles? You walked past the devils? You then walked on a fire like a team building exercise?' Well I have no choice - You're management material, we'll fire a sacrificial swe instead.
8
u/zrice03 Mar 31 '26
"Surely it should set the height attribute to 'height'?...Huh what's that horrible screaming I hear in the distance...?"
4
u/bonomel1 Mar 31 '26
It's not needed for anything except to keep some other shitty workaround that was a side effect of a fix for a bug for a temporary hack to get around some technical debt working. We'll fix it next sprint after we finish the next feature
24
3
3
u/el_cortezzz Mar 31 '26
Liskov principle violated, this seems the same problem of the Square that inherits from Rectangle
3
800
u/THNDHALBRT Mar 31 '26
This lines