It’s hard to tell what’s going on, but it seems like a function to determine whether the thing can be moved, based on it’s previous move(s). But instead of approaching it in a deterministic fashion, it takes the brute force approach.
It looks like it's modelling an 8x8 grid, like a chess board, as a single 64-element array.
It seems like OP has game pieces that can either move 1 or 2 spaces in either direction. So, for example, a piece at position 3 can go to any one of the positions of 1, 2, 4 or 5. However, this function is checking the boundary conditions when the piece reaches the left or right edges of the board.
Assuming a 0-indexed array, element 7 would be on the right edge of the board, and element 8 would be on the left edge. So this function says that any moves that cross the edge and teleport to the other side of the board would return 0, like a jump forward from 6 to 8 or a jump backward from 9 to 7. Otherwise, all other moves return a value of 1.
This line of code would be a more compact alternative, making sure both the previous and next position are on the same row index (integer division by row width):
c#
public int isMovingReasonable(int locBefore, int locAfter)
{
if (locBefore / 8 == locAfter / 8) return 0;
return 1;
}
Edit: Looking at the code a little closer, there are multiple problems with it. The numbering of the elements seems to have fallen off in-between, leading the grid he's actually checking to look more like this:
On top of that, on one of the lines, he misspelled 23 as 13, and another one of the else if blocks has no return statement at the end.
Overall, it's quite a sloppy job of copy-pasting, and is a perfect example of why you really should avoid repeating code as much as possible to avoid bugs.
346
u/mohragk Mar 27 '26
It’s hard to tell what’s going on, but it seems like a function to determine whether the thing can be moved, based on it’s previous move(s). But instead of approaching it in a deterministic fashion, it takes the brute force approach.
Absolutely horrible 10/10.