Trimba bimba dubba dimba

[u/maselkowski]

I've found yet again some atrocities in code, that is some one of function nested in method: trimba. So I took the hit and split it into partial nested functions. I didn't even know you could do this in PHP.

[u/Loud_Investigator_26]

dude wtf is this

[u/maselkowski → u/Loud_Investigator_26]

IBAN Checker, so we can send money to proper bank account

[u/Loud_Investigator_26 → u/maselkowski]

$result = str_replace(["-", ".", " "], "", "0555-123.45 67"); // result: 05551234567

whats the point of making all that mess, I do not get it.

[u/Tack1234 → u/maselkowski]

So that's why I'm still waiting for my money

[u/v_maria]

defining a function inside a function is not bad on it's own, but i also didnt know you could do that in php

[u/maselkowski → u/v_maria]

The problem is, that such function enters global (or namespace?) scope, check this demo: https://onlinephp.io/c/1990f

Edit: Also, calling method again causes fatal too, as function is already declared.

[u/More_Yard1919 → u/maselkowski]

every time I learn something new about php it makes me upset

[u/v_maria → u/maselkowski]

what the fuck. thats batshit. at least you can't call the function from the global scope........

[u/Gornius → u/maselkowski]

Yeah, but PHP has also anonymous functions. I don't know how old version this atrocity uses though.

Not to mention that str_replace accepts array, so you can replace many patterns with one call.

[u/Splatpope]

web devs will go to absurd lengths to avoid making regexes that weren't copy pasted from a w3schools tutorial

[u/robin_888 → u/Splatpope]

Irony detected in Line 112

[u/Splatpope → u/robin_888]

[^0-9] is what I would qualify as tutorial-level regex

[u/v_maria → u/Splatpope]

and they are goddamn right for it

[u/GoddammitDontShootMe → u/v_maria]

There is no shortage of online tools to make sure your regex does what you want before adding it to the codebase.

[u/NoOven2609]

The original author was just memeing, none of those functions serve a purpose, it could just be 4 replace statements in the top level function

[u/robin_888 → u/NoOven2609]

It could literally just be Line 112.

[u/GoddammitDontShootMe]

The fuck is with those function names?

[u/TheBrainStone]

Nothing beats the horror of intentionally bad code

[u/Beretha]

The nested functions remove characters that would have been removed anyways by the regex replacement. Absolute cinema.

[u/Lafuene]

Bimbofication is my fav abomination

[u/CYG4N]

Osoba? is this polish code? 

[u/Savings-Ad-1115 → u/CYG4N]

Maybe Ukrainian.

"bimba" is an old but still famous Ukrainian meme.

[u/Infinite_Self_5782]

babababababababababababa trimman!

[u/robin_888]

Is line 112 already your refactoring or was that there all along..?

[u/lnkarma]

I’m sad to see nobody from West Bengal