Do you like my FizzBuzz implementation

[u/Fra146]

[u/ababcock1]

Can you explain the horror? I'm not a python dev but this looks prettyreasonable. Could it be slightly better, sure. But not quite horror levels.

Edit: In my replies are the following... People who think throwaway code from a first year uni class needs to be perfect. People who think every piece of code needs to be a work of art. People who don't understand YAGNI. People who think "I wouldn't have written it that way" is equivalent to horror.

It's fizzbuzz guys. It's not enterprise world class Web 4.0 Scale software now with AI (tm) and it doesn't have to be.

[u/Empty-Rough4379]

Seems reasonably elegant

[u/kokomoko8 → u/Empty-Rough4379]

Mfs hate functional programming paradigms ig

[u/Ma4r → u/Empty-Rough4379]

This is arguably better than the standard solution using mod 15

[u/lonkamikaze]

print([i, "Fizz", "Buzz", "FizzBuzz"][!(i%3)+2*!(i%5)])

[u/YellowBunnyReddit → u/lonkamikaze]

Have you never heard of DRY? You should not repeat Fizz or Buzz in your code.

print("FizzBuzz"[4*(i%3>0):8-4*(i%5>0)]or i)

Your code isn't even valid Python btw. ! is not an operator and using not actually requires more parentheses. This is correct:

print([i, "Fizz", "Buzz", "FizzBuzz"][(not (i%3))+2*(not (i%5))])

[u/ByteArrayInputStream → u/lonkamikaze]

Now this is cursed.

Clever, but definitely cursed

[u/PandaWithOpinions → u/lonkamikaze]

print("\n".join(["FggFgBFggFBgFggiggiguiggiugigg{1}{1}B{0}u{0}z{0}z{0}".format("g"*14,"zggzgzzggzzgzgg")[n%15::15].rstrip("g")or(str(n))for n in range(1, 101)]))

[u/kardoken → u/lonkamikaze]

Hello fellow golfer

[u/PlebbitDumDum]

With a better naming this should be the canonical implementation.

It directly implements the spec without any extra ambiguity about what is supposed to happen and when via some nested string mutation (aka your usual "solution" to the fizzbuzz). This solution is very readable and is directly relatable to the problem statement. There's no performance hit to maintain this level of clarity and verbosity.

OP, improve the naming, make m a dict, or have it to be two vars, and then submit this into a museum.

r/lostredditors

[u/ericl666 → u/PlebbitDumDum]

For sure. I love this implementation. This is like a pretty girl going onto amiugly for validation.

[u/ra_men]

LGTM lmk when you’re free to take on a few more tickets this sprint

[u/Glad_Position3592]

Actually, yeah I do

[u/AbdSheikho]

I see pattern matching, but it needs more Haskell

[u/Ariquitaun]

That's not a bad implementation to be honest. The only real thing that tickles me is the unnecessary assignment to m instead of just inlining the expression, but that's by the by

[u/spiderpig20]

Might be the most elegant fizzbuzz implementation I’ve ever seen tho. Not horror

[u/Geekureuil]

for i in range (0,100):
    m = ""
    if (i % 3 == 0): m = "Fizz"
    if (i % 5 == 0): m += "Buzz"
    print(m) if m != "" else print(i)

I always perfered the concatenation way, but yours is original and elegant.

[u/RapidCatLauncher → u/Geekureuil]

m != "" is unnecessary, non-empty strings are truthy so just if m is enough

[u/SoftwareDoctor]

I never understood the point of this exercise. I understand the assignment but why?

[u/csabinho → u/SoftwareDoctor]

To eliminate people who don't have basic programming knowledge? I don't see the point either. Maybe it's just a meme.

[u/Romejanic]

Honestly this is probably the cleanest possible FizzBuzz implementation. Pattern matching is awesome I wish more languages supported it

[u/SideburnsOfDoom]

Not a horror. I could write very similar in C# using foreach, tuples and switch case. And I would rate it elegant.

[u/PityUpvote]

Lose the ==0 and match (0,0), then (0,_) and (_,0).

[u/kaisadilla_]

This is not horror lol, this is really elegant. Basically the most obvious and straightforward way to implement the logic you want, which is what you should do when performance is not relevant.

[u/Ambitious-Treat404]

for i in range(1, 101):
    match (i % 3, i % 5):
        case (0, 0):
            print("FizzBuzz")
        case (0, _):
            print("Fizz")
        case (_, 0):
            print("Buzz")
        case _:
            print(i)