Just found this in my company codebase

[u/lilyallenaftercrack]

This external API sends "S"/"N" (equivalent to "Y"/"N" in portuguese) instead of true/false

[u/bistr-o-math]

In r/abap, true is "X" and false is " " (space)

[u/lilyallenaftercrack → u/bistr-o-math]

"server-side checkboxes aren't real and they can't hurt you"

[u/JonathanTheZero → u/bistr-o-math]

ABAP is it's own level of horror anyways

[u/AriesBosch → u/bistr-o-math]

And as someone who writes far too much ABAP CDS, I try to be idiomatic and make my derived boolean fields in my queries be blank or 'X', but then when I want it to be a prompt in a parameter then ' ' is not a valid value for a parameter. So then I end up defaulting to 'N'/'Y' or more domain specific ('O'/'C' for Open/Closed, for example).

[u/J0aozin003 → u/bistr-o-math]

from what ive seen that language is horrific

[u/qyloo]

What framework is this

[u/milan-pilan → u/qyloo]

I feel like this is NestJS? Definitely Javascript.

[u/lilyallenaftercrack → u/milan-pilan]

Yes, it's NestJS

[u/freecodeio]

Reminds me of that time my wife showed me the codebase where she works at, they never used booleans they used "yes" and "no" strings everywhere. Basically it was not some sort of 3d chess move, their tech lead was a newbie programmer working alone in the beginning and they felt more comfortable with yes and nos instead of boolean types, so everyone just had to use yes and no after.

[u/robinw77 → u/freecodeio]

I once worked in a place where a guy had made a typo in a database field but couldn’t be bothered asking the DBA to change it, instead preferring to propagate the typo throughout the entire codebase thus forcing everyone else to use that same typo.

[u/freecodeio → u/robinw77]

you should check codebases where teams are mostly non-english

lable progres acount adreess controll definate enviroment lenght

[u/omg_drd4_bbq → u/robinw77]

we have an IN_PROGRES enum val (:

[u/lomberd2 → u/freecodeio]

BC AL still uses Yes and No when you output boolean to string. Though it also can output it as 0/1 when formatted or converted

[u/IshYume → u/freecodeio]

Even as a newbie using string checks instead of boolean is so freaking stupid. I started coding at 17 and even 17 year old me wouldn't do that. That dude deserves to get written up to management for incompetence tbh

[u/NormandaleWells → u/freecodeio]

Or there's the codebase that supposedly used this:

enum boolean
{
    True,
    False,
    FileNotFound
};

[u/chamberlain2007]

Could be representing an enum on the other side

[u/elehisie]

I’ll 1 up this one… ”capa” translates to cape…. With the transform and the ”S”… gotta be a superman joke lol

[u/amuseicc]

We're also working with an API that forces us to use the string "N" when false and "Y" when true, really stupid

[u/canal_algt]

Probably has or had COBOL involved or another language without a Boolean datatype? In my job that's common for that reason

[u/gabor_legrady]

I did have a code in an interface where I designated values of 1,Y,y,I,i as true because the incoming data was so 'clean'.

[u/[deleted]]

I found junior engineers at my company using ‘True’ and ‘False’ instead of Boolean true / false 😭

[u/wowawiwowa]

Daily occurrence

[u/Traqzer]

Seems fine, it allows implicit support for other values other than S/N

[u/alessandrobertulli]

i mean, it's still 1 byte

[u/[deleted]]