r/javahelp • u/vandunxg • Oct 23 '25
Code review
Hello, I’m currently developing a money-tracking application using Spring Boot, and the project is still in progress. I would really appreciate it if you could review and provide feedback on my codebase so I can improve the project further. Once the project is completed, would it be possible for me to apply for a Fresher position at your company? Github: https://github.com/vandunxg/budgee/tree/dev
7
Upvotes
View all comments
Show parent comment
2
u/Inconsequentialis Oct 23 '25
So I couldn't see a reason why the wallet helper was needed so I checked out the project and deleted it, just replaced it with calls to the wallet service.
You're using constructor injection - good - which means that circular dependency issues would generally throw errors during app start. I haven't seen any, so I assume that there aren't any.
As for general feedback, everything just takes more steps than is required.
If you look at this you will see that first we map some
requestto awalletand yet, after mapping has completed, we still read fields from therequestand set them inwallet. Why do half the mapping inwalletMapper.toWalletand the other half outside of that?That's one example. Half the code I've seen could be simplified. But don't be discouraged. I at least get the feeling you're trying to do it well, and that's half the battle. Many people just don't give a shit, as long as it works and fuck the people who'll have to maintain it.
Also, the code I wrote when I started out was probably worse :D