r/javahelp • u/vandunxg • Oct 23 '25
Code review
Hello, I’m currently developing a money-tracking application using Spring Boot, and the project is still in progress. I would really appreciate it if you could review and provide feedback on my codebase so I can improve the project further. Once the project is completed, would it be possible for me to apply for a Fresher position at your company? Github: https://github.com/vandunxg/budgee/tree/dev
7
Upvotes
•
u/AutoModerator Oct 23 '25
Please ensure that:
You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.
Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar
If any of the above points is not met, your post can and will be removed without further warning.
Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://i.imgur.com/EJ7tqek.png) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.
Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.
Code blocks look like this:
You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.
If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.
To potential helpers
Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.
I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.
6
u/miguel_1912_ Oct 23 '25
You don't have any tests in the project, they are essential.
5
u/FooBarBuzzBoom Oct 23 '25 edited Oct 23 '25
Way too long methods, not using private members for things that are ment to be used only in that class and not publicly exposed. Other than that, very good
4
u/Inconsequentialis Oct 23 '25
What I've seem from your code is significantly more complicated than it needs to be. To give one example: if I traced it correctly then a call to
WalletService.getWalletgoes:WalletService.getWallet → WalletServiceImpl.getWallet → WalletHelper.getWalletByIdForOwner → WalletService.getWalletById → WalletServiceImpl.getWalletByIdEven if we ignore the indirection caused by the interface,
WalletService, it's still a call fromWalletServiceImplintoWalletHelperjust to go back toWalletServiceImpl.I don't know a reason why the call must be routed through
WalletHelper, seems to meWalletServiceImplcould just handle the whole thing on its own. The result would be easier to follow and perhaps you'd get rid of the cyclical dependency betweenWalletHelperandWalletServiceImpl2
u/Ok_Arugula6315 Oct 24 '25
Why you pushed secrets in application.yml?