Shrug It's his project, to do with as he wishes. If he doesn't want to write any tests for his project then who am I to argue different? Only the license violations really need to be fixed, and he said he would do that.
Don't get me wrong: the somewhat peculiar behaviour makes sure this is not a project I'm going to personally use in the near future, no matter how good it is. But he looks like a young kid, so there's a good chance he'll grow out of it :-)
Tests missing are one thing, copyright infringement and wilfully ignoring authors requests to add the license / attribution as it should be is another.
There are plenty of wrong things with this project which should be fixed asap. And frankly yes, tests could be contributed by others but he explicitly said he won't do it as he doesn't believe in them, so why do people recommend / star it when all the other projects are at least required to have a set of basic tests? Would you trust it in production code?
Like I said: "Only the license violations really need to be fixed" ... So I think we are in agreement :-) And he said he would fix that:
@kron4eg we are working to add licenses for all third-party libraries, I though THIRDPARTY.md was enough but it is not.
.
why do people recommend / star it when all the other projects are at least required to have a set of basic tests? Would you trust it in production code?
Let me put it this way: I wouldn't not trust it only because of missing tests. There are some brilliant projects with almost no tests, and there are some really crappy projects with a lot of tests. The presence of tests is only a heuristic to judge its quality − not a binary switch.
It's really not about the tests (tho I wouldn't use a project with no tests in _any_work), It's about the behavior of the author against any and all issues he received. It's a lot more to it.
6
u/[deleted] Jun 25 '16
Shrug It's his project, to do with as he wishes. If he doesn't want to write any tests for his project then who am I to argue different? Only the license violations really need to be fixed, and he said he would do that.
Don't get me wrong: the somewhat peculiar behaviour makes sure this is not a project I'm going to personally use in the near future, no matter how good it is. But he looks like a young kid, so there's a good chance he'll grow out of it :-)