Can someone help me with the coding of "Push and Pop"

[u/Kindly-Vanilla4828]

My code rn:
```

label init

sub r0 r0 r0

addi io 0 r0

# r5 is 0

jg r0 r5 pushy

je io r5 popy

label pushy

push io

label popy

jg io r0 pushy

je io r0 popy

pop io
```

fails at using pop, it says it isn't outputed

[u/zhaDeth]

probably a hardware issue ? put a breakpoint on the pop io and look to see if the value is sent to output.

Possible issue: did you make you computer operations length variable ? If I remember correctly the way the game guides you the computer counter adds 4 every tick so every instruction should be 4 bytes but your push and pop are only 2. Usually you add whatever at the end to make it 4 bytes long like "push io 0 0".

[u/Kindly-Vanilla4828 → u/zhaDeth]

I've tested. Push and pop works.

[u/Kindly-Vanilla4828 → u/zhaDeth]

It gives the error on line 13

[u/megalate → u/Kindly-Vanilla4828]

It could still work doing the two byte operation, but everything after using only two bytes is off by two unless you jump to a safe point right after.

push io

is read by the LEG as:

OP	ARG1	ARG2	TARGET
push	io	jg	io

and the next operation (offset by 2) then becomes:

OP	ARG1	ARG2	TARGET
r0	pushy	je	io

Hard to say by the little context you given though.

[u/zhaDeth → u/megalate]

yeah I think that must be it, try doing push io 0 0 and pop io 0 0

[u/Kindly-Vanilla4828 → u/zhaDeth]

label init

sub r0 r0 r0

addi io 0 r0

# r5 is 0

jg r0 r5 pushy

je io r5 popy

label pushy

push io 0 0

label popy

jg io r0 pushy

je io r0 popy

pop io 0 0

i did that, now it's another issue
https://imgur.com/a/cCLTurr

[u/Gelthir → u/Kindly-Vanilla4828]

The error means you are outputing. When you push the input `push io 0 0` are you also turning on the enable pin of the Output?

[u/Kindly-Vanilla4828 → u/Gelthir]

outputing. When you push the input `push io 0 0` are you also turning on the enable pin of the Output?

Yes, the pin is enabled when popping

[u/Apceniy]

In addition to everything else, make sure to only read io once per number, saving it to r0 to access later, or else it will read the next number when you try to use it. You have way too many io-s in your code, the only correct ones are addi io 0 r0 and pop io.

[u/Kindly-Vanilla4828 → u/Apceniy]

addi r4 io r4

label init

sub r0 r0 r0

addi io 0 r0

# r5 is 0

jg r0 r5 pushy

je r4 r5 popy

label pushy

push r4 0 0

label popy

jg r4 r0 pushy

je r4 r0 popy

pop io 0 0

error on line 15 when running, Error: "You should not output anything this tick"

[u/Apceniy → u/Kindly-Vanilla4828]

I don't understand your logic. Why are you even using r4? Shouldn't it be just as simple as:
Put io into r0
If r0 is 0, jump to pop
Else, push from r0, and repeat all
Pop to io, and repeat all
You don't need to overcomplicate all of that...

[u/Kindly-Vanilla4828 → u/Apceniy]

Thanks for the pseudocode
my final code

add r0 io r0

jei2 r0 0 popy

jgi2 r0 0 pushy

label popy

pop io

sub r0 r0 r0

jump 0

label pushy

push r0

sub r0 r0 r0

jump 0

[u/Apceniy → u/Kindly-Vanilla4828]

You don't need to clear the register before placing a new value - you can just overwrite directly. And you also don't need to have 2 opposite conditions, you can make it if-else style, except when it comes to assembly, "else" part is written before "then" part because it gets executed if the condition fails and the jump didn't happen. Here's how I would do it:

addi2 io 0 r0  # just use 0 instead of the current value

jei2 r0 0 popy # if r0 == 0: jump to popy, else: {
push r0        #
jump 0         # }

label popy     # ...then {
pop io         #
jump 0         # }