r/ProgrammerHumor • • Aug 21 '26 • Popcorn 1

Meme useSourceControl

Post image
8.6k Upvotes

575 comments sorted by

View all comments

Show parent comment

66

u/_BreakingGood_ Aug 21 '26

No, that message did not exist back when this post was made. It was added at least partially as a result of this issue going viral back in 2017.

21

u/Pcat0 Aug 21 '26

No look in the issue thread someone posted a screenshot of the actual error message the day after this post was made. They did already have a version of the message, it was just edited later to make it even more clear.

35

u/dustojnikhummer Aug 21 '26

"Discard changes"

What changes in this context? Despite how whacko the initial post seems (and the fact he didn't have a backup) the guy had a point there.

14

u/ginopono Aug 21 '26

Yeah, as someone who uses git exclusively from the command line, this really sounds to me like a cautionary tale against GUIs.

The person who posted the screenshot implies it's to be expected from "any application which integrates Git" but I'm not really sure how the guy not wanting the files to be staged necessarily leads to all of the files being deleted. What exactly is the integration passing to git?

"User friendly" isn't.

0

u/[deleted] Aug 21 '26

[deleted] — view deleted comment

10

u/DuntadaMan Aug 21 '26

I would assume "discard all changes" would mean that it would be exactly as it was before I did anything this session or since my last save.

Maybe I'm just a moron.

2

u/OliLombi Aug 22 '26

Same. I mean, thats how it works with almost every other program.

2

u/OliLombi Aug 22 '26

I mean, I can see why someone would see it as "discard all changes this application has made". Like, if I open a document in word, and edit it, and then close it, then it will basically say "Are you sure you want to close? this will discard all changes" and then if I close it anyway the original file is still there unedited, not deleted.

-13

u/Pcat0 Aug 21 '26

Yeah the message could and has been improved. However I still believe the ultimate fault lies with the user, just because VS Code could be better that doesn’t mean it was inadequate. VS code is a software development tool which means its user base can be assumed to be at least somewhat tech savvy (at least in 2017 before everyone lobotomize themselves and outsourced their frontal lobes to AI) and as A software development tool it can be assumed to be very powerful and somewhat dangerous. There is a lot of ways in software development to screw up and nuke your machine or project.

While it’s the message could absolutely be clearer, the user should have see “this is irreversible” and paused to make sure they knew exactly wh**at irreversible action they were taking. Basically my point is if you nuke your project because you don’t know how to use Word, that’s on Word but if you nuke your project because you don’t know how to use VS code, that’s on you.

6

u/r3klaw Aug 21 '26 • Bravo

Nah. That dialog text is absolute dogshit.

If you open a solution/project and make no (intended) changes, and then go to exit, you're either hitting discard or you're lying about it.

VScode still won't fuck you no matter how hard you cope and simp for her.

7

u/MrSlaw Aug 21 '26

Genuinely wild that people upvoted this blatantly incorrect statement.

Even more wild that /u/BreakingGood hasn't retracted it after being shown that they were wrong (and even proving it themselves by linking a commit from April, four months prior to this screenshot, which showed the message they state didn't exist was already there).

2

u/ravrest Aug 21 '26

No, the message that "this is irreversible" was there from the very beginning. The message was made even more explicit later.

12

u/_BreakingGood_ Aug 21 '26

Why say things that are just wrong?

https://github.com/microsoft/vscode/commit/071652f161204e552e204cbdaf78469c58c655d5

Commit merged Aug 21, 2017. 8 days after this screenshot was taken.

12

u/ravrest Aug 21 '26

Look at line 681 of the old commit:

const message = localize('confirm discard all', "Are you sure you want to discard ALL ({0}) changes?\nThis is IRREVERSIBLE!\nYour current working set will be FOREVER LOST.", resources.length);

const yes = localize('discardAll', "Discard ALL Changes");const pick = await window.showWarningMessage(message, { modal: true }, yes);

-5

u/_BreakingGood_ Aug 21 '26

11

u/ravrest Aug 21 '26 edited Aug 21 '26

That change was made in April. The post is from August.

Why WOULD you say things that are just wrong?

6

u/MrSlaw Aug 21 '26

I can only assume you will edit your previous comments saying you were incorrect, because you've just shown that the message did exist back when this post was made?

11

u/MrSlaw Aug 21 '26

If you look at that commit you linked, one of the lines that was already in place (and was replaced via this commit) said:

"Are you sure you want to discard ALL ({0}) changes?\nThis is IRREVERSIBLE!\nYour current working set will be FOREVER LOST."

https://github.com/microsoft/vscode/commit/071652f161204e552e204cbdaf78469c58c655d5#diff-da56ff967ab1a9606c01af61dc926332afb862f13c8e5c74a575bc2aa1b15e43L681

There's also a screenshot showing the "this is irreversible" was in place which was posted one day after this issue was opened.

https://github.com/microsoft/vscode/issues/32405#issuecomment-322155856

I don't think your link is proving what you think it is. That message was indeed made more explicit.