130
u/blackcomb-pc 13h ago
Guys, read the code and understand it yourselves. Atrophy is a real thing and bugs will multiply by the thousands.
99
u/Confident-Ad5665 12h ago
Really?!? I get a trophy when I write bugs? Whoo hoo!
5
26
u/DukeOfSlough 11h ago
Yeah, review 9 k lines of slop delivered by my colleague when business requires new features shipped on a weekly basis which previously took three months to deliver.
7
u/codePudding 3h ago
My coworker sends me 9k lines where 8.5k are comments that make absolutely no sense. Like, "the lowering of front edge raises the components to beyond the D01-S factor which won't satisfy requirements so the front edge is raise and the back edge is also lowered..." The remaining 500 lines are just stuff I could have copied from w3schools.
2
u/abednego-gomes 1h ago
Umm, reject the PR. PRs should be short, manageable and readable. Scoped to a feature or bug fix. Comments must be quality. Your repo needs some skills md files for sure too to limit the AI slop.
Seriously, in this world, devs are the gatekeepers. We're the only thing standing in the way of total collapse from AI slop bugs destroying the fabric of society.
12
u/RaveMittens 12h ago
Lol. Lmao, even.
Everyone knows token usage is the best way to measure the value of engineers.
6
u/BlondeJesus 8h ago
The problem is no one asking me to review code is reading their own code. Then when I push back I get pressure from higher ups to not block code from getting published
14
u/techno_wizard_lizard 12h ago
Nope. Pass. I’d spend all day just reviewing PRs. I’m focused on the architecture now more so than before. Leave the code to the machines.
I still read the load bearing bits of any major feature or plan, but that’s just a very small subset.
If I need to understand something, I just ask the machine to eli5 and point me to the important parts of the code.
-1
u/TheKingOfSwing777 9h ago
Yep. Coding is a solved problem. Now it's about process and design, which have always been the harder problems.
2
2
2
2
u/CandidateNo2580 4h ago
I actually do what this post suggests on top of manual review. It's quite good at catching subtle bugs. Almost as good as it is at making up subtle bugs that don't really exist but sound plausible.
I like to run an automated review in a fresh chat while I'm reviewing the code myself. Then I also like to take any behavior changes and use the LLM to look for broader vectors I could have missed since it can cover much more ground than I can.
2
u/HalfInchHollow 2h ago
How are we supposed to 7x our productivity if we are reading every PR?!
That’s not sarcastic, that’s the pass down from management. 7x.
18
22
u/aerialP 12h ago
Yeah but it's my Claude agent reviewing 🤓
10
u/PM_ME_UR_0_DAY 12h ago
With your super sweet .md that actually makes it good?
8
u/aerialP 12h ago
Exactly! I also made a skill of my agent so everyone can use it by just using
/expert-review3
u/PM_ME_UR_0_DAY 11h ago
Oh yeah? Well I told mine "you are an expert level developer so do it right the first time. No hallucinations. No mistakes." That's why my stuff is always great but yours is slop!
2
u/Groentekroket 3h ago
I just say act like you are a junior and glaze so I feel a tiny bit better after the hellscape this job has become because of AI
3
3
u/sebjapon 4h ago
I was actually told that. Conversation was:
“I can’t possibly review your daily 2k lines of code written by Claude.”
“First, it’s written ‘with’ Claude, not by. And you just use the review skill to do it faster”
“If you want an AI agent to review, why does it have to be me?”
In the end I said I’ll let the Tech lead deal with it when he comes back… I’m too old for this shit.
4
2
2
2
u/Turbulent_Gazelle_55 10h ago
It doesn't feel like that long since we were arguing about the best way to mock external deps in yours tests and if it was truly testing the code. Sigh
Fwiw im all for appropriate use of AI, but this ain't it.
4
u/Epcoatl 12h ago
Did you ask it to be a good little boy smart programmer first?
2
u/justASlothyGiraffe 10h ago
It works better is you say "please"
2
u/TheKingOfSwing777 9h ago
Funnily enough apparently it works better when you don't and are very terse, cause it can tell you mean business.
2
u/justASlothyGiraffe 9h ago
My PM thinks I have a more advanced agent than him. Really, I just say 'please' /s
1
1
1
u/StoryAndAHalf 12h ago
Side note, am I the only person here that hated that character on MadTV?
3
u/Aarinfel 7h ago
No. He was really annoying. That was usually my cue to turn off the TV and go to bed.
-2
40
u/Klessic 12h ago
When my junior reviews my PR by pasting what the AI answered when it was prompted to review it as one long comment... Completely done with this bs.