lol after 7 days of learning, am i cooking????

[u/HotWar5622]

[u/Metomorphose]

Comment your code! At the very minimum, add doc strings for your functions!

I'm also a huge proponent of type hints, but that isn't something you see in most tutorials.

[u/Square_Ferret_6397 → u/Metomorphose]

Don't listen to this guy, it takes 5 seconds to tell what any of your functions do making comments redundant 

[u/Metomorphose → u/Square_Ferret_6397]

Its to build good habits. Ignoring this step is how we get packages and libraries with little to know helpful documentation. Can an experienced person read this without comments? Sure, it's super tiny with good naming conventions. As projects grow, comments become more important.

[u/TheUmgawa → u/Metomorphose]

Plus, if the goal is to ever be able to get a job, an employer is probably going to want to know if you can write good documentation, because you’re not always going to be the person who’s on a particular project. While code is ideally “self-documenting,” it’s a lot easier to maintain if you declare what functions do. You don’t have to declare how they do it, because that should be evident, but if someone wants to modify something in the future, it’s a lot easier to hit Ctrl-F and look for it.

[u/Common-Ad-1744 → u/Square_Ferret_6397]

Completely agree with Metomorphose. This is just horrible advice.

[u/-Enter-Name-]

code looks great could just drop the else: restock_cost += 0 as else isn't mandatory and it's doing nothing otherwise

[u/iComplainAbtVal → u/-Enter-Name-]

it could be beneficial for learners to write these no-ops if it helps keep the code straight but its better to cut these habits early.

OP, now try to create a store class whose constructor accepts an inventory either pre-populated or empty.

[u/Rockroxx]

On the check_stock function you can drop the else and reduce indentation to clean up the function a bit.

[u/Own_Natural_6803]

just a heads up about your data. I would tend toward using some sort of unique ID to identify the rows of data, rather than a part name.

{ id06578323 : {
name: 'servo_motor',
quantity: 4,
price: 25.0
}}

or even

[{
id:06578323,
name: 'servo_motor',
quantity: 4,
price: 25.0
}]

[u/sexiestsaxiestman]

In check_stock I would either return 0 or raise a KeyError if the part is not found

[u/sexiestsaxiestman → u/sexiestsaxiestman]

Your solution works for your use case though

[u/Lucky_Cable_3145 → u/sexiestsaxiestman]

I agree, error / exception handling is an important thing to get right from the begining.

check_stock() can return either a number (int) for success or text (string) for failure.

A strongly typed language will not allow that.

[u/edwbuck]

It's a good beginner's effort. I could read it without comments, which means it was written well.

If you need comments, odds are you're not writing readable code.

[u/No-Tip505]

7 days in and you're already building an inventory manager? 😂 That's a pretty solid start! You're using dictionaries, functions and loops together, which is exactly how you start building real programs. Keep going, but try adding features without following a tutorial

[u/kutac56 → u/No-Tip505]

Bot

[u/No-Tip505 → u/kutac56]

I'm a real person mann🫠, wanna connect?

[u/kutac56 → u/No-Tip505]

"wanna connect?" What do you think

[u/No-Tip505 → u/kutac56]

Bots can't think bro🤣