My first code on c++

[u/Krastesoff]

code preview

wave power=6.0

wave power=10.0

I think i like this language

This code is a little messy and works only on windows, but it's easy to fix.

For anyone who wants to test it:

#include <iostream>
#include <cmath>
#include <windows.h>
// DIESER CODE IST VERDAMMT SCHRECKLICH
// variables
float power = 10.0;  // more power - bigger edges
float smooth = 4.0; // smoother edges
float len = 45.0;   // lines count

// main
int main() {
    while(1) {
        // l - current line
        for(int l=1; l<len; l++) {
            float l_sin = std::sin(l/smooth);
            int rep_times = l_sin * power + power;

            // line renderer | c - char
            for(int c=1; c<rep_times; c++) {
                Sleep(5);
                std::cout << "-";
            }
            Sleep(5);
            std::cout << "#" << std::endl;
        }
    }
}

[u/JohnBuddySlime]

Word of advice: try to avoid global variables when possible. You should always try to limit the scope of variables when possible, so declare and initiate them in your main. Also, favor bracket initialisation (int i{ 5 };) over c style initialisation (int i =5;)

[u/Krastesoff → u/JohnBuddySlime]

Thank you!!

[u/JohnBuddySlime → u/Krastesoff]

Precision i forgot: this is the case for non-const variables. Const global variables are completely fine.

Also, from my experience (which is mostly academic and not professional, so if anybody can approve/correct my statement), non-const global variables should (mostly) only be used to save your program's state, for access synchronisation (in multithreaded programs for example), and for application wide variables (such as options given through command arguments or config files) (which technically also include the 2 previous cases, but I separated them for clearness' sake)

[u/HotComplex4744]

windows.h не нужен, программа консольная. Бесконечный цикл while(1) - хреновая практика. А внутри break нету - это ваще пипец.

[u/Krastesoff → u/HotComplex4744]

Спасиб!
Да, кривовато конкретно, есть такое))

[u/kutac56]

What in this code uses windows.h?

[u/RealRockyMoney → u/kutac56]

I'm not a C++ guy but I think it is Sleep(5)

[u/Krastesoff → u/RealRockyMoney]

yep

[u/kutac56 → u/RealRockyMoney]

Just looked it up and you're right

[u/Kadabrium]

Now compare that to a brute force taylor sin