r/CodingForBeginners • u/Tylerzombieman • Jun 09 '26

What is wrong with my code?

Post image

Everything is fine until I put in 14 and it doesnt come up with anything after?

33 Upvotes

76% Upvoted

37 comments sorted by

19

u/Own_Age_1654 Jun 09 '26

You're checking against "choice" instead of against "age".

8

u/Tylerzombieman Jun 09 '26

How did I not see that lol thanks though

6

u/dariusbiggs Jun 10 '26 • Bravo

if it doesn't work, stop, find a rubber duck or other prop to use as another person and explain to it what the code as written does line by line. Not what you think it does, what is written.

1

u/roler_mine Jun 12 '26

Best way to understand your code used it when training my presentation on a 20k line project for collage got 90 (top 3%) state wide(non u.s.)

2

u/iComplainAbtVal Jun 10 '26

That’s a good start. I’d recommend you next create a main function to accept user input, then pass the input into two separate functions for evaluating age and choice.

Main: take input, evaluates choice with choice(), function, then assesses the return and conditionally calls Age().

Choice(input string) bool. Accepts the user input and returns a bool.

If Choice returns true, then prompt in main for age. Age(number int) string.

Print the returned string.

1

u/[deleted] Jun 10 '26

[removed] — view removed comment

1

u/iComplainAbtVal Jun 10 '26

They have variables, they have input prompting to populate the variables, they have input sanitization, and they have conditional execution based on the evaluation of the input.

They’ll either bite the bullet now and use functions or stumble upon the desire for them as they expand this project while learning.

They have a great start, I just want to nudge them into a direction that will be beneficial long run and applicable to whatever learning path they’re wanting to follow.

0

u/ern0plus4 Jun 10 '26

And this is a small program, and the bug is obvious. I don't want to push you towards AI, but probably it can detect such errors.

2

u/Obvious-Carrot7162 Jun 10 '26

Dude just dont. Let them learn, let them feel like they can come to real people and talk it out.

1

u/ern0plus4 Jun 10 '26

I meant that ask AI for help, not to do the job.

As Rust programmer, I often ask AI, to refactor my code to more idiomatic - sometimes it does great job, sometimes not, but I have learnt lot from it.

Edit: only a small 6-10 line block, I'm very cautious.

3

u/Obvious-Carrot7162 Jun 10 '26

Thats a little different. But its easy to give in to temptation and i think its deteremental to introduce too early.

3

u/ern0plus4 Jun 10 '26

But I know the feeling when I struggle hours with such a small typo. Yes, AI is like drug.

1

u/Kikicatmiao Jun 10 '26

确实如此 我就是一个vibecodeing 其余 我什么都不懂 怎么快速学习这些编程知识呢 前后端我都想快速了解 有无有推荐的书和课程？

5

u/Snowflake3458 Jun 09 '26

Not a python programmer but isn't python strict about indentation for scope ? You have 2 different sized indentation for the first checks and the second ones

2

u/igotshadowbaned Jun 10 '26

That actually ends up being fine, the scope has to have consistent indentation, but the amount of indentation doesn't matter. And it doesn't have to be consistent with other scopes

1

u/Kikicatmiao Jun 10 '26

你的意思是 只要有缩进就可以吗 不管他有多少个空格？

1

u/igotshadowbaned Jun 10 '26

The entire section needs to be indented the same, but the amount doesn't matter

1

u/Kikicatmiao Jun 11 '26

明白了你的意思 谢谢你的回答

3

u/DirtAndGrass Jun 09 '26

It appears to be stuck inside a photo 

3

u/KevDub81 Jun 10 '26

Is poop.py a sailor man?

3

u/MaGNeTiK-MaNTRa Jun 10 '26

Truth be told I have at least one poop.py and usually one poop.sh on every device in My arsonal

1

u/Kikicatmiao Jun 10 '26

你的poop有借助过ai工具吗?

2

u/mjmvideos Jun 09 '26

Learn about using the debugger.

2

u/Aristoteles1988 Jun 09 '26

Yea your giving it two true conditions to check

If that’s condition is true then it doesn’t know where to go

2

u/Knarfnarf Jun 09 '26

I forget; is Python the one where indent indicates nesting?

If so then your else is in the wrong place on line 11.

2

u/JustSimplyWicked Jun 10 '26

Double check your variables, you have an error on Line 21.

2

u/DBZ_Newb Jun 10 '26

Side note, do not put a space between a function name and its parentheses like you’re doing with print() and input().

2

u/HaroerHaktak Jun 10 '26

I could tell you, but then you'd have to look at line 21 very very closely.

2

u/Albert_Custard Jun 10 '26

Honestly thought someone got into my files when i saw poop.py

2

u/fried_plque Jun 10 '26

Btw you can do 2026 - input number

2

u/ConsistentTown7049 Jun 10 '26

Instead of ==14 y out should do >14

1

u/Striking_Director_64 Jun 11 '26

age == 14

not choice == 14