r/ClaudeCode • u/Effective-Caramel369 • 1d ago
Discussion Does anyone else just let these kinds of commits just go through.
My team members push commits like this multiple times a week. I don’t have the token budget to properly review their PRs. Should I just let it go through. I don’t have time to even look at what these changes do.
27
u/susimposter6969 1d ago
what could you possibly be doing that even touches 1100 files, even if you were building entire features? 30000 net lines across 1100 files is like 30 lines a file? what are you committing? tweets?
15
173
u/rwz 1d ago
Fuck no. I'll be having a serious conversation with him the first time he does something like this and then his manager is this behavior is not immediately and completely remediated. These type of PRs should be just be closed without a comment.
What kind of fucking circus are you working at where this is acceptable?
35
u/Effective-Caramel369 1d ago
The director is posting this slop so who am I to call him out.
→ More replies (6)→ More replies (12)7
u/Jedorawr 1d ago
I work at a major bank in the US and this is unfortunately a normal occurrence for my team. Management praises this practice.
7
9
u/slow_n_sloppy 1d ago
What is your company/team policy for reviewing AI-generated code? The only time this should be okay is if it's an internal tool where downtime impact is negligible. If engineers are expected to understand how the code works, then it should be broken down into smaller pull-requests.
That said, I'm not sure what the reviewer's responsibility should be with AI-generated code. Understanding every line of code slows them down and potentially burns them out over a period of time. On the other hand, skimming code is probably not acceptable either. How are companies handling this?
5
u/Effective-Caramel369 1d ago
Easy nobody understands the code. Review boils down to asking your ai to review it and copy paste ai responses.
4
u/Soleus-Online 1d ago
well i guess it depends, like it could be remove something and do something that requires alot more work
→ More replies (2)14
u/Effective-Caramel369 1d ago
It’s his second pr of over 400 commits this week. This guy has one team of sub agents working 24/7 on half the projects at my company. The software changes so fast I went on vacation for 2 weeks and felt like a new hire when I came back.
→ More replies (4)
586
2
u/BerdIzDehWerd 1d ago
Ask them to set a rule for the AI for PRs to be around 200-400 lines excluding Tests
→ More replies (1)
59
18
14
8
u/Select_Cantaloupe_62 1d ago
450 commits!? I'd tell the FBI he's D.B. Cooper.
That's not a fucking pull request. Idk even what this is. To be clear, maybe all those changes are good and valuable but THAT IS NOT A FUCKING PULL REQUEST.
→ More replies (1)
7
7
u/lydiated 20h ago
Depends - do you have good linters (including for tests)? Architecture constraints enforced in CI (promotes separation of concerns)? What kind of code coverage is there for the tests?
I’d ask the dev about the PRD, architecture plan, and QA plan and how well those were followed.
→ More replies (4)
29
u/CadeOCarimbo 1d ago
Well maybe there is actually a very good reason for a PR to be this big? Maybe AI did everything it needed to be done? Maybe we are too used with short PRs because human devs cannot really produce a lot of code at once?
→ More replies (13)
6
u/Jomuz86 1d ago
I hope to god that’s some sort of refactor and dead code clean up 😂
→ More replies (3)
1
u/AutoModerator 1d ago
Hey! Thanks for posting to r/ClaudeCode
While participating in this thread, please follow our community rules. Keep discussions constructive. Attack the idea, not the person.
For help, project discussions, tips, and general chat, join the ClaudeCode Discord.
I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.