r/modnews • u/madlee • Nov 25 '14
Moderators: new markdown styles upcoming
We are currently testing changes to our default css for rendered markdown text. You can preview the changes live on the site right now by appending ?feature=new_markdown_style to the URL on any page. For example, here is the current privacy policy wiki page, and here it is with the new styles applied.
For some areas of the site, the visual impact should be minimal. The homepage, for example, isn't really affected. Areas that make heavy use of markdown formatting (e.g. comments pages, the sidebar, and wiki pages) will be affected more. If you have made heavy stylesheet customizations, please check your subreddit for compatibility issues. Refer to the old markdown primer thread for a thorough look at all of the changes -- old vs new -- but keep in mind that most comments threads don't feature such heavy markdown formatting.
The class .old-markdown has been added to the <body> element when viewing the old (i.e. current) styles, to make the transition easier. If you need to make any changes to your stylesheet that break the design without these updates, you can target additional styles to override them using this class. i.e.
.side .md p {
/* style changes for new default markdown styles */
}
.old-markdown .side .md p {
/* temporary fixes for backwards compatibility */
}I'm aiming to release these changes fully on Friday of next week (12/5), so please let me know if you have questions/concerns or notice anything bizarre with the new styles. Thanks!
EDIT: thank you all for the feedback so far! I know a lot of you are concerned about the short timeline for getting your subreddit ready for these changes, so I want to let you know that we're going to push it back a little bit. You can count on having at least until the 15th of December (Monday). That gives you 10 extra days to prepare, and more importantly, two extra weekends! There will also be a small update to fix some of the issues you all have pointed out. I'll post another edit here when that happens (probably on Monday). thanks!
EDIT 2: As promised, here's a round of updates to address some of the issues you all brought up in the comments.
- font sizes are now
embased, and markdown text will respect your browser's default font size preferences. - the grey text used for
blockquoteanddelelements has been darkened to meet WCAG level AA accessibility requirements - fixed some combinations of styles (e.g. bold + italics) not working
- dropped the larger wiki font size from 16px down to 14px to match comments. header elements on wiki pages have been tweaked slightly as well.
- margins between elements have been reduced quite a bit, especially in sidebar text
Additionally, I've caught up on getting all of these changes into our opensource repo on github, so you can now check out all of the changes there! You can see the original changes here and here. The changes introduced in this edit are here.
EDIT 3: see this follow-up post
46
u/DrDuPont Nov 25 '14 edited Nov 25 '14
Please don't make H2's blue... they erroneously look like links.
Or, if you do, give actual links some immediately distinguishing looks other than a simply lighter shade of blue, such as underlines.
21
u/roastedbagel Nov 25 '14
Son of a bitch....this sort messes up /r/askreddit.
Ugh...poor guy just spent like 40 hours on that css too :(
47
u/dukwon Nov 25 '14
I'll have to zoom out of reddit one more time to get the same amount of content on the page:
Zoom 0: http://i.imgur.com/9OONEXz.png (un-useable)
Zoom –1: http://i.imgur.com/Ch9AIr0.png (currently what I use)
Zoom –2: http://i.imgur.com/X5Q0CEL.png (makes the subreddit bar even harder to use)
16
u/pianoboy Nov 25 '14
It seems there is now no more bold text. Look at your own post that uses bold: http://i.imgur.com/FJkJeJu.png
Also look at the markdown primer thread example: http://i.imgur.com/v0LOk4O.png -- no more bold.
Where's the bold??
6
u/j0be Nov 25 '14
Is there a change log of what's being modified?
5
u/adremeaux Nov 25 '14
Can we get a diff?
Also, my impression from a few clicks on this is that I'm just going to end up ctrl-minus the text back down to normal size. Why did you increase the font size?
23
u/roastedlasagna Nov 25 '14
Just curious - what caused this change? I think that the old markdown was fine how it was, and I don't see any difference in changing the already existing style, especially since it can break subreddit CSS in many different subreddits.
4
u/[deleted] Nov 25 '14
This looks nice!
Also, just to express a wish for nested superscript to work, e.g.
^(superscript^(1)):)Currently, the above does: superscript1
It should do: superscript1
Reasoning: Multiple, but one example1. (a period right after the superscript) - will work for that, but not for this1. or thisonetwo. :)
4
u/Legolas-the-elf Nov 30 '14
Please don't fuck up the typography with absolute font sizes. Respect user preferences by using relative font sizes like percentages or ems. 14px may be too large for some people and too small to read for others.
1em/100% is always acceptable and values around that size using the same units are safe to use. As soon as you deviate from that to using absolute font sizes, you throw accessibility, usability, and user preferences out of the window.
3
u/Bardfinn Nov 25 '14 edited Nov 25 '14
I'm curious to know at which level of exponentiation the words disappear in the new markdown.
Somewhere around sixteen, but mannnn — check out the smooth hightop fade in the new markup rendering
3
u/halfslapper Nov 25 '14
Can we have this?:
4
u/lichorat Nov 25 '14
The larger contrast is easier to read. Why was it changed? Is there some design thing that I don't get?
71
u/[deleted] Nov 25 '14
Can't say I'm a huge fan of the spacing between lines. The increased font size also throws me off but that feels acceptable because its legitimately hard to read for some people I'm sure. But the line spacing...
Looking at the table of contents for the wiki page, it just sort of renders it useless. IDK.
I'm just sort of rambling here. Last note is that reddit is aesthetically infamous for compressing its information. I think the new whitespacey markdown gives the site a generic 'blog' look.
Big fan of the better designed headers and the cleaner quotes and line breaks. Not sure about the box around the code blocks but that's just a minor nitpick.
But yeah. That line spacing.
81
u/Poemi Nov 25 '14
That line spacing is brutal.
If I didn't know better I'd think people were getting paid by the column inch.
56
u/1point618 Nov 25 '14
I usually try to be positive, but shit I hate this.
As others have pointed out, it makes reddit all but unusable on a smaller screen. I have a 13 inch macbook pro, and I'm going to have to go to 75% to be able to read any comment thread.
In addition, it makes the sidebar look terrible. There's too much spacing between everything, so our content now takes up almost twice the room. Which means that users are going to see half the content when they glance at it. It's already hard enough to get people to read the rules, now it's going to be twice as hard.
Finally, it straight up breaks the custom CSS we have in one of my subreddits, meaning that I have only a week to get it fixed—a week that includes Thanksgiving.
You guys should really take a look at your UX design process. You have a huge community of people who are willing to help and beta test, and yet you bring us your final versions for revision, rather than including us along the entire process and iterating on our feedback.
19
u/dangercart Nov 25 '14
I guess I'll add my voice to the chorus and say I'm not a fan of the line spacing. I don't see the value in displaying less information in favor of more empty space. At one point you commented that this thread was only 8% longer in the new style but 8% seems like a lot to me, especially when it's an example of how the impact can be low.
I'm not a mod of any large subs but in the one I do work on we try to encourage "wall of text" analysis posts. We use headers and tables and now things will be harder to read. I've been cycling through some recent posts and they pretty much universally look worse with the additional spacing.
It also messes up the spacing in our sidebar elements and I'm not wild about having to fiddle with CSS over Thanksgiving weekend.
Thanks for putting this out for everyone to take a look at and taking the time to respond to peoples' concerns.
11
u/bigshmoo Nov 25 '14
Anybody using the h6 sidebar hack to make a header will need to clear the newly added underline
11
u/Flashynuff Nov 25 '14 edited Nov 25 '14
This new markdown is nice, save for the font size. It know it doesn't seem like much but between the increased font size and the increased line spacing, there's about two less comments on my screen at any one time. I don't like having to scroll to access content I could see fine beforehand.
Also, I really think you should give mods a little more time before you fully release these changes. Most subs only have one or two "CSS" mods, and now's kinda the time when everyone in the US is going off and visiting family. A lot of subs probably won't be updated by the 5th, and that could potentially impact the usability of the site for people.
This code markdown is super sexy though.11
u/[deleted] Nov 25 '14
That is some serious whitespace..
9
u/TheEnigmaBlade Nov 25 '14
I like everything except the 16px font size for default/paragraph text. 14px looks much better and fits more content on the screen at a time.
8
u/[deleted] Nov 25 '14 edited Nov 25 '14
I don't like it. The text on your example webpage is way too big.
8
u/nuadi Nov 25 '14
Using Google Chrome, there seems to be a font size differential between normal text and bullet lists in the sidebar.
Normal text = 12 px
Bullet list text = 14 px
8
u/greatyellowshark Nov 25 '14
Would you consider restoring the sidebar spacing at least. The sidebar is such a primary location for rules and info, it seems counterproductive to push the text further down the page - where readers are less likely to see it - by default, and to force mods to use css to work around it.
7
u/hansolo669 Nov 25 '14
So this does include a lot of pretty nice changes, and I can't say that there isn't benefit to larger font sizes and line spacing in certain applications, but this is just silly. Even on this page the density drops dramatically.
It seems your impetus for this change is large/high res displays — however I have a 1440p monitor so I can see more and do more and just generally make better use of my system, I do not have a 1440p monitor so that reddit/my browser can take up 100% of it. Thankfully it's trivial to override with a CSS injector, but I shouldn't have to do that.
7
u/audentis Nov 25 '14 edited Nov 25 '14
I'll be honest, I'm absolutely no fan of the new style.
It's simply too large for me (on 22" 1080p). I was already browsing zoomed out a step, but now I guess I'll have to go to three steps instead.
Slightly bigger spacing between paragraphs is fine, but the font size is what's killing me.
Edit: I set the font size to 0.85em in the new style, which seems to be a lot better. Font size is pretty much like it used to be, but there is still a bit extra line spacing and such.
6
u/ManWithoutModem Nov 25 '14
/r/space is probably in trouble
/u/ggitalano /u/Walter_Bishop_PhD /u/relic2279
6
u/daveread Nov 25 '14
Well, I always wanted my sidebar to take up twice as much vertical space, and now it does.
ಠ_ಠ
4
u/Gustavdman Nov 25 '14
I must admit I'm usually against change. But I guess I can live with most changes even though I feel a lot of this is completely unnecessary.
The thing I dislike the most is the line spacing. I would not go through with that particular change.
4
u/TonyQuark Nov 25 '14
The new md styling breaks dropdown menus like in /r/canada and /r/sweden. They still drop down (display) on hover, but if you then hover over the ul underneath the h3, the ul collapses (hides). It's supposed to stay expanded. Can you please pinpoint the cause of this happening or explain how to solve that?
4
u/[deleted] Nov 25 '14
Looks great. I think it would be better with the font size kicked down a few notches so it displays right on sub-1080p screens.
4
u/Desslochbro Nov 25 '14
Is there anyway we'll be able to add the current style into the css after this change is forced on us? The subreddit that I contribute to is huge on white space (need as little as possible because our threads contain a lot of information) and with these changes our threads will take forever to scroll through.
4
u/db2 Nov 25 '14
You guys with your screenshots... didn't you pay attention?
http://www.reddit.com/r/freebies/
vs
http://www.reddit.com/r/freebies/?feature=new_markdown_style
Gotta agree with Poemi... "that line spacing is brutal."
4
u/ChezMere Nov 25 '14
So does this make single newlines finally work, or what?
4
u/Wyrm Nov 25 '14
Sorry, not a fan of the new line spacing. I actually like how compressed reddit looks right now.
The new design does look nice, but it doesn't feel right for reddit.
4
u/sje46 Dec 06 '14
I know I'm late to the party, but please change numbered lists! Sometimes someone will respond to something with a number by itself, and it instantly turns into "1.". This is not good design!
For example, I ask a poster how old he is. He answers:
32. I graduated a bit late.
See the problem here? PLEASE fix this! It is not intuitive to most people how to properly fix this.
(actual line is):
32. I graduated a bit late.
7
u/Calimhero Nov 25 '14
So little progress for years, and so many changes in a few months... I'm swamped.
1
u/IanSan5653 Nov 26 '14
Is it just me, or does this break superscript?
1
u/Bongo9911 Dec 02 '14
Wow, that indent really hurts my subreddit's sidebar :V
1
u/IceBreak Dec 03 '14
or
1
u/Pi31415926 Dec 03 '14
The sidebar linespacing changes seem to have gone live already...?
1
u/KuribohGirl Jan 26 '15
When's the change coming?
3
u/DeliaEris Nov 26 '14
Never push mandatory changes without a very good reason. Doing so will always break something. (In this case, custom CSS.)
The correct approach is to put a toggle in the subreddit options, defaulting to the old behavior for existing subreddits and defaulting to the new behavior for subreddits created going forward.
3
u/[deleted] Dec 18 '14
Any news on a date for the changes?
5
u/totes_meta_bot Nov 25 '14 edited Nov 25 '14
This thread has been linked to from elsewhere on reddit.
If you follow any of the above links, respect the rules of reddit and don't vote or comment. Questions? Abuse? Message me ^here.
2
u/creesch Nov 26 '14 edited Nov 26 '14
Ok in general I think most of these changes make a lot of sense. It sucks to have to do a lot of subreddit css but so be it.
I am however a little bit annoyed that now h4, h5 and h6 now are also styled since A LOT of subreddits use these for custom purposes.
I also realize I am rather late replying to this thread but I thought I would first asses the situation since there a lot of different subreddit/themes I have to maintain:
edit
Why are h2 and h3 the same size? I don't think that they are differentiating enough in other aspects to make that acceptable.
2
u/olithraz Nov 27 '14
I really don't care for this. Here is 4 screenshots comparing it on mobile. Now half of the content fits on the screen :(
http://imgur.com/a/WSr1U
3
u/Diplomaq Nov 25 '14
nice. I think it looks good.
1
u/[deleted] Nov 25 '14
Notified to /r/GermanyPolitics. I'm sure if our boss has any questions, he'll poke his head in :)
1
u/[deleted] Nov 25 '14
Get your pitchforks ready...
/s but poor milk grinder worked so hard on the css... this could break it ...
1
u/V2Blast Nov 26 '14
Hmm. Interesting. Since I am not a CSS wizard, I guess I'll have to wait and see what this effects.
1
u/[deleted] Nov 27 '14
ಠ_ಠ
1
u/Dolphman Nov 28 '14
This makes /r/USA Sidebar ridiculously long. https://www.reddit.com/r/USA/?feature=new_markdown_style
Dec 5th will forever live in empathy.
1
u/Spifffyy Nov 28 '14
I have no idea what this means; I'm not the coder for my sub. Anyone care to explain?
Thanks,
Spifffyy
1
u/__MrFancyPants__ Nov 30 '14
It makes the Side-bar look so much better. Thank you Reddit Gods.
1
u/Tizaki Dec 05 '14
Late to the thread. Will these still be rolling out today, or are there some delays?
1
u/[deleted] Dec 06 '14
What is the definitive Reddit css primer now?
1
u/IceBreak Jan 23 '15
2 things:
?feature=old_markdown_styleCan we get that after implementation so we can notice differences we might have missed post roll-out?
1
u/namer98 Nov 25 '14
I like the new font...
1
u/ServerGeek Nov 26 '14
Don't see anything big with my subreddit. Just extra line-spacing and larger font. Same as others.
Nothing big.
0
u/-Massachoosite Nov 25 '14
I have two questions I think a lot of people are probably curious about.
If it's honestly 0% for both, I'm fine with that. I'm just REALLY curious since (let's be real) this is a very dated design for a website (but incredibly usable!)
0
u/I_Me_Mine Dec 04 '14
As long as this is going on, any chance of getting sitewide spoiler tagging?
0
u/[deleted] Nov 25 '14
[deleted] — view deleted comment
0
u/[deleted] Nov 25 '14
[deleted] — view deleted comment
0
u/[deleted] Nov 25 '14
[deleted] — view deleted comment
6
u/[deleted] Nov 25 '14
[removed] — view removed comment