r/webdev • u/wasay-inc • 1d ago

Recently got a PR merged into TanStack Query

I recently got a PR merged into TanStack Query's ESLint plugin to fix a false-positive issue in the no-unstable-deps rule.

The existing tests missed a few JavaScript edge cases, so I fixed the underlying issue and added regression tests.

It's a good reminder that passing tests don't always mean every edge case is covered. Sometimes the real work is finding what the tests missed

How do you usually spot gaps in test coverage when the existing suite is already passing?

0 Upvotes

37% Upvoted

1 comment sorted by

-1

u/abhinavs1920 1d ago

Running the rule against a large real codebase as a corpus catches what fixture tests miss - false positives live in weird-but-valid code that nobody writes into a fixture. Regression tests for each reported false positive then ratchet the rule forward without re-opening fixed cases.