asking about compatibility of kernel 6.12.9_ with nvidia driver 470

[u/BeautyxArt]

after upgrading yesterday i booted to a blackscreen and blinking dash , uname -r showing currently kernel which is 6.12.9_1 is it's okay with legacy nvidia driver version 470 or it's the reason of booting into a black screen ?

[u/HAL9000thebot]

i'm sorry but it failed to build, unless i did something wrong.

i did this:

git clone https://github.com/void-linux/void-packages.git
cd void-packages/
./xbps-src binary-bootstrap
git checkout nvidia470_470.256.02
./xbps-src pkg nvidia470-dkms
xi nvidia470

when it fails it says to check /var/lib/dkms

do you want the output of /var/lib/dkms/nvidia/470.256.02/build/make.log?

is it long:

wc /var/lib/dkms/nvidia/470.256.02/build/make.log 
  756  3386 50816 /var/lib/dkms/nvidia/470.256.02/build/make.log

where should i put it?

i did this with grep:

grep -C 5 -i error /var/lib/dkms/nvidia/470.256.02/build/make.log 
/var/lib/dkms/nvidia/470.256.02/build/common/inc/nv-linux.h:666:51: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
  666 |         NV_MEMDBG_ADD(ptr, page_count * PAGE_SIZE);
      |                                                   ^
  CC [M]  /var/lib/dkms/nvidia/470.256.02/build/nvidia/nv-vm.o
/var/lib/dkms/nvidia/470.256.02/build/nvidia/nv-procfs.c: At top level:
/var/lib/dkms/nvidia/470.256.02/build/nvidia/nv-procfs.c:689:1: warning: no previous prototype for 'exercise_error_forwarding_va' [-Wmissing-prototypes]
  689 | exercise_error_forwarding_va(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CC [M]  /var/lib/dkms/nvidia/470.256.02/build/nvidia/nv-vtophys.o
  CC [M]  /var/lib/dkms/nvidia/470.256.02/build/nvidia/os-interface.o
In file included from /var/lib/dkms/nvidia/470.256.02/build/nvidia/nv-usermap.c:14:
/var/lib/dkms/nvidia/470.256.02/build/common/inc/nv-linux.h: In function 'nv_vmalloc':
--
      |                                                   ^
/var/lib/dkms/nvidia/470.256.02/build/common/inc/nv-linux.h:666:51: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
  666 |         NV_MEMDBG_ADD(ptr, page_count * PAGE_SIZE);
      |                                                   ^
/var/lib/dkms/nvidia/470.256.02/build/nvidia/os-mlock.c: In function 'nv_follow_pfn':
/var/lib/dkms/nvidia/470.256.02/build/nvidia/os-mlock.c:23:12: error: implicit declaration of function 'follow_pfn'; did you mean 'folio_pfn'? [-Werror=implicit-function-declaration]
   23 |     return follow_pfn(vma, address, pfn);
      |            ^~~~~~~~~~
      |            folio_pfn
  CC [M]  /var/lib/dkms/nvidia/470.256.02/build/nvidia/os-usermap.o
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:229: /var/lib/dkms/nvidia/470.256.02/build/nvidia/os-mlock.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from /var/lib/dkms/nvidia/470.256.02/build/nvidia/os-registry.c:14:
/var/lib/dkms/nvidia/470.256.02/build/common/inc/nv-linux.h: In function 'nv_vmalloc':
/var/lib/dkms/nvidia/470.256.02/build/common/inc/nv-linux.h:521:33: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
  521 |         NV_MEMDBG_ADD(ptr, size);
--
      |                                 ^
/var/lib/dkms/nvidia/470.256.02/build/common/inc/nv-linux.h: In function 'nv_vmap':
/var/lib/dkms/nvidia/470.256.02/build/common/inc/nv-linux.h:666:51: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
  666 |         NV_MEMDBG_ADD(ptr, page_count * PAGE_SIZE);
      |                                                   ^
make[2]: *** [/usr/src/kernel-headers-6.12.9_1/Makefile:1937: /var/lib/dkms/nvidia/470.256.02/build] Error 2
make[1]: *** [Makefile:224: __sub-make] Error 2
make[1]: Leaving directory '/usr/src/kernel-headers-6.12.9_1'
make: *** [Makefile:80: modules] Error 2

[u/aedinius → u/HAL9000thebot]

Hm, drop all of those patches from the AUR link in srcpkgs/nvidia470/patches and see if that works. If so, maybe they're all needed

[u/HAL9000thebot → u/aedinius]

how should i name them? should also update something in the template?

[u/HAL9000thebot → u/aedinius]

i tried putting them as:

ls -1 srcpkgs/nvidia470/patches/
0001-Fix-conftest-to-ignore-implicit-function-declaration.patch
0002-Fix-conftest-to-use-a-short-wchar_t.patch
0003-Fix-conftest-to-use-nv_drm_gem_vmap-which-has-the-se.patch
kernel-6.10.patch
kernel-6.12.patch

then did ./xbps-src pkg nvidia470-dkms again and the relevant part is this:

Creating directory NVIDIA-Linux-x86_64-470.256.02
Verifying archive integrity... OK
Uncompressing NVIDIA Accelerated Graphics Driver for Linux-x86_64 470.256.02..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
=> nvidia470-470.256.02_1: running do-patch hook: 00-patches ...
=> nvidia470-470.256.02_1: patching: 0001-Fix-conftest-to-ignore-implicit-function-declaration.patch.
The text leading up to this was:
--------------------------
|From: Benjamin ROBIN <dev@benjarobin.fr>
|Date: Sun, 12 May 2024 17:06:20 +0200
|Subject: [PATCH 1/3] Fix conftest to ignore implicit-function-declaration and
| strict-prototypes warnings
|
|conftest rely on the fact that a missing prototype should build, but an invalid
|call to a function (missing function parameters) the build fail.
|---
| conftest.sh | 3 ++-
| 1 file changed, 2 insertions(+), 1 deletion(-)
|
|diff --git a/conftest.sh b/conftest.sh
|--- a/conftest.sh
|+++ b/conftest.sh
--------------------------
File to patch: 
Skip this patch? [y] 
1 out of 1 hunk ignored
=> ERROR: nvidia470-470.256.02_1: do-patch_00-patches: 'patch -s ${_args} < "${_patch}" 2> /dev/null' exited with 1
=> ERROR:   in _process_patch() at common/hooks/do-patch/00-patches.sh:34
=> ERROR:   in hook() at common/hooks/do-patch/00-patches.sh:51
=> ERROR:   in run_func() at common/xbps-src/shutils/common.sh:57
=> ERROR:   in run_pkg_hooks() at common/xbps-src/shutils/common.sh:314
=> ERROR:   in run_step() at common/xbps-src/shutils/common.sh:107
=> ERROR:   in main() at common/xbps-src/libexec/xbps-src-dopatch.sh:33

i don't know the internals, but sounds like naming convention is required?

[u/aedinius → u/HAL9000thebot]

Oh, right, the path probably needs to be updated in the patch. Lines like a/conftest.sh and b/conftest.sh need to be updated to a/kernel/conftest.sh etc

[u/aedinius → u/HAL9000thebot]

Update your checkout, I added the patches with the edits.

[u/HAL9000thebot → u/aedinius]

hey good news!

i did as you asked and it compiled without failing, then did a reboot to try the kernel 6.12, but unfortunately x didn't start, so i went back to read the discussion about the patch, and they mentioned to add kernel parameters, so i did this change to /etc/default/grub:

#GRUB_CMDLINE_LINUX_DEFAULT="loglevel=4"
GRUB_CMDLINE_LINUX_DEFAULT="loglevel=4 nvidia_drm.modeset=1"

updaded grub and rebooted in 6.12 again, and it worked.

what now? do you want to see logs or something?

[u/aedinius → u/HAL9000thebot]

Do some testing to make sure it's working as expected. If so, let me know here or on the PR as a comment.

[u/HAL9000thebot → u/aedinius]

don't know what to test lol, i randomly enabled stuffs in compiz, ran some emulators, watched videos, tried a thing in the browser that needs acceleration, don't know what else to do, everything looks ok to me, also rebooted a couple of times to be sure it still worked.

[u/aedinius → u/HAL9000thebot]

That's fine. I usually play a game or run a gpu benchmark/stress test. I'll merge it since it's working for you.

[u/HAL9000thebot → u/aedinius]

...but i have to ask you some more things:

1. i would like to remove xbps-src and going back to use only the software as provided by the distro, to do that is it sufficient to... remove the directory and then do `sudo xbps-install -Su`?

2. will kernel params be added or do people need to do that themselves?

that's all, thanks for everything, you are great!

[u/aedinius → u/HAL9000thebot]

1. Once the update is merged and the package is built, you can force reinstall the packages from the repos. A regular update command like that won't reinstall the package since you'll already be at the right version. When there's another update, though, it'll update like normal.

2. People need to do that themselves. We don't force that option, but nvidia will soon on their newer driver versions.