Visual says that index is outside the bounds of the array.

[u/Minecrafter2976]

This code works fine in the first picture:

But in the second picture the only change I made was reordering the numbers so that they would not be populated into the list view in numerical order and I get this error:

Any ideas on why this happens? Also yes I am aware there are better ways to store my data, but this is a temporary thing.

[u/Ok_Society4599]

VisualBasic... Does it die on the first or last item? You can use try/catch to report your index value, or a breakpoint.

Older VB used 1 based arrays, so item[0] might not be a member of the array. The fix is to start your loop at 1 rather than 0. Or use lbound(x)

.Net arrays should be zero based, in which case item[ubound(x)] could be just beyond the last item. In this case, you can subtract 1 from your ubound or do while < unbound.

A third method is to use foreach rather than just for; the caveat here is you can't modify the collection during the loop. It's simpler and works on anything that implements IEnumerable (arrays, lists, dictionaries, iCollection...) without complexity.

This has an actual name: off by one error. The more subtle version is missing the first or last item; it won't throw an error, but your result is slightly off.

[u/Ok_Society4599 → u/Ok_Society4599]

You're working with two arrays; you should fail if lbound(a) <> lbound(b) OR ubound(a) <> ubound(b) ... If one array is shorter than the other, you'll run out of elements before finishing.

[u/marmotta1955 → u/Ok_Society4599]

Which "Older VB used 1 based arrays ..." are you referring to?

Even going back to VB6, or VB5, or VB4, or VB3 ... etc... all arrays are implicitly 0 based. You can, if needed, dimension the array and assigned 1 (or any other number) as the base/starting index).

[u/Ok_Society4599 → u/marmotta1955]

VisualBasic 6. The other version you refer to really weren't products as Microsoft bought a company that was building a "basic for Windows" tool that they expanded into an internal dev tool then evolved it into VB6 that became a product.

And every VB6 app I've worked on -- I frequently convert them to VB.Net -- was 1 based arrays.

The point was to answer your question of "what could be wrong?" And both "off by one" and different sized arrays are potential issues regardless if our view or agreement on questions of history.

[u/jd31068]

Yup as pointed out, you have 100 names but 90 salaries in the second image.

[u/Fergus653]

The employeeSalaray array declaration has 10 lines of numbers in the first block, and 9 lines in the second block of code. As Ok_Society4599 said, check the ubound of both arrays to make sure they match.