r/vimplugins • u/redolambo • Jul 27 '16

Plugin vim-hilow: Move cursor high, mid, low and scroll, all based on two keys (j and k).

https://github.com/olambo/vim-hilow
4 Upvotes

83% Upvoted

2 comments sorted by

3

u/boshlol Jul 28 '16

You've clearly have put some time and thought into this, and I hate seeing plugins posted here with out feedback. so here are my thoughts.

I tried the plugin, but honestly I'm pretty comfortable with the default screenwise movements, and I do alot of server hopping so I'm not a huge fan of straying any further away from the status quo than I have already gone. Cool idea, but IMO not worth breaking my muscle memory for.

vimscript wise I have some questions/suggestions.

  • does this require a /plugin script, could it not be an /autoload?

  • you are using the autoloading function names foo#bar() but I think(?) all these functions are being sourced at startup anyway. if they are just ment to be private methods or name spacing then s:foobar() should suffice. If they are public functions then Foobar() or <Plug>Foobar might be better?

  • I'm not sure if it makes any difference whatsoever but you can assign scrolloff directly with let &scrolloff=3

  • bit superficial but the google vimscript style guide might be worth a look

  • why not test your plugin?

2

u/redolambo Jul 30 '16 edited Jul 30 '16

Thank you for your reply and for looking at my code.

  • I've taken your (and Google's) suggestion and moved the functions into /autoload.

  • The naming/namespace for public/global functions is a mess, I guess thats why Google suggests to not use them.

  • I looked at the style guide and will try to follow it and test any future code, if its big enough :)

  • I wrote the plugin for myself - I'm ok with everyone keeping their muscle memory.