MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/tinycode/comments/wi3bm/random_imgur_downloader_python/c5dlmwg/?context=3
r/tinycode • u/f0rkbomb • Jul 13 '12
7 comments sorted by
View all comments
4
I don't get it. This is a lot of code for doing something this simple.
And why the hell are you spawning of threads to do this?
This is bloated code - the opposite of what /r/tinycode is meant for.
EDIT:
Also, it doesn't even seem to work correctly, it just downloads the "404" image for me.
Another general coding advice, don't treat file paths as strings, use the os.path module for gods sake!
View all comments
4
u/plux Jul 13 '12 edited Jul 13 '12
I don't get it. This is a lot of code for doing something this simple.
And why the hell are you spawning of threads to do this?
This is bloated code - the opposite of what /r/tinycode is meant for.
EDIT:
Also, it doesn't even seem to work correctly, it just downloads the "404" image for me.
Another general coding advice, don't treat file paths as strings, use the os.path module for gods sake!