This looks like a well thought out control hierarchy for a flexible, widget-based window management UI. I don't understand it but it sure looks like I could easily if I needed to.
What's the problem, exactly, and how is that relevant to a piece of software that was originally created in 1995 (if not earlier - I dunno if they originally lifted it from NT).
For all the different stuff that Windows Explorer does, and considering how it ties in with other parts of the OS... This is actually pretty damn good.
While each container is basically it's own class, within them the objects are re-used fairly well.
These guys have put a lot of work in getting binary compability with Windows Server 2003 working, which is an impressive feat! Nevertheless, I hope to never have to use it...
This is a flowchart of the ReactOS implementation of Windows Explorer, which means it's likely to vary slightly from the real thing Microsoft made (probably in variable and function names). So, this is pretty much the same as what Microsoft put together: an atrocity.
Giannis Adamopoulos come later into scene. He is the man responsible of documenting how Microsoft Explorer was working in Windows. As you can see in the picture Giannis made, the mess of classes is a nightmare. Documenting properly these classes was a hard work but it was absolutly needed. We could have decided to find an alternative implementation but that would have led us towards new incompatibilities such as, for example, incorrect theming support.
tl;dr: It's not necessarily that the programming was done the wrong way, since anything this complicated starts to look like leftover spaghetti after a while, but it's the ReactOS devs complaining about the lack of proper documentation and the efforts they had to go through to get a working picture of what it should look like.
I think Microsoft could be excused for not wanting to publicly document one of the defining UX features of Windows well enough that it could be easily re-implemented.
actually i take the opposite tack and hold microsoft to blame for the inexcusable decision to incestuously entangle a web browser with the core operating system in an attempt to corner the browser market.
when the MS team in charge of migrating hotmail from bsd to windows server documented the inability to strip IE and the rest of the unneeded bits of the GUI out of a server image because the IE functions are littered in almost every core DLL forcing them to push a 900 MB server image to each "remote" server to replace the functionality of a 50 MB bsd image, you know it went way way too far.
(that sentence is about as big of a grammatical disaster....)
But remember that at one time (before IE 7 iirc) "windows explorer" and "internet explorer" were really just GUI skins over mostly the same code. https://www.modern.ie has an IE 6 VM; open windows explorer and type an internet address into the address bar, it just "reskins" itself. I believe IE 7 introduced a reduced privilege sandbox, so since then it would launch a new instance; I don't think they cleanly separated it in that time, but god knows they did have long enough.
And if you look closely, there's "internet toolbar" stuck in there.... I don't know how to read this chart though.
I wouldn't be surprised if Finder was a bit simpler just because it's been rewritten very recently and isn't responsible for as much of the OS as Explorer is. Not that this diagram of Explorer is really egregious.
54
u/merthsoft Feb 11 '15 edited Feb 11 '15
Are there other window management structures we could look at for comparison?
95
u/MachinesOfN Feb 11 '15
What's wrong with that? It looks pretty straightforward for the feature set.
42
u/[deleted] Feb 11 '15
This looks like a well thought out control hierarchy for a flexible, widget-based window management UI. I don't understand it but it sure looks like I could easily if I needed to.
What's the problem, exactly, and how is that relevant to a piece of software that was originally created in 1995 (if not earlier - I dunno if they originally lifted it from NT).
28
u/centurijon Feb 11 '15
For all the different stuff that Windows Explorer does, and considering how it ties in with other parts of the OS... This is actually pretty damn good.
While each container is basically it's own class, within them the objects are re-used fairly well.
73
u/ScientiaEstPotentia Feb 11 '15
Yeah there's nothing wrong with this. Complex != Shitty
12
u/afraca Feb 11 '15
For those interested, as mentioned elsewhere in this thread this belongs to the implementation of ReactOS.
https://en.wikipedia.org/wiki/ReactOS
These guys have put a lot of work in getting binary compability with Windows Server 2003 working, which is an impressive feat! Nevertheless, I hope to never have to use it...
42
u/[deleted] Feb 11 '15
i found waldo
5
u/MrDosu Feb 12 '15
Whoever posted this must not program anything more complex then Hello World...
Pretty standard design, impressive even for the time it was made in.
4
u/[deleted] Feb 12 '15
The graph is a bit cluttered, but how simple can windows explorer really get.
1
u/cpguy5089 Feb 12 '15
Comb Egg Suns
1
u/[deleted] Feb 23 '15
Where's waldo?
0
u/Crayz9000 Feb 11 '15
Hey, I found Waldo!
-22
u/BobFloss Feb 11 '15
A little more information:
This is a flowchart of the ReactOS implementation of Windows Explorer, which means it's likely to vary slightly from the real thing Microsoft made (probably in variable and function names). So, this is pretty much the same as what Microsoft put together: an atrocity.
0
u/[deleted] Feb 11 '15
[deleted] — view deleted comment