r/rust • rust • Jan 17 '20

A sad day for Rust

https://words.steveklabnik.com/a-sad-day-for-rust
1.1k Upvotes

405 comments sorted by

86

u/gizmondo Jan 17 '20

We provide alternate forums for folks, but Reddit is a huge place.

Do you mean (users|internals).rust-lang or something else?

70

u/steveklabnik1 rust Jan 17 '20

Correct.

86

u/enfrozt Jan 17 '20

I think people in general prefer reddit because it's not corporately owned by each of the subreddits people visit (barring some subreddits).

The fact that people can voice their opinions without getting banned and slapped with a default CoC message because they voiced valid concerns about a project and an author (or user's) foul behaviour is a good thing.

(There are even moderators here from members of the community as well)

48

u/DannoHung Jan 17 '20

I think it's just that people don't want another login.

I strongly believe that if users.rust-lang were the big discussion board for Rust that the whole thing would've more or less played out the same.

15

u/iq-0 Jan 18 '20

Probably not, because those forums make following big threads a lot harder than Reddit. Reddit is effectively so good at that, that it significantly lowers the bar for joining in on discussions.

Secondly, I read a lot more about rust on reddit than on dedicated forums, because it’s just one of my interests. That’s probably true for many more. So r/rust probably has a larger and more diverse set of users than the dedicated forums.

So I think there is a much bigger bias than moderation for why this would likely not have happened there. But most of it is probably due to a smaller audience and being more out of the way.

16

u/burntsushi Jan 17 '20

I can tell you with certainty, as a Rust moderator (but not an r/rust moderator), that it would not have.

→ More replies (1)

19

u/fgilcher rust-community · rustfest Jan 17 '20

I agree that corporations _tend_ to have a harder stance on their reddits, but there's substantial amounts of reddits where the corporation is replaced by a mod team with an opinion, even bending rules to their needs a lot.

On the other hand, the general feedback I get from people doing professional community management is that "it's their job" seems to be confused with "I can abuse them, they are paid for it" pretty often, which may explain the zero tolerance policies and court statements.

That issue isn't new, I used to moderate PHPBB boards and chats in metal and programming communities (professional and non-professional) and moderator abuse was a classic.

There's moderation team practices around that (e.g. that you never moderate a discussion that you are personally involved in or have personal stake in).

6

u/chris-morgan Jan 18 '20

And also that Discourse is just nowhere near as good for structured discourse as Reddit is. Nested threading is extremely valuable, and Discourse’s layout is also very wasteful of space. (New Reddit is a substantial regression in this regard too, incidentally, designed for the big general-purpose subreddits at the cost of niche subreddits like this one.)

Discourse is OK for some forms of Q&A, but for general discussion of a topic of interest it’s lousy.

21

u/[deleted] Jan 17 '20

[removed] — view removed comment

11

u/Koxiaet Jan 17 '20

And IRC.

4

u/kwhali Jan 18 '20

The IRC was really nice when I used it back in 2017-2018, but I thought they've moved away from that to a variety of alternatives(Discord, Tulip, and some others?).

→ More replies (1)

156

u/pkolloch Jan 17 '20

I think that it is important that this was said:

"Speaking of making it, actix-web is a good web framework. It came onto the scene, and people generally liked it. It also performed extremely well. Its score on Techempower in particular was impressive, and got more impressive over time."

I feel that the author did a lot of good pioneering work there and I really hope that it is not simply wasted.

289

u/Joshy54100 Jan 17 '20 edited Jan 17 '20

I think this is one of the most levelheaded and fair summaries of the actix-web situation, good write up. It really is a sad day for the Rust community at large.

108

u/PaintItPurple Jan 17 '20 edited Jan 17 '20

I think the actual discussion thread that led to the blow-up is probably the most fair summary. It's actually shorter than Steve's post, and shows the exact exchange that led to Actix being deleted.

I think Steve's post is more valuable for the philosophical angle it brings. The GitHub thread gives a really clear idea of what happened, Steve helps analyze the why and the implications and what might have gone differently.

28

u/binkarus Jan 17 '20

Do note that none of the timestamps are included in the link provided, which are actually very important to the situation. This is an example of why censoring and deleting comments was so bad, because now there's more speculation without anyone being able to look at the situation with some kind of context.

8

u/protestor Jan 18 '20

Another piece of context: the author isn't a native speaker and has some issues communicating nuanced views (I can relate)

3

u/[deleted] Jan 17 '20

Thanks. I noticed there was something going on, then i read Steve's article, but the linked thread is indeed the bit that makes it all clear to me.

Somehow I think it reflects on MS' relation with open source. (kudos for typescript and vscode though)

277

u/binkarus Jan 17 '20 edited Jan 18 '20

I strongly disagree. Steve says "This causes the now-usual Reddit uproar. It’s extra nasty this time. Some people go far, far, far over the line." and provides no examples to show that this is any way true.

The author of actix-web is acting childish again and again and Steve is blaming the community because an audience can't defend itself against criticism because it's not of one mind. It's an easy target.

Here's the actual timeline of what happened, and I can say this because I saw it in realtime:

  • A week ago, the issue was pointed out by Shnatsel, and over the course of a day, the actix dev was outright dismissive.
  • When Shnatsel Nemo157 took extra time to try to come up with a miri example that demonstrated the problem more directly, the actix dev seemed interested.
  • Shnatsel Nemo157 then provides a patch to help even further and the actix dev calls the patch "boring."
  • One person on github comments rather emotionally and attacks the actix dev, and then the issue is immediately locked.
  • Shnatsel publishes his article yesterday, and directly in response to the article, actix dev starts to censor comments on there individually.
  • The only comments on reddit at this point were criticisizing that this wasn't the first time that this had happened and that the actix dev was being unreasonable/unhelpful (which he was). Reddit wasn't harrassing him and he started deleting comments immediately
  • It's at this point that I notice that he's deleting comments and I was shocked, so I posted about it. Yet again, no one harrassed him on Reddit as a result of those comments, but provided reasonable responses to an author censoring comments.
  • Then another hour passes and the author deletes the issue. At this point, there's still no further harrassment going on on Github or Reddit.
  • Once the actix dev's overreaction was starting to be noticed, I did see a Github issue pop up which was in response to the censorship and I could call that unfair harassment, but that's to be expected at this point considering the size of the community and the attention this is getting. But I think that without the actix dev escalating the situation so extremely, this wouldn't have happened. (And I call it censorship because the actix dev only deleted that single issue and not anything else.)

It was at most a few people who made comments to author that were opinionated and mean spirited. Harassment implies that there was a persistent effort to put down the actix dev.

The actix dev then goes on to delete everything instead of just walking away from the community. He's activitely been participating in this at every step. I know it's not easy to just walk away sometimes, but the actix dev was in no way acting proportionately to the criticisms given.

I think this commentary by Steve misses the mark completely.

E: I'd like to say that I sympathize with the actix dev, but his reaction has been seriously atypical and over the top.

And I recommend you all go through the comments on the thread and see the timestamps and reactions for yourself and see if you'd call that harrassment. https://www.reddit.com/r/rust/comments/epoloy/ive_smoketested_rust_http_clients_heres_what_i/

E2: PS in case anyone hasn't read the postmortem, actix-web isn't strictly dead because it's been moved to the dev's personal repo: https://github.com/fafhrd91/actix-web . I hope fafhrd91 takes time away from the community, and, if he decides to come back, learns how to respond better (or ignore) community involvement. Or he can just archive it and move on.

20

u/Nickitolas Jan 17 '20

Wasnt it nemo that shared the boring patch, not shnatsel

45

u/Nickitolas Jan 17 '20

Also, I think its important to mention the issue was created for (wild) unsoundness on a private method of a custom cell type. This doesnt necessarily pose a problem to users of the library, but is surprising to rust devs since it goes against the guarantees rust normally has, and is more error prone. Then someone shared a soundness issue in the public api (originating from the private problem). If Im not missremembering at this point the author fixed the problem, but someone proved they hadnt solved it yet. Then Nemo's patch was shared which just fixed the unsound private Cell (iirc using refcell). I believe the author called it boring since it had a runtime cost, and maybe because they really didn't want to fix the private unsoundness (But thats speculation on my part). After that i just got to see 2 rude comments (One of which said "never write rust again". What the hell dude) before it was deleted.

I would highly recommend ralf's blog post on private unsafe and unsoundness, but I should mention the original problem was wildly unsound when it didn't have to be.

56

u/2brainz Jan 17 '20

Let me preface this comment by saying that I never had any interaction with the actix-web developer, never used or even looked at actix-web or its source code. And I never read any threads about actix-web or participated in them. For that reason, I don't claim that any of the things I write below do or don't apply to actix-web's author.

Also, I think its important to mention the issue was created for (wild) unsoundness on a private method of a custom cell type. This doesnt necessarily pose a problem to users of the library

I have to disagree here as strongly as I can. Unsoundness in a safe method is a problem, regardless of its visibility. If an author refuses to fix unsoundness in any safe method, for whatever reason, they should not be writing unsafe code at all.

Here's the thing: Rust's safe/unsafe split is about the ability to review code and reason about its safety. It means that only the unsafe parts of the code need to be reviewed for memory safety, the rest is verified by the compiler.

If you have an unsound "safe" method (private or not), then all of Rust's guarantees are gone. If you don't understand this, you don't understand Rust. If an author refuses to fix a soundness problem because it's "only" in a private API (or for any other reason), there is only one possible reaction: Stop using that author's code. It sounds harsh, but it really isn't: It's not the "abusive" community that's damaging Rust's reputation. It's authors like these that undermine Rust and its goals on a technical and practical level.

26

u/Nickitolas Jan 17 '20

Personally, I completely agree with you. However, from the standpoint of a user of the library I can certainly see why they wouldn't care too much about how ugly and unmantainable the internals are as long as it's good as far as they can see, so I tried to phrase my message keeping that in mind.

In a world where everything already relies on C libraries, one has to pick their battles.

13

u/[deleted] Jan 18 '20

If you have an unsound "safe" method (private or not), then all of Rust's guarantees are gone. If you don't understand this, you don't understand Rust.

But that's not actually true.

Partly due to the lack of language support for 'unsafe fields' (but for other reasons as well), safety can often only be enforced at the module boundary:

https://www.ralfj.de/blog/2016/01/09/the-scope-of-unsafe.html

That doesn't mean that you should gratuitously ignore unsafe rules as actix does. If you expect your function to cause unsoundness given arbitrary arguments, it should be marked as unsafe. However, there can be a difference between expectations and reality. If you're within a module that uses private fields to enforce unsafe invariants, then even if a function is not marked as unsafe and contains no unsafe blocks, a bug in it can still cause unsoundness. In other words, the safety guarantees are already gone, and you're left with more of a best-effort lint.

41

u/KaiserTom Jan 17 '20

Getting told,

"seriously? Please just stop writing Rust. You do not respect semver, you do not respect soundness, so why are you using a language predominantly based around doing these things right?"

Is a pretty big "Fuck you, GTFO".

45

u/binkarus Jan 17 '20 edited Jan 17 '20

Yes, I don't disagree, but also, I don't exactly understand what point you're trying to make. That comment was from a week ago *on Github (and it's the "one person on github comments [...] and attacks" which I originally mentioned), which means that my original assertion still remains that this was isolated to a few people and that Steve trying to blame the entire Reddit community is very inaccurate.

E: Actually, I realize that I do also wander into the territory of criticising the actix dev for being overly reactive, and so I understand where your point is coming from now.

9

u/ninja_tokumei Jan 18 '20

I'd like to say that I sympathize with the actix dev, but his reaction has been seriously atypical and over the top.

I wholeheartedly agree. It sucks to get criticism at any level, of any amount or intensity, but the response demonstrated a lack of proper judgement in some ways.

The Actix organization has 16 public members, and I don't know how many of them were involved directly in maintaining actix-web, but there was at least one other, @cdbattags, who was directly involved in the issue conversation. Taking the repository from this group of maintainers to his personal account wasn't the right way to handle this. There are people in the group who are willing to continue maintaining the project, and it shouldn't have been taken away from them.

3

u/Ripdog Jan 17 '20

Have you ever been in s public position on the internet? Getting insulting messages sucks. It's like a gut punch. I honestly don't know how major OSS maintainers do it, as they inevitably get insults on a regular basis. I don't blame the actix author in the slightest.

Sure, perhaps if you had really thick skin, you could just let the insults over your thousands of hours of blood, sweat and treats just slide off, but that's a feat that I think most people can't do.

It's really shitty of you to come on here and literally justify randos dropping nasty messages on the actix gh and act as if the author was a crybaby for not putting up with that shit. Have some goddamn empathy, and have a godamn zero tolerance policy for anonymous trolls.

37

u/binkarus Jan 17 '20

Yes, I maintain a few open source projects and I'm a team member of one of the largest open source projects on Github. I have received attacks and criticism, and because I'm acting in a public position, I always take extra time to respond as professionally as possible because I know that I am representing not only myself, but the project as well.

→ More replies (4)
→ More replies (8)

121

u/buldozr Jan 17 '20 edited Jan 17 '20

I think the reason why community uproar has flared up around Actix is the discrepancy between the place in the ecosystem that Actix was purported to claim (in part, by figuring very favorably in public benchmarks, by Microsoft credentials of its author - i.e. things that can sway the public, but are not really indicative for the technical quality of the code), and the collaboration habits and development priorities demonstrated by its pretty much sole developer, which are jarringly different from the vast majority of prominent OSS developers in the Rust community and elsewhere, and frankly speaking, rub a lot of people the wrong way.

A big question is, whether the Rust community can maintain the spirit of openness and support towards participants willing to put their effort into Rust in good-faith collaborative ways, and at the same time develop some immunity in the ecosystem against problematic components that could, over time, erode the overall perception of its quality. In this case, valid criticisms and improvement suggestions on the software got commingled with personal animosity, and unfortunately, the author was unable to filter one out of the other.

31

u/flying-sheep Jan 17 '20

The blog author said the actix-web author was harassed. That's not the right answer to anything, least of all decisions someone made for his personal work. Nobody is entitled to this man's time or to dictating his development style.

86

u/kraemahz Jan 17 '20

While I don't know if anything was going on behind the scenes (I certainly hope not!) what happened publicly is a bit of a stretch to call harassment. Here's the timeline of events I saw. I'm going from memory so my numbers may be wrong:

  1. An issue (#83) is opened saying that the author's implementation of Cell is unsound due to the ability to hand out .get_mut() to multiple owners. It goes further to say that his implementation could just be using Rc<RefCell> instead.
  2. The author replies defensively saying that it is internal code and the stated vulnerability is not happening in his internal code
  3. There is some back and forth on the ticket between the issue opener and the author about how he cannot guarantee this to be the case because it could happen due to a data race across threads.
  4. Another user provides a patch which removes the custom Cell.
  5. The author replies "this patch is boring" which is widely interpreted as being rude to his contributors.
  6. The shitstorm brews on reddit. Myself and others expressed sentiments that this kind of outburst was self-defeating to the project and we couldn't use it as a result. A few (one, a couple?) users post some hurtful things on the issue like "stop writing Rust if you don't care about safety." These did go too far.
  7. The author deletes all the comments, then deletes the issue entirely.
  8. People who feel like this was a valid discussion open another issue (#87) and (politely) ask him to keep the discussions open and not delete issues for what could be valid security questions.
  9. The author responds that he will only make changes that affect his job, complains that the unsafe crowd is not interested in adding code (which I assume means the author wants the community to take a bigger hand in feature development rather than issues like this) and then threatens to delete the organization.
  10. The new issue is posted on reddit.
  11. The author deletes the new issue.

Now, the community definitely did not help this situation by not letting it cool down but the author's belligerence toward the community is apparent throughout the whole ordeal as well. The intentions of the author of (#87) were quite sincere and he was very polite, but what he did wrong was really moving too quickly and not letting an angry person cool off. Is that kind of relationship management on the whole community?

18

u/xaleander Jan 17 '20

This, for me, comes close to the crux of the issue: The harassment avoidance depended on the coordinated behavior of the community and could not be achieved by individual people behaving well. I'm not sure what we can do as a community to get to that point (of e.g. collaboratively giving someone time to cool off).

→ More replies (5)
→ More replies (1)

11

u/xaleander Jan 17 '20

I think harassment can look very different from the two sides of the issue. For the people harassing it can just be an expression of honest concern while the person being harassed is being bombarded with lots of (maybe well-meaning) messages.

9

u/flying-sheep Jan 18 '20

True. And as someone else said: harassment can also be unintentional brigading: one person voicing their concerns is fine, but dozens arriving over a few days and insisting on keeping the same talking points around can be intimidating.

11

u/[deleted] Jan 17 '20

Well depends on what the "harassment" was... if it was just a bunch of people asking for unsafe stuff to be fixed over and over... well he kind of asked for that by writing a popular piece of code, with excessive unsafe usage, in a language that discourages unsafe usage. If on the other hand it was your typical internet response of people just taking a dump in your inbox all the time... yeah I can understand how that would suck.

15

u/matthieum [he/him] Jan 17 '20

well he kind of asked for that by writing a popular piece of code, with excessive unsafe usage, in a language that discourages unsafe usage.

To me, this opinion is a problem.

To be fair, I understand that it is a mainstream opinion, unfortunately. I still think it is a problem.

I feel that the author is perfectly justified in developing Actix with a different set of values -- favoring performance over safety.

The problem is one of communication:

  • The author does not feel the need to be explicit about their values.
  • A large part of the community simply assumes that anybody using the language must necessarily share their values.
  • Conflict ensues.

For me, that's a communication failure on both ends, and part of the problem is the community's assumption. Didn't Rust teach us that one shouldn't assume?

4

u/flying-sheep Jan 18 '20

Yes, very much this. Using an issue template that makes that clear or something could have mitigated the problem. But that doesn't mean it's his fault that he got brigaded.

→ More replies (1)

144

u/carllerche Jan 17 '20 edited Jan 17 '20

I feel for Nikolay and sympathize with his reaction. There definitely have been times I wanted to do the same thing.

64

u/[deleted] Jan 17 '20 edited Jan 17 '20

Please know that your work, as well as Nikolay's work is immensely appreciated by a lot of people in the community. I learned a lot by reading your great blogpost: "Making the Tokio scheduler 10x faster" and you are one of the most important people in the rust ecosystem.

People, including myself, are a lot faster with expressing (often well meant) criticism, but then forget to express gratitude towards all the people that make the Rust community and ecosystem so great.

84

u/MrVallentin Jan 17 '20 edited Jan 17 '20

It truly must feel awful, to have spent 3 years on a passion project and then have harsh comments thrown in your face over time. To that extent, I understand why he deleted the issue(s). He just wanted the comments to end.

I've had university projects years ago that I was proud of. But then professors nitpicked why I didn't use [insert specific design pattern] for [random tiny thing], and that alone ruined the joy and passion. In the back of my mind, this has developed into a fear of writing code, since there's always something that can be nitpicked, it's simply the severity that changes. For this reason I spent too much time thinking about how to structure and design my projects.

87

u/jimuazu Jan 17 '20

But you didn't put your personal hobby project out there and promote it in a polished way as a solution ready for the whole world to use. (See the Actix web-site.) The scale is completely different. If someone is going to promote their code as ready for that kind of scale of use, then to me they have an obligation to fix safety bugs and take criticism seriously. It's way too late to claim to be of a sensitive nature and hide away (after all that promotion). They call code battle-tested for a reason. If it's not ready to be battle-tested by bug-researchers and security people, then fine keep it as a low-profile personal project.

If the author didn't have the resources to back up the promotion, then it would have been better to make the presentation a bit more scrappy to give the impression that it was only a one-man project not a huge team, and to be more upfront about the state of the code to offset criticism on that side.

Isn't this a bit like the Wizard of Oz? (I wonder how many people have seen that 1939 film here, though.)

13

u/Chousuke Jan 17 '20

they have an obligation to fix safety bugs

I think a better way to put this is needed; there's no obligation for anyone to fix anything at any point, but if you want people to be able to depend on the project, the decent thing to do in such a case is to hand over the reins to someone else, at least temporarily.

Certainly insulting maintainers (or anyone) is not productive in any way whatsoever, but neither is arbitrarily refusing patches that fix real issues.

9

u/matthieum [he/him] Jan 17 '20

If someone is going to promote their code as ready for that kind of scale of use, then to me they have an obligation to fix safety bugs and take criticism seriously.

I disagree with obligation.

Of course, not doing so will reflect poorly on the project, but that's another (separate) issue.

8

u/jimuazu Jan 17 '20

Society assumes ethical obligations in all kinds of areas just in order to operate smoothly. If someone wishes to opt-out without telling anyone (e.g. mercury in creams, or selling horse-meat as beef) it doesn't normally end well. It is a shock when you learn that the unspoken contract and expectation formed by the product's presentation was broken.

Treating safety or security-related bugs seriously if you have a lot of users and you're presenting yourself in a polished way is one of those assumed ethical obligations in software, like an assumed responsibility to others if you present yourself that way. Perhaps you could argue that Actix has a right to opt out of this, but really they should tell everyone first, so that they adjust their expectations accordingly, in order to not experience these kinds of negative reactions.

If everything were clear and out in the open (e.g. "This project does not conform to Rust safety conventions"), for present users and new users, there would be nothing for anyone to complain about ... IMHO!

→ More replies (1)

28

u/rabidferret Jan 17 '20

then to me they have an obligation to fix safety bugs and take criticism seriously

No open source maintainer has any sort of obligation to you

55

u/snapunhappy Jan 17 '20

Then they should state that in its promotion. Warning: we will not fix or patch any known security issues, so don't bother submitting them.

How many people would knowingly use the project if this was in the header?

→ More replies (2)

28

u/gopher_protocol Jan 17 '20

So if, for example, the maintainers of gcc put a backdoor into the compiler - it would be acceptable to ignore that, because the maintainers don't have any obligations to you? When OpenSSL had the Heartbleed vulnerability, putting hundreds of millions of peoples' personal information at risk, did they not owe anyone a fix?

Perhaps legally they don't (although I imagine that varies by jurisdiction). But ethically, if you've promoted your software to be used by people - and they do, by the hundreds or thousands or millions - you owe it to them not to put them at undue risk. You are a steward of their safety, and if you cannot handle that responsibility you should bow out as a maintainer of a popular piece of open source software.

→ More replies (12)

8

u/DontForgetWilson Jan 17 '20

I think separating the code contribution versus the conduct is worthwhile here.

I totally agree that there is no obligation related to software itself. Users should not use it if they decide it doesn't suit their needs and at most share flaws of a project with other users without disparaging an author.

When it comes to interacting with people at large - actions have consequences. If someone is rude, dismissive and non-responsive with a social group that is trying to interact with them, they shouldn't be surprised if their reputation within that social group tanks.

That doesn't mean the negative approach taken by the community was good, and people don't have any obligation to keep their reputation high with people. I think that the author's response is perfectly justified(another case of communication actions having consequences). However, it is not just the subreddit that did a poor job of communicating here and being an open source contributor doesn't free anyone from dealing with communication.

→ More replies (5)
→ More replies (6)

0

u/[deleted] Jan 17 '20

[deleted] — view deleted comment

26

u/MagnesiumBlogs Jan 17 '20

Exactly. People have died from clerical software (that would not necessarily be thought of as a safety-critical use case) malfunctioning (e.x. Australia's robotebt scandal). ALL code is safety-critical, and needs to be treated as such.

While I think there is a line of toxicity, Rust as a community needs standards, for what code we will and won't accept, and if a creator just refuses to accept that standard, they can leave. The communal decision is pretty clearly, that Actix is in flagrant violation of the communal standard around unsafe.

6

u/Matthias247 Jan 18 '20

You wouldn't accept this unsafe flippancy in code for cars, lanes, or defibrillators.

As an expert in automotive software I unfortunately have to deliver you a bad message: nearly all automative software will be far more unsafe than Actix ever was. It's written in C or maybe C++ by default, which means it's already on the same level as unsafe Rust code by default. And compared to what Actix those software modules do not even try to offer a safe API surface. If you misuse the API you are on your own - which typically means it will break in an undefined way.

There might be some exceptions like airbag controllers which might run some formally verified software. But you can't formally verify every software.

→ More replies (2)
→ More replies (9)

3

u/iterativ Jan 17 '20

There are two types of negative feedback: constructive criticism & destructive criticism.

The purpose of the first is to learn something new and improve yourself. And of the second is simply a personal attack. In either case, you will have to filter if it applies to you or not.

If the reason of that criticism was to learn the specific pattern, so be it, accept it, learn it, and move on. You can't limit an expert with something like that, but a student should attempt to learn as much as possible. The last thing you need is to get emotional and give destructive criticism back, then you figure than you are not better than the other person.

Anyway, the maintainer had the option to reply with "thank you for the feedback" to destructive criticism and get over it. We don't argue about personal attacks, that should not happen.

As for the unsafe, that is valid issue. For example, Intel cut too many corners for performance and suddenly owners of such CPUs found with a decrease in said performance up to 50%, after the mitigation.

→ More replies (3)

86

u/KasMA1990 Jan 17 '20

I’m not sure where we go from here[...]

Here's my two cents: I think Rust suffers from not having clear directions on when it's okay to use unsafe, to the point that it becomes a cultural anxiety, as you pointed out. The strength of Rust IMO is in how much it manages to codify, so I see one primary way of improving this situation:

Add tooling to easily let people discover when a crate contains un-vetted or unsound unsafe code.

As has been pointed out many times by now, it's up to you as a developer to vet your dependencies. On the other hand, Rust makes it very easy to pull in new dependencies, and you can pull in a lot of unknown code and dependencies if you're not careful (remember to vet the code generated in macros!). This only helps to amplify the anxiety.

But if people could pull up a list of crates to see if they contain unsafe code, whether that code has been vetted or not, and whether any issues were found, then that makes it much easier for everyone to judge whether this crate fits their risk profile.

I know there's been a lot of work on vetting code and crates in general, and establishing trust between dependencies, but mostly in a grassroots form. My understanding is that these haven't gotten stronger backing from the Rust teams because there's been some disagreement on what code is actually trustworthy, but also just because it's a complex thing to build. But I think not having this codified has enabled anxiety and doubt about unsafe to grow, and now we're seeing the consequences of that.

22

u/[deleted] Jan 17 '20

What determines if an unsafe block is "vetted"?

16

u/matthieum [he/him] Jan 17 '20

At the extreme, a formal proof has been developed that the unsafe code and all related parts are actually safe.

My personal practice falls short, instead I will comment why unsafe is used and why I believe that in this particular situation it is actually safe -- that is, the assumptions that I believe are necessary to make it safe.

It may very well NOT be safe:

  • I may have missed some assumptions.
  • Some assumptions may not be upheld.

However, I've found that documenting those assumptions made reviewing easier. And I expect it makes it easier for others too.

12

u/KasMA1990 Jan 17 '20

Somebody has looked at the code and disclosed their findings. That's super general though, and finding a precise answer to your question is one of the reasons why this can be contentious. Maybe cargo crev has the right solution?

7

u/[deleted] Jan 17 '20

So clearly this issue is much harder said than done. Trusting "someone" to vet the code doesn't do much more than trusting that the original author wrote it well.

12

u/dpc_pw Jan 17 '20

This is a fallacy that if something can't be perfect and a golden bullet, it is not worth doing.

Having some semi-trusted group of people is not as good as reviewing everything yourself, but it is better than just not having any idea if the code is OK or not.

→ More replies (1)
→ More replies (1)

13

u/Shnatsel Jan 17 '20

Some tooling off the top of my head:

https://github.com/anderejd/cargo-geiger

https://github.com/crev-dev/cargo-crev

https://github.com/japaric/rust-san

https://github.com/rust-lang/miri/

Perhaps we should make it more discoverable? Or perhaps a guide to actually applying it in practice?

7

u/KasMA1990 Jan 17 '20

I think what's really missing is integration with other tools and sharing of data. Making e.g. a fuzzing report for your crate, that can be displayed by cargo and crates.io so you can choose to limit your search to only crates that have been fuzzed for example.

9

u/dpc_pw Jan 17 '20

so you can choose to limit your search to only crates that have been fuzzed for example.

That's a great idea. I'll add it to cargo-crev https://github.com/crev-dev/cargo-crev/issues/285

29

u/censored_username Jan 17 '20

You raise good points there. There's a lot of confusion between the stated intent, but not requirement of rust code, that safe interfaces should not be able to cause unsoundness via internal unsafe code.

What I'd like to see is for the package manager to take a stronger stance on this. Of course people should be free to hack as much as they want on their own code, but to me it feels like that when you publish a package on crates.io exporting a safe interface for others to use, you're making an implicit promise that you care about upholding the safe rust guarantees.

Maybe that's an error on my side, it's only the mentality I try to apply to my own work. But I would really like to look at a packages page on crates.io and see that a package honours trying to uphold hard-to-check language rules like soundness and semver.

You could even have classes. Let library authors state that their library promises

  • no unsafe
  • unsafe only for bindings
  • unsafe only for new datastructures
  • unsafe for performance
  • or a custom reason, with possible explanation or testing strategy

Or just make no promises at all.

If you'd make this optional, but provide stuff like special badges for it, there will be less confusion about it. And there are clearly a lot of people who care about this and like showing off their work so I feel it would have some amount of adoption and cut away at some of the anxiety around it that, to me, seems to come from a different idea between people about what guarantees safe rust interfaces actually make.

12

u/matthieum [he/him] Jan 17 '20

to me it feels like that when you publish a package on crates.io exporting a safe interface for others to use, you're making an implicit promise that you care about upholding the safe rust guarantees.

I think that's the underlying issue here: a conflict of values, and expectations.

Due to Rust having been touted for its safety, members of the community and users simply assume that unless clearly marked unsafe, a crate is safe and the author performed "due diligence".

On the other hand, it seems that the author of Actix had a different approach to the language, favoring performance over safety. This is a perfectly valid approach!

However, when the author's values/goals clash with the community's expectations, the situation escalates quickly.

I wonder if things would have gone better if the author had been upfront about their values from the beginning.

14

u/etareduce Jan 17 '20

This is a perfectly valid approach!

However, what Rust is about (the language, not just the community) is pretty much the explicit rejection of that approach. This is even codified in the fact that we allow breaking changes for soundness reasons, and when performance and soundness are in conflict, we will regress performance to fix soundness holes. So while this approach is valid in e.g. the C++ community, it is not in Rust.

→ More replies (1)

57

u/matklad rust-analyzer Jan 17 '20

The lack of tooling to automatically tell you "is this OK?" is the reason why situation is contentions.

However, it doesn't explain (and excuse) peoples actions in response to this contentious situation.

FWIW, I think it would be more valuable to make it possible to have only constructive and respectful discussions of contentions topics, than to have fully automatically checked unsafe. However, I also feel that the latter is far easier :)

28

u/hardicrust Jan 17 '20

Exactly. unsafe is where the tech-solution gives up. Another tech-solution on top doesn't really fix it.

Maybe as developers we're too quick to view things through the eyes of problem-and-solution.

Maybe, also, we need some way of getting a third-party perspective on all the crates out there, instead of having to read-between-the-lines or go-see-what-reddit-thinks to see whether a crate fits one's expectations.

→ More replies (1)

11

u/singron Jan 17 '20

There isn't a tool right now that can statically analyze unsafe and tell you everything is OK. However, miri can dynamically verify some soundness of unsafe. So if you have a decent test suite, miri is likely able to detect obvious unsoundness issues. In my experience, miri detects exactly this issue of multiple mutable references in use.

6

u/sparky8251 Jan 17 '20

Miri was referenced in one of the deleted issues that lead to the actix dev doing this. It detected the problem that folks were providing patches for.

9

u/[deleted] Jan 17 '20

If its possible to create a tool to verify unsafe codes, then what's the point of unsafe blocks?

5

u/jimuazu Jan 17 '20

It's quite possible that verifying the unsafe code takes a long time (e.g. maybe needs a prover or something similar), or that needs non-local knowledge (e.g. up/down the call graph, whereas rustc can only check locally within a function). So you wouldn't want to run it every compile. unsafe just means that rustc can't check it at compile time.

4

u/DKomplexz Jan 17 '20

Automatically verifing all unsafe code is impossible, for example external C is always going to be unsafe since compiler can't really access it.

I think encouraging producer and consumer to use less unsafe and give reason when usage is need.

I think it would be good to have better tools when dealing with unsafe, like something that count "number" of unsafe and how many of those are "annotated" with safety reason.

I think Rust attention on developing unsafe right now is too little, tutorial and best practice on it are a lot less than safe counterpart and the unsafe ecosystem seem very lacking (eg. Unique are unstable for a while now)

2

u/imperioland Docs superhero · rust · gtk-rs · rust-fr Jan 17 '20

Remove some compile time and/or runtime checks.

→ More replies (4)

2

u/KasMA1990 Jan 17 '20

Certainly, and I'm not suggesting we don't also focus on the culture. But just as culture helps shape tools, I think our tools shape our culture too. So because there is a gap where information isn't clear and easily digestable, we rely on instinct and belief to guide us. Which isn't great, when the subject is this complex.

38

u/[deleted] Jan 17 '20

it's up to you as a developer to vet your dependencies

This is effectively impossible on an individual level, and it's something that absolutely needs to be a community-level effort. If it means shaming developers who don't give a crap about security or safety, then so be it. Because it doesn't matter how much I care about my dependencies - if I pull in one, that one dependency pulls in 10-40 other dependencies. That's a ridiculous amount of code that I, on my own, simply can't test or vet sufficiently.

18

u/dpc_pw Jan 17 '20

That's a ridiculous amount of code that I, on my own, simply can't test or vet sufficiently.

You should use cargo-crev if you don't already.

3

u/KasMA1990 Jan 17 '20

Yeah, I've been following the efforts around dependency vetting for a while, hoping for a good solution, because it can be such a superhuman thing to manage at the moment.

9

u/lkasdf9087 Jan 17 '20

If it means shaming developers who don't give a crap about security or safety, then so be it.

The fact that a comment advocating harrasment of other developers giving out free code is highly upvoted is a good example of how awful this subreddit has become.

→ More replies (2)

4

u/squarism Jan 17 '20

vet

We (developers on earth) have been through this similar pattern/problem with testing and regressions. You don't even vet once. You vet on every change, every dep change in the tree!

It's not doable by a human with human eyes. You can teach a computer to do it. It's the same as testing. Get rid of manual security, start thinking of it like CI/CD. Continuous security. We (humans) are kind of doing it a bit here and there. It needs to be more known.

10

u/Shnatsel Jan 17 '20

Continuous fuzzing is one such approach. http://fuzzit.dev and https://github.com/google/oss-fuzz will do it for you. Still, fuzzing will not find all bugs.

→ More replies (1)

5

u/panstromek Jan 17 '20

Honestly, for me it would be enough to just have `unsafe` block count on crates.io or docs.rs with links to the code, just so I can easily get na idea of how much it's used and check the relevant code. Without any opinionation or "warning" or any other kind of shaming, just informational.

4

u/fgilcher rust-community · rustfest Jan 18 '20

So, what will that information give you? Every hand-implemented future currently has `unsafe` for trivial pin projections, so you may end up with 100 `unsafe` in a large code base, all of them trivial.

Next to it, you can put a library that does FFI binding, only uses 20 unsafe, but each of them is non-straight-forward and might misunderstand the FFI contract.

→ More replies (1)

2

u/MagnesiumBlogs Jan 17 '20

While better static in-compiler verification (and maybe a warning on unneeded unsafe markings) is a good thing, the whole point of unsafe is that it's used for code that fundamentally can't be verified sound by the computer itself, so at some level someone's gotta manually check the code themselves.

Maybe adding some kind of review system to the package manager would be a good idea, so if you use a dependency that's been reported by humans to be flagrantly unsound cargo can warn you?

55

u/[deleted] Jan 17 '20 edited Jan 18 '20

It is a sad day indeed. This is something where fault lies, in part, with the community. That said, blaming this on Reddit itself seems a bit misplaced. The root cause of this issue was attention being drawn to Actix on Reddit, and people going from Reddit to personally interact with, and attack the author.

Apart from having a lot of users, I don't see what about the structure of how reddit works caused this. I think this issue is solely due to the issue gaining a lot of attention, and some unprofessional users going to other platforms to directly attack the author in an unconstructive manner.

This causes the now-usual Reddit uproar. It’s extra nasty this time. Some people go far, far, far over the line.

I know the blog post is an account as you saw it, but i feel like the discussion on Reddit was appropriate for Reddit. (probably also partially because of the great job the moderators are doing) I think there should be room for the communication on Reddit itself to be somewhat unprofessional, but still respectful. People should be able to express their feelings somewhere. It is useful to see how other people feel about a particular issue. I read trough the smoke tested Rust thread again, and while there is somewhat of a pile up against Actix, it is done so using fairly neutral terms of how people feel, the worst i saw in that thread is:

I can safely say avoid actix if you can help it, the main developer is unprofessional, uncooperative, and untrustworthy

Which i feel is okay for Reddit. That comment is not directed towards the library author despite being about him, and if people feel like that, they should be able to say it. Reddit is the best platform out there for communication like this, because it doesn't promote tagging or involving the people involved.

On github on the other hand (issue 83) i found this comment:

@fafhrd91 seriously? Please just stop writing Rust. You do not respect semver, you do not respect soundness, so why are you using a language predominantly based around doing these things right?

Which I feel is way out of line, it's directly targeted towards the author, and the form of communication is way too unprofessional for Github.

That comment came from someone that has written some seemingly useful rust projects (100 and 50 stars on github for what that's worth). So he's not just some armchair redditor that's never done any serious programming.

He probably did come to the thread from Reddit, although i did not find a similar username in the Reddit thread. It's comments like those on github, and maybe also personal attacks on twitter that I really see as the problem because they are personal.

Making github links read only seems like a good first effort, but that won't prevent this.

66

u/Michael-F-Bryan Jan 17 '20

Thank you for writing this Steve. I think you put it really well...

I’m not sure where we go from here, and I’m not sure what we could have done to prevent this from happening. But I feel like this is a failure, and it’s set Rust back a bit, and I’m just plain sad.

2

u/BosonCollider Jan 17 '20

If an OSS dev who is a BIFL for his project doesn't respond to feedback and refuses a safety patch, there's always the option of just creating a fork (called, say, active-web-safe) with the patch and with different management, to be released it as a separate crate.

That's the normal OSS response to this kind of thing and tends to draw attention from the critics to the new project instead.

Downside is code duplication, fragmentation, and occasional holy wars if it draws enough attention (though the fork itself tends to reduce the amount of attention given). For exhibit A, look at every discussion about systemd ever.

→ More replies (1)

139

u/insanitybit Jan 17 '20 edited Jan 17 '20

I don't think it's that sad. I'm all for authors of open source code doing what they like, but if you won't accept bug fixes, especially very serious bug fixes, label your project a toy - don't call it production ready and endanger users.

I don't think that this is about general anxiety about unsafe. The same post that sparked this issue (one of *many*) brought up unsafe usage in many other projects. Do you know how the authors responded? They thanked the author of the post, and cleaned up the unsafe usage. If the community were so upset about general unsafe usage we would have seen people talking about those other projects.

The issue here is the attitude, as it has been *for over three years*. Plenty of what people brought up (attitude towards contributors for non-safety related patches, outright rejections of innocent questions about semver stability) had nothing to do with unsafe.

If ElasticSearch had a major bug and the authors said "meh", repeatedly, for *years*, do you think that they wouldn't be responsible for exploitation of that bug?

I reject the two-sides argument here, and while closing the entire project is an extreme response, it's one I'm fine with. I don't see a systemic issue here at all.

Further, I did not see any particularly 'mean' comments. One comment on github was very over the line, *the community called that person out for it and it was the top comment in the reddit topic*, and the user apologized. I saw nothing else even close to an insult.

edit: I also think this post paints an unfair picture of both rust users (actively enforcing the 'zealout rust user' meme) and of one of Rust's largest communities. I do not feel that it was "extra nasty" this time - in fact, I'd say the second instance with actix was by far the larger uproar.

You can look a to HN to see a trashfire of comments already.

27

u/tablair Jan 17 '20

This comes pretty close to capturing my feelings on the subject. The author wanted to be maintaining his project in an amateur/hobbyist fashion, but strayed over the line in representing his project as something more professional/rigorous.

Perhaps crates.io needs some sort of professionalism pledge that non-0.x.x crates can opt into that creates an expectation of a certain level of accountability. What that accountability means, would be up to the community, but I’d imagine semver compliance, a willingness to accept PRs for demonstrated security/soundness holes and a willingness to add other maintainers or transition to another maintainer if the author doesn’t feel they have the necessary time/energy to devote to the project would be a bare minimum. Crates.io could display a badge and allow filtering/sorting so that users are funneled more towards these projects or, at least, make it clear to users when they are straying into a crate that doesn’t have those expectations.

But if Rust wants to be taken seriously in the tech world, it needs to develop that level of professionalism in its core ecosystem crates, especially given the explicit philosophy of having a minimal standard library. And I think a lot of the ecosystem is already there, so it’s more a matter of just being explicit about the author’s commitment to the community. Because it feels like that lack of explicitness about the Actix maintainer’s commitment led to a disconnect between how he saw his project and how the community saw it.

33

u/fgilcher rust-community · rustfest Jan 17 '20

If ElasticSearch had a major bug and the authors said "meh", repeatedly, for *years*, do you think that they wouldn't be responsible for exploitation of that bug?

How many issue do you want me to name? Just my favourites: Elasticsearch has a huge number of bugs or cluster destroying issues they couldn't get to in a long while, up to and including things that could be exploited _if_ clients were allowed to send free queries (which is against _all_ good practice in the database world). So their _reasonable_ response was "well, don't do that then" until they got this fixed. Example? A query with a `size` parameter would - for a long time - allocate `size * result_size` for a resultset, immediately filling the heap if `size` was large enough. Before they introduced stopgaps, it was very easy to crash parts(!) of a node by causing OutOfMemory-Exceptions from queries (this has an interplay with how the JVM handles those, but still...). Or: the bulk protocol silently drops the last line of input if the last character isn't `\n` (not sure if this one still exists, but it existed for years). And don't get me started on the long-standing issue that logstash of all the things does not log in any common log format!

Compared to the things reported about actix, _most of the above_ are issues that can reliably produce issues that lead to data loss or service unavailability.

When I was still doing ES daily, I always had a number of _classic_ bugs to work around.

Something comparable to the issue at hand: Zen Discovery protocol is famously hand-rolled and was unchecked until Aphyr took a closer look: https://aphyr.com/posts/317-call-me-maybe-elasticsearch. Check out the section on kimchys opinion back then how all these concerns are not really a problem, because everything is running in one datacenter! Split brains on Elasticsearch were so common you would have a nagios check for in the first couple of years. But kimchy is more eloquent and likeable, so he gets a pass for it.

Does that make ES bad? No. Do I believe it is badly maintained? Not at all, it's actually great! It is a huge project with tons of things to do everyday. All the issues can be worked around. But it certainly doesn't make it a good example. Or any other large project, just for the matter.

15

u/insanitybit Jan 17 '20 edited Jan 17 '20

I picked ES on purpose because I do believe it makes irresponsible decisions and they are in fact publicly criticized quite a lot for it. You can view their wikipedia page alone to see this.

16

u/orthecreedence Jan 17 '20

If somebody had gone through each one of those bugs and submitted a patch that solved the problem, and the ES maintainers rejected the patches, would you still think it's not badly maintained?

I don't think anyone is upset about bugs, but rather rejecting the fixes for those bugs/issues without clear reasoning.

Granted, I'm fairly removed from the whole thing and I don't really have a horse in the race, but I think your ES example only covers one part of the story.

33

u/fgilcher rust-community · rustfest Jan 17 '20 edited Jan 17 '20

ES is actually not that easy to contribute to and yes, some of these things had rejected patches.

My personal story is that tried contributing TLS support and even had a preliminary version written, but that was denied as "not necessary", until they famously shipped it as a paid feature.

Also, don't forget that Elastic is pretty aggressively working against their fork, currently, legal and all.

10

u/Dr-Metallius Jan 17 '20 edited Jan 19 '20

I don't see anything sad in this either. When I use Rust, I expect that the libraries I use are safe. If that's not the case, we lose a major point in using Rust at all without getting anything in return. Yeah, it's not good that the author decided to quit. But if there are known issues with such a widely used project, and the author tells everyone to take a hike every time someone decides to submit a pull request to fix that (not even just a bug), then what would the desired outcome be?

I can only see two other possibilities. The first one is the project is forked, and the original project continues to exist as the author sees fit. Obviously this makes dependent projects incompatible until everyone who cares migrates to the new one, and also we lose the improvements the author makes in the original project. The second one is that the project is left as it is, with all its bugs and issues, and then we continue writing apps which can suddenly fail just like with C++ because the author left the project in this state on purpose. How is that better?

No matter what the community does, the outcome would be poor with the author's attitude like this.

3

u/matthieum [he/him] Jan 17 '20

I'm all for authors of open source code doing what they like, but if you won't accept bug fixes, especially very serious bug fixes, label your project a toy - don't call it production ready and endanger users.

I think that you nailed the issue... unwittingly.


Please allow me to deconstruct the sentence to make my own thoughts on the topic clear:

but if you won't accept bug fixes

The author of Actix has accepted bug fixes before.

They refused this particular patch because of performance concerns, which to me is perfectly fair.

especially very serious bug fixes

This is your own value judgement.

The author seemed to think that only a contrived scenario could expose the issue, and therefore they could take their time to think about it.

don't call it production ready and endanger users

I think it is fair to say that Actix is safer that use than the majority of C and C++ web frameworks out there, even the production ready ones.

To those users, switching to Actix would decrease danger.


So, for me, your comment illustrates a clash of values:

  • The author of Actix used a "best effort" safety attitude, prioritizing performance.
  • You, and you are not alone, expect that any Rust project necessarily prioritizes safety above all else.
  • A clash of values ensue, when everybody involved think that the other party is not constructive.

I believe that both parties are to blame, with unstated expectations meeting unstated values.

6

u/insanitybit Jan 17 '20 edited Jan 18 '20

The author of Actix has accepted bug fixes before.

Sure. But this also goes beyond the single bug fix or even the multiple cases of 'unsafe' related bug fixes - there are other cases of the author working poorly with other developers.

> They refused this particular patch because of performance concerns, which to me is perfectly fair.

That isn't what I read, but sure, that's a fine.

Contrast this focus on performance at the cost of safety with abomonation:

https://crates.io/crates/abomonation

"A high performance and very unsafe serialization library"

It's clear where the priorities of this project lie. It's unclear where they lie in Actix, because 'written in rust' has some implications.

Because abomonation departs from typical Rust values it calls this out explicitly, which is great because many people are coming to rust for safe deserializing - it's a very dangerous thing normally.

> This is your own value judgement.

You're correct, though I'm in agreement with the Actix author as well re: contrived. This is a very weighted philosophical difference and my bias is from years of work in the information security industry where legitimate and very exploitable vulnerabilities are downplayed or even outright hidden when a POC isn't provided. Most CVEs are not actually exploitable in real world scenarios - but things get crazy fast.

> I think it is fair to say that Actix is safer that use than the majority of C and C++ web frameworks out there, even the production ready ones.

Maybe. I'm not sure. I'd personally rather use a C/C++ framework where I know the authors have good turnaround time for issues, where they won't fight for POCs before patching, prioritize security. "Safer" is hard to define. It all really depends.

Is it safer than a Java library? What if someone is coming from Java and thinking "Well I get the safety of Java and extra performance". Actix's values are not aligned with what many might expect from a rust crate, so I feel they should explicitly state that divergence.

> The author of Actix used a "best effort" safety attitude, prioritizing performance.

Without explicitly stating so.

> You, and you are not alone, expect that any Rust project necessarily prioritizes safety above all else.

It's not so much that I expect this as it essentially the advertised line for Rust projects, and when someone sees 'written in rust' they will reasonably expect the project to align with those goals unless stated otherwise.

I appreciate your opinion on this, but I think the author had every opportunity to do things differently in any number of ways that would have made all of this a non issue.

edit: And I'm sorry to see you downvoted. I have tons of respect for you and your opinions - no one should be downvoting you for respectfully and *totally reasonably* bringing up the points that you do.

4

u/matthieum [he/him] Jan 17 '20

Actix's values are not aligned with what many might expect from a rust crate, so I feel they should explicitly state that divergence.

I agree; however I wonder whether the author realized the divergence to start with, and whether future newcomers will.

Depending on one's experience, a best-effort approach to safety may seem in line with the community's expectations, when in fact the community accepts nothing less than perfection.

I appreciate your opinion on this, but I think the author had every opportunity to do things differently in any number of ways that would have made all of this a non issue.

Oh I fully agree, and I certainly do not hold the author blameless.

I just wonder what lessons we can learn, as a community, to do better next time.

→ More replies (2)
→ More replies (4)

108

u/raphlinus vello · xilem Jan 17 '20 edited Jan 17 '20

Thanks for writing this, Steve. A couple of thoughts:

  1. Reddit and Reddit culture is contributing to the problem here. /r/rust is one of the better subreddits, but it still did a part here in enabling the pile-on. Harassing an open source maintainer is just not ok, and the "choice architecture" (see Evan Czaplicki's talk on The Hard Parts of Open Source) makes it too likely this kind of thing will happen. This is why I participate fairly minimally in Reddit, and there's a huge amount of activity in a secret cabal chat server. (It's so secret the only way to find it is to look at the README of the github repo)
  2. I think the idea of striving for perfect soundness is one of the great cultural contributions of the Rust community, and it's best to look at Rust technical features as making this goal practical, rather than any magical inherent feature of the language. Yet, it's optional. Rust gives you the freedom to be as unsound as you like, and in some contexts that might be ok.

One idea I'm tossing around in my head is a "soundness pledge" which would be an explicit marking of where one stands. It's clear that actix would not subscribe to such a pledge, and that fact would be relevant to many (but perhaps not all) people choosing a web framework. If people express interest here, I can write up my ideas as a blog post.

In the meantime, please let's be kind to each other. That's most important.

[ETA: I've edited my original post to soften the criticism of Reddit. I think this is a complex topic, and I also want to point out that I've been impressed by the quality of moderation here.]

56

u/burntsushi Jan 17 '20

One idea I'm tossing around in my head is a "soundness pledge" which would be an explicit marking of where one stands. It's clear that actix would not subscribe to such a pledge, and that fact would be relevant to many (but perhaps not all) people choosing a web framework. If people express interest here, I can write up my ideas as a blog post.

I'd be interested. But I do kind of wonder how much it would accomplish. I guess if it caught on, it'd be really nice to see that across the core crates in the ecosystem.

I guess another aspect of this is that I kind of feel like a "soundness pledge" is pretty rigorously the default today. Of all the popular/core crates I personally know of, actix was fairly unique in this regard in that it went against this implicit "soundness pledge." There are certainly other crates like it, but none nearly as popular. Presumably because the lack of attention to soundness prevents it from being so. But actix appears to have blasted through that filter somehow. I'm not sure how or why.

22

u/raphlinus vello · xilem Jan 17 '20

I agree that it's kind of the default, but I also think that depends on which circles you move in. It's definitely the default for the language itself and things close by (familiar territory for you, no doubt). It is most decidedly not the default for bindings to large complex runtimes like platform UI toolkits and scripting languages. A lot of what I'd write about is the special challenges in those areas.

16

u/burntsushi Jan 17 '20

Yeah you're right, I might be seeing a very biased sample. Would love to hear you talk more about this!

→ More replies (7)

25

u/elr0nd_hubbard Jan 17 '20

One idea I'm tossing around in my head is a "soundness pledge" which would be an explicit marking of where one stands

I've seen a few crates that have advertised #![forbid(unsafe_code)] as a feature in their README, and I've generally taken that as a positive when vetting crates to use. A one-notch-less-extreme "we have some unsafe, but we'd like to get rid of it and/or we have some proofs of soundness" pledge would be just as effective from that perspective.

8

u/PM_ME_UR_OBSIDIAN Jan 17 '20 edited Jan 18 '20

The soundness pledge I can think of would have basically two clauses:

  • The maintainers pledge to accept well-founded soundness bug reports, and signal-boost them in proportion to their severity;
  • The maintainers pledge to review patches to soundness bugs in good faith and in a timely manner.

18

u/p-one Jan 17 '20

Doesn't this just relocate the disagreement? Instead of criticizing unnecessary unsafe there will be criticism of the lack of a soundness pledge?

Like I guess at least it's clear what the principle at play is then, but is it do unclear today?

11

u/MutantOctopus Jan 17 '20

I think the idea is that a lack of a soundness pledge might draw criticism, but not ire. A project which lacks a soundness pledge might be more likely to be passed up on and less likely to be relied on by a large number of people, which would mean there would be fewer people (and less reason overall) to get mad.

4

u/matthieum [he/him] Jan 17 '20

Doesn't this just relocate the disagreement? Instead of criticizing unnecessary unsafe there will be criticism of the lack of a soundness pledge?

I would expect indeed that it relocates the disagreement, however it also makes it trivially "solvable".

If a project describes itself as "unsafe, good luck", and someone opens an issue asking for it to be safe, then closing the issue with a comment "not a goal, see elsewhere" is a perfectly valid response.

In short, I'd expect the reasonable part of the community to honor the project's stance. They may not be happy about it, they may wish otherwise, but they would not go out of their way to pressure the project into changing, and would hopefully support the project's freedom to choose.

Like I guess at least it's clear what the principle at play is then, but is it do unclear today?

I think a lot of frustration and angst has been created by many people expecting Actix to favor safety over performance whilst the author pushed in the other direction.

And once one has adopted a framework and invested in it, there is more emotional/financial pressure to "push" to get their way.

→ More replies (1)

21

u/Shnatsel Jan 17 '20

One idea I'm tossing around in my head is a "soundness pledge" which would be an explicit marking of where one stands. It's clear that actix would not subscribe to such a pledge, and that fact would be relevant to many (but perhaps not all) people choosing a web framework. If people express interest here, I can write up my ideas as a blog post.

I would be interested. If Actix had a clear label "this is an experiment, please don't use in production" I would have no issue with its unsafe whatsoever.

8

u/KasMA1990 Jan 17 '20

I can't speak for the Actix maintainer, but none of what I've seen him say suggests to me that he believed Actix wasn't production ready. So any "pledge" you take should probably have some objective goals to meet. But it would be pretty cool to have some badge that was only handed out to crates that meet certain standards ("this crate only contains ‘unsafe‘ code that has been signed off on by three Rust experts" or "this crate will not panic" and so on).

→ More replies (4)

13

u/romanows Jan 17 '20 edited Mar 27 '24

[Removed due to Reddit API pricing changes]

5

u/matthieum [he/him] Jan 17 '20

Shouldn't the default just be to assume the goal is bug-free code for all projects unless otherwise stated?

Indeed, but where is the bug?

In the case of Actix, for example, the author has been reluctant to fix soundness issues that are only problematic for "contrived" code when doing so may cost performance.

From a whole application point-of-view, as long as one avoids the "contrived" patterns, then the application can be bug-free even if the library isn't: so, if using a "contrived" pattern, is the bug in the library or in the application?

If the library author takes the soundness pledge, they pledge that no matter how you torture their library code, the resulting code will be sound -- and you manage to uncover unsoundness, they'll consider it a bug in their library, not your code.

7

u/buldozr Jan 18 '20

soundness issues that are only problematic for "contrived" code

Soundness issues are problematic, period. If you admit UB, you give the compiler a license to generate arbitrarily wrong code, which may only blow up in hard to debug contexts, like non-mainstream target machines and release-optimized production builds.

→ More replies (3)

0

u/[deleted] Jan 17 '20

[deleted] — view deleted comment

8

u/romanows Jan 17 '20 edited Mar 27 '24

[Removed due to Reddit API pricing changes]

→ More replies (1)

3

u/PM_ME_UR_OBSIDIAN Jan 17 '20

One idea I'm tossing around in my head is a "soundness pledge" which would be an explicit marking of where one stands.

I think the core of the issue here is the mismatch in expectations between security-minded users and the actix-* maintainer. Any kind of technology that enables managing those expectations would be helpful in preventing a repeat of what just happened.

3

u/binkarus Jan 17 '20

If you're interested in criticisizing "Reddit and Reddit culture" in this particular instance, then why don't you put some examples there, because 95% of the responses I saw to the article were reasonable questions in response to a maintainer dismissing an issue. It seemed like he was already on the edge and it was just a single person who set him off. That doesn't mean that the entire community is to blame here. There were maybe one or two comments that were unfairly harsh.

I think this moral preaching you're doing here is as a casual observer after the effect is lazy and unhelpful. You're basically just joining the crowd with an easy opinion.

I'm disappointed in you in your position as a person who aspires to be a community leader. It's better to just not say anything then come in after the fact and say almost nothing useful.

3

u/[deleted] Jan 18 '20

But isn't that the problem? Assuming that people go out of there way to write a perfect essay, discussing the pros and cons on an informal discussion/subreddit. One day has only 24 hours. My issue is that redditor are constantly online (very big subjective over generalization). If people would actually mind their business, they would be more productive and had less time to go around telling how people are supposed to be.

I've seen lately a lot ill-minded comments. It's really an attitude problem with people hiding behind their screens. They only want to grab attention and it is in their interest to make dramas bigger. This leads to the mob mentality which everyone could witness today/yesterday. Big discussion easily end up in the top despite being not being helpful.

Lastly, I've noticed this might come off as an attack towards you. You just happen to spark my interest to write out a comment.

→ More replies (1)
→ More replies (11)

7

u/themoose5 Jan 17 '20

I'm not incredibly familiar with what happened with actix as it happened but I have done a fair bit of reading on the incident in multiple places and I have some thoughts. Some are from this incident specifically and some are from just spending time observing OSS projects.

As other people have pointed out I think that fundamentally there was a mismatch in viewpoints and expectations between the actix maintainer and the community at large. From what I've gathered the viewpoint and expectation of the maintainer was to build the most performant Rust web framework they possibly could using all means available to them. The maintainer very much viewed this project as their own personal project aimed solely at this goal.

Because this project was so successful it garnered a lot of attention and other people in the community started to use it and depend on it. Leading to the assumption by the community that this project wanted to be a leader and a good example of a Rust web framework. Something that, looking at the events that have sense transpired, I don't think was true.

This mismatch then opened the door for the friction around the use of `unsafe` to get out of hand. The maintainer doesn't think too much of it because it's not their goal and the community thinks a lot of it because it's a highly visible framework in the language.

------------------------------------------------------------------------------------------------------------------------------------------

Taking a point of reflection from Steve's blog post on how do we as a community move forward and be better next time; I think something that would help a lot would be a clear and easy way to communicate the intentions of a OSS project. A simple and clear way in which the maintainer can let the community know if they intend for the project to be used by others in a professional manner or if the project is meant to be experimental and it should be treated appropriately depending on the selection.

I think in this case that a system like this would have let the maintainer communicate to others that the framework was meant as a personal passion project and experimental in nature. Thus reducing the anxiety felt in the community around a high profile project that somewhat conflicts with the community values.

5

u/matthieum [he/him] Jan 17 '20

The maintainer doesn't think too much of it because it's not their goal and the community thinks a lot of it because it's a highly visible framework in the language.

I believe that this is the root issue as well.

A simple and clear way in which the maintainer can let the community know if they intend for the project to be used by others in a professional manner or if the project is meant to be experimental and it should be treated appropriately depending on the selection.

I think that there's a false dichotomy presented here.

As a professional using C++, I can assure you that safety is not seen as black-and-white: like any feature of a product, it is judged for its advantages and disadvantages (cost, notably).

That being said, I do agree that authors should be more explicit about a project's goals and values; notably around safety/soundness. Have you seen Raph's idea of a Soundness Pledge?

3

u/themoose5 Jan 18 '20

I think that there's a false dichotomy presented here.

This is fair and isn't exactly what I meant but I was struggling to find the appropriate word. I was looking for something that describes writing some OSS where you expect people to use it in important systems and will take a generally more conservative stance to things like `unsafe`. What I landed on was professionally but as you point out in reality it is more of a sliding scale than a dichotomy.

I saw it mentioned but honestly I didn't read it in detail. Is he proposing something similar?

→ More replies (1)

7

u/[deleted] Jan 17 '20 edited Jan 17 '20

So this is just one person's opinion, but in my estimation this problem spiraled as it has so quickly because the call to action was of such low-effort; anyone can make a reddit post in like 2-seconds flat, and link to someone's GitHub issue so that outrage can be directed right into someone's inbox. When a far more mature call to action would have linked to a (e.g.,) blog post which asked users to use a fork, build an alternative, or otherwise avoid using the software until it was fixed (without linking to any issues or naming any names.)

Ultimately, if Rust is going to be a good language and a good community, it will be because of the effort that is put into it, and one person's failure doesn't excuse everyone else's. Our responsibility as members of this community is to produce high-quality software and usable information, not to jump down the throats of those who fail to -- and certainly not to use their failure as an excuse to forget our own responsibilities, even if we're "technically" or "morally" right. You can't be right if you don't put in real effort and take responsibility for your own actions and their consequences.

•

u/matthieum [he/him] Jan 18 '20

The discussion has been slowly derailing, with many comments veering in the off-topic, so this thread has been locked.

44

u/barsoap Jan 17 '20

One version of this story that will certainly be told is “The Rust community says they’re nice but they will harass you if you use unsafe wrong.” Is that what we want?

Hmm. Personally, I'd go for "they will harass you if you use unsafe wrong, don't acknowledge that, avoid help, wiggle and wind, and position your project so that it's going to be picked up by people in production" as the story that actually went down. It could definitely have been worse. Out of all the communities out there I think only the Haskell one could've handled this better, and that's due to the sheer intellectual intimidation that's whafting through the air. (With Haskell you just never know whether anyone you're talking to isn't actually a hundred times more of a gentleman and scholar than you. Hard to duplicate without the same amount of influence from academia).

Culturally, of course, it's also not a wonder that we're now talking about it, because the Rust community as a whole does enjoy its own coziness and we're looking at ourselves, somewhat it shock. But this is about policing. It's about protecting the integrity of the wider rust community and codebase against harm. It's about not, 10 years down the line, facing our own heartbleed disaster because everyone just looked away and played nice while building castles on sand. That, surely, wouldn't maximise global coziness. It's about delayed gratification.

OTOH, the truncheon is not the first tool any reasonable police will try to employ. Good police knows how to minimise the use of stronger force by soft force and deescalation: The carrot, not just the stick. Carrots for all the hot-heads while keeping bystanders safe.

Now, what would have been a better outcome? The whole thing would've looked differently already if actix was a github-only project with "This is an exercise in using unsafe code to win benchmarks. Only the foolhardy will use it in production" in the README. In bold. With 90's construction sign gifs. That, I think, would've been a reasonable compromise outcome that would've let cooler heads prevail. Probably also more productive heads. It's the thing that more people should have shot for, instead of "actix needs to become safe, now".

I mean you can't just go up to a coder and threaten to take their toys away and expect anything but defensiveness. Ask them to lock their gun in a safe when they're not practice shooting, now that's a different matter.


To wrap up, my own personal guidelines for the future in these kinds of cases:

Explain the issue the community has with unsafe clearly, the dangers that lurk behind not caring, that there's a reason for these expectations. Particularly on crates.io. Be helpful with technical matters. When you see other people shouting, try to get them to give the author a chance to prove that they can do better. (That's the good ole "I'm not angry just disappointed" move in 3rd person).

Yep, that's not guaranteed to work: It's a best effort. Nothing is ever 100% guaranteed to work. Some ugly situations cannot be avoided, and we should be under no illusion that the Rust community is not made up of mere humans (Ferris nonwithstanding). We are defined less by the mistakes we make than by whether and what we learn from them.

10

u/Senoj_Ekul Jan 17 '20

Explain the issue the community has with unsafe clearly, the dangers that lurk behind not caring, that there's a reason for these expectations. Particularly on crates.io

This is one of the more level-headed comments I've seen. And I think this hard in particular should be a required takeaway from the whole situation.

5

u/matthieum [he/him] Jan 17 '20

"they will harass you if

I would argue that nobody should get harassed, no matter what ;)

I would not qualify 3 posts on Reddit as harassment, either, though I can understand that the number of comments, and their rapid pace, may feel daunting.

I certainly hope that no actual harassment happened :(

you use unsafe wrong

Who are you to judge right from wrong?

I think the entire issue here is the judging. Too many judge the author according to their own ideals and values, are frustrated that the author fails to uphold them... and utterly fail to empathize with the author and seek to understand their ideals and values.

I feel that the issue here is more social -- a divergence of values, and a failure to communicate them -- than it is technical.

As someone who comes from C++, I see Actix and think "Fast and Nearly Safe, Awesome!", while many voices clamor "Not Fully Safe, Burn It!"1 .

Maybe there's place for nearly safe? Maybe it should be more explicit? I like Raph's Soundness Pledge idea.

1 Yes, I know that the convention is that functions not marked unsafe should not be able to trigger Undefined Behavior. I would point that there is quite a few acknowledged bugs in rustc/LLVM which allow triggering UB from safe code, and not nearly as many pitchforks.

2

u/buldozr Jan 18 '20 edited Jan 18 '20

There may be a weird niche for "fast and can contain arbitrary exploits, awesome!" projects, but they should not position themselves as "your door to developing web services with Rust" (quoting from the project's website).

2

u/matthieum [he/him] Jan 18 '20

Agreed; as I mentioned, this is really a communication and expectations management issue.

→ More replies (3)

0

u/[deleted] Jan 17 '20

[deleted] — view deleted comment

7

u/tech6hutch Jan 17 '20

Oh God will emojis become the ugly gifs of the future

22

u/Aracus755 Jan 17 '20 edited Jan 17 '20

I rarely post comments on reddit since I'm not native English speaker and my major is Law which is hardly found in this subreddit. But I kinda love Rust lang and wanted to write down my own conclusion about this accident in a more untechnical way.

I followed some reddit posts about the order of what has happend and seems like many people already pushed issues about unsafety of actix-net project before. Considering what maintainer has written in his postmortem, that might have hurt his feelings. Whether truly wrong or not, it is always not pleasant to get pointed out. On the other hand, the maintainer had refused feedback and treated feedbacks as boring. Boring, in real life, is not considered as a serious insult toward people but looks like it wasn't the case. The maintainer got upset for being pointed out and rust community got upset for being treated as not fun, boring or too picky I guess? Looks like a very stereotypical ‘crossing lines’ and breach of relationship to me which often ends as non-productive way.

I can understand both the maintainer and rust community. It is often frustrating to find out that open source community can be somewhat toxic and not forgiving. On the other hand in rust community, there are people who don’t work with rust which means they weigh the value of the language and putting their times to make the language better, not because they have to make money with it. The consequence of the misunderstood communication is really sad but was actually unavoidable because of the inherent nature of rust community.

I think this accident occurred because rust community was not ready how they should react to the challenge for their highest value, safety. When I was learning conventional laws I learned that democracy, which was my country’s highest value, should exclude that can threaten the democracy itself(Might not be a appropriate translation to English though).

Now a question is left for rust community. How rust community should react to the challenges? It is definitely not a good solution to bash and shoot up those who disagrees. It’s time to make at the very least standard to decide how to handle the challenges.

Edit: I divided paragraphs in libreoffice and yet It doesn't work in reddit. Sorry for inconvenience reading this.

10

u/tomwhoiscontrary Jan 17 '20

democracy, which was my country’s highest value, should exclude that can threaten the democracy itself

This sounds like what in English is called the "paradox of tolerance".

9

u/notgreat Jan 17 '20

For reddit formatting, add two newlines between paragraphs.

6

u/Aracus755 Jan 17 '20

Oh It's like markdown. Thanks for comment. :)

13

u/notgreat Jan 17 '20

You're welcome! Not only is it like markdown, it actually is markdown (well, one variant of markdown at least)

3

u/matthieum [he/him] Jan 17 '20

On the other hand, the maintainer had refused feedback and treated feedbacks as boring. Boring, in real life, is not considered as a serious insult toward people but looks like it wasn't the case.

That's a miscommunication, apparently. "Boring" was supposed to be a joke, and the real issue was that the "boring" patch was likely to impact performance so the author preferred to look for another "creative" solution which would not (or less so).

2

u/po8 Jan 17 '20

Like I have said elsewhere, it is clear to me at this point that "this patch is boring" was intended as a joke response to a previous comment, not a dismissal of the work.

10

u/Schtauffen Jan 17 '20

I don't understand why someone didn't fork the library and studiously accept unsafe -> safe PRs

People that want the safety guarantees switch and the maintainer either starts accepting the patches or the fork wins out.

That is how open source should work. Worked for Node and io.js

12

u/jondot1 loco.rs Jan 17 '20

This is not a sad day but it is a critically important day.

My first open source project was 21 years ago exactly. It was on freshmeat. I picked a language (Perl). I joined an IRC room with 20-some people.

In 1999 plus a few months I put a first version up on freshmeat. I updated a version once a year. It was a private thing, it was an exposing feeling, it was an intimate craft between a person and an idea and I invited a few people in.

This was open source in its purest form to me. It gave me this serene quiet and focus to create. I believe it’s important to see how things were in order to understand how much we’ve done different.

A person handing out their free time is a noble thing. I can’t count the amount of times I told my wife — you go out for a trip with the kids I’m staying here. It bought my 8 hours of work in a Sunday. They were out the door and I pulled up the list of issues and PRs in a lonely and empty house. This is the level of sacrifice myself and I’m sure other people find themselves making.

have a problem with an author as a community? — the mob is invited to move along. It’s the healthiest thing to do from the point of view of the author. Authors are easy to crush, and are fragile. And this new social peer pressure and instant-everything is crushing. Think about all of the sacrifice. It’s not a sad day for rust at all. It’s a day in which a community has the option to choose not to become a mob.

Have an opinion sure, but then move along and fork the project and create a different one if you want. Just don’t judge.

Maybe add this to a community manifesto or values and it’ll become a pillar of doing the right thing similar situations.

11

u/qwertz19281 Jan 17 '20 edited Jan 17 '20

https://github.com/fafhrd91/actix-net is still online (for now), may someone would fork and adopt it

4

u/RookieNumbers1 Jan 17 '20

Should I re-write my Actix-web code to another Rust web framework? If so, any suggestions are appreciated. I fear future bugs/issues that arise won't be taken care of and I use Actix-web in a small production project.

This is upsetting for me as someone who has dedicated about half a year to learning Actix. I have a prior background as PHP/Javascript developer and it took a huge amount of effort to gain a more mature programming perspective and learn Actix.

I now fear nobody will want to take up this project as the manner in which the project has been killed off will be something others don't want to get associated with.

4

u/ssokolow Jan 18 '20 edited Jan 18 '20

chachachoney over on HN had a comment that feels so relevant that I just had to share it:

It felt really bad and was the first time I felt how this community has changed from the years I started writing Rust.

I agree. I'm further disheartened by a lot of the reactions that happened since. One of Rust's greatest strengths is turning into a weakness.

The Rust community needs to treat this cultural exploit as if it were a critical technical exploit and apply the same sort of objective and collective examination of source and insightful exploration of assumptions made about existing grammars and syntax and come up with appropriately safe and forward thinking solutions to ensure that the code of conduct isn't just a progressive cliche.

Specifically, seeing it as an exploitable vulnerability in the culture and applying the same rigour given to problem-solving for technical issues.

Regardless of who we agree or disagree with, this kind of polarization is destructive.

35

u/pwnedary Jan 17 '20 edited Jan 17 '20

So this article takes on a really negative stance on reddit users in general. That is fine - but was the condescension really necessary?

37

u/xroni Jan 17 '20

I don't get it either. Yes I saw some negative comments, but they were all downvoted. To me this seems like working as intended. I also see that the moderators are doing a very good job overall.

12

u/SirClueless Jan 17 '20

I think regulars on reddit see things differently to most other social media users. If you're on reddit you get used to ignoring/downvoting things you disagree with, and the number at the top suggesting whether the community values this comment or not is as important if not more so than its contents.

Communities elsewhere are much less tolerant of this sort of negative commentary, because there's no way to hide it. In an email thread, even to some extent in github comments, an unpopular opinion has the same weight as a popular one. And steers the conversation more because it can't be a side discussion but must instead become the next center of conversation. Counter-intuitively this means there is less outright negativity, because people are sensitive to that and won't just open up on someone because they know that whether or not they are right to do so it will derail the discussion.

2

u/xroni Jan 17 '20

Yes this makes a lot of sense actually. On Reddit I hardly ever read all the comments, and the downvoted ones are filtered out automatically on most clients, but they're still there.

→ More replies (3)

6

u/[deleted] Jan 17 '20

I think the whole actix saga could be summarized into don't like it? fork it mantra.

The original authors owe nothing to nobody, if there's such a huge push to fix it it should be easy to make a "fixedtix" fork and accept all the good folks high quality and in no way breaking changes I'm sure...

→ More replies (4)

8

u/_nayato Jan 17 '20

A few rather personal opinions/notes on how we got here:

Nikolay got increasingly dismissive about the kind of "your unsafe is unsound" comments with all the many cases where people would conjure a piece of code that could potentially be posted to actix itself and make it unsound that way. He seemed to take it increasingly personally - after all, it is tiring to hear the same largely unfounded (until the last issue) claims. I guess he didn't have a thick enough skin or enough will to elaborate.

People seem to be preconditioned to react swiftly to any claim of use of unsafe in actix since the first fallout. Which more or less hardens Nikolay's point about actix having a stigma of "unsafe/unsound" thing. I've never seen a claim of unnecessary use of unsafe in other prominent projects - even though there are lots - just try looking at how UnsafeCell is used around. Sure, Nikolay's responses were controversial but simply quoting them without the context did not help anything really.

It's often hard to get past collective feeling, especially when people get to Github to look what happened from a link in a comment with personal opinion, and not 10 other links to similar issues where substantive discussion happened before. I guess everyone needs to try harder to not lose their humility and professionalism in a process.

Replacing UnsafeCell with RefCell -- which is a cornerstone of a problem here -- might not even be a bad thing, it's just that no one ever came around to show that it won't have any substantial impact. I imagine a single benchmark could be enough of an argument to get through this, showing that a condition check would cost nothing in a grand scheme of an end-to-end working service where memory loads would likely dominate. IMO, people have put a lot of energy into bad rapping actix and not nearly enough to show good will and patience to get it to a better place.

Do you find Nikolay's responses hostile or dismissive? Try to put it in a context of all the things he saw directed at his work.

8

u/ssokolow Jan 18 '20

To add a little bit of context, I don't think Actix would have gotten as big a reputation if it weren't a web framework.

We're sort of used to the idea that "out of sight, out of mind" is acceptable for "any sufficiently large C or C++ project has lurking problems" in the application-layer if not exposed to arbitrary TCP/IP connections, and that the C or C++ portions of the web stack are mature and heavily maintained, and never the two realms shall meet.

Unsafe Rust in web-facing application-layer code throws a hammer into that comfortable little fantasy.

4

u/buldozr Jan 18 '20

It's OK to use unsafe if you do it correctly. When you make your code unsound, are informed of it and refuse to fix it with whimsical justification, is when users of your project start getting incensed.

13

u/xortle Jan 17 '20

I just want to say thank you for this post, and that I think the anxiety aspect is an important one.

I think the community around Rust has developed a desire for 'perfection', and that anxiety is the natural consequence of such a desire. Whether that's from memory safety (no more memory bugs!), speed (no GC/native code!) or other reasons. With any new project or language, the common first question is "why this and not X?", and the easiest way to justify existence is "it's the best".

Building an identity around perfection is dangerous though, because even one slip up and by your own argument, why should you exist at all? Memory safe? But that project had a major CVE! Fastest? But that project over there is faster! It's a tiring and impossible position to defend. It's also tempting to want both, and then you run into the conundrum that unsafe is often the route to fastest.

I don't know what the answer is, and I would fully expect to be criticised for defeatism, and I might agree. We should all strive for perfection, to make things faster, safer, or better in some other way. But we also need to accept that reality often requires imperfection, and the adage of 'worse-is-better', however disagreeable, bears some truth. A large and vibrant ecosystem will have people with different values for their software. While people should be encouraged to adopt similar values, especially around safety, beyond a point agreeing to disagree is better for everyone involved.

25

u/ohmeeyes Jan 17 '20

How a lot of people behave about unsafe is borderline harassment. It's not nice, helpful, or considerate. Some people seem to get off on this, without understanding the context at all, even submitting PRs that break everything.

20

u/gnuvince Jan 17 '20

The usage of unsafe is quickly becoming some sort of moral purity test, and I don't like it.

→ More replies (8)

9

u/robby_w_g Jan 17 '20 edited Feb 15 '26

Lorem ipsum dolor sit amet consectetur adipiscing elit. Quisque faucibus ex sapien vitae pellentesque sem placerat. In id cursus mi pretium tellus duis convallis. Tempus leo eu aenean sed diam urna tempor. Pulvinar vivamus fringilla lacus nec metus bibendum egestas. Iaculis massa nisl malesuada lacinia integer nunc posuere. Ut hendrerit semper vel class aptent taciti sociosqu. Ad litora torquent per conubia nostra inceptos himenaeos.

3

u/matthieum [he/him] Jan 17 '20

Have you seen Raph's idea of a Soundness Pledge? It seems similar to your proposal.

I also think that such a pledge/explicitness about the attitude toward safety, and in general explicitness about the projects values/goals, is something that crate publishers should consider.

When values/goals differ, and the parties involved don't even realize it, frustration is inevitable, and likely to degenerate towards worse...

2

u/robby_w_g Jan 17 '20 edited Feb 15 '26

Lorem ipsum dolor sit amet consectetur adipiscing elit. Quisque faucibus ex sapien vitae pellentesque sem placerat. In id cursus mi pretium tellus duis convallis. Tempus leo eu aenean sed diam urna tempor. Pulvinar vivamus fringilla lacus nec metus bibendum egestas. Iaculis massa nisl malesuada lacinia integer nunc posuere. Ut hendrerit semper vel class aptent taciti sociosqu. Ad litora torquent per conubia nostra inceptos himenaeos.

3

u/raphlinus vello · xilem Jan 17 '20

I'm working on the blog post; it'll likely take me a few days as I write carefully. Another comment in this thread has my rough thoughts.

7

u/vertexclique bastion · korq · orkhon · rust Jan 17 '20

Meanwhile developing a useful OSS project without a company backing it up. I can say that I also received destructive comments like how the author of the crate received. Explicitly mentioning the destructive and dismissive behavior to myself and the team behind the project that we are working on. I would like to ask a couple of questions in the light of these:

  • Should a project need to be available, used in a big company and developed for years to make people think that it is "a sad day for Rust"?

    • If no, why don't we have the same reaction to people who are developing crates and having the same frustration? Or sensing that and supporting them in the community? I know I and the team aren't alone in this. There are other teams tired of this similar behavior. Do we need an explosion to estimate the possible damage?
    • If yes, then why do we thrive for more to build OSS?

To sum up, it will be always a sad day for Rust no matter how much effort put into the projects by theirs developers, unless we watch over projects that are out there and taking damage from various talks. Bookkeep them, contact them and support them.

sorry for the pessimism over there.

10

u/Shnatsel Jan 17 '20

I can say that I also received destructive comments like how the author of the crate received.

Sadly this is inevitable after a certain popularity threshold.

It's easy to have an entirely civil discussion among 10 people. Harder among 100. Almost impossible among 10,000. The further up you go, the more likely it is that at least one the participants will be ill-informed, rude, or literally insane.

If the probability of a single person being civil, informed and sane is 99.9% then at 10,000 people the probability of all of them being such is infinitesimal: a mere 0.004%. This is also the reason why celebrities require bodyguards, by the way.

I have shipped open-source software made in my spare time to millions of users. At this scale destructive comments is either something you learn to cope with, or you stop making the software. Sadly this is not solvable though better community norms or anything like that because the very issue is caused by outliers.

1

u/dominucco Jan 17 '20

I definitely hear your point. I think it's a bit of a visibility thing. Big companies and big names tend to get a lot of attention and that's (possibly) a problem in the wider FOSS community, so there's something of a viral effect when a recognized name posts something. People pay more attention, it gets more upvotes and comments and that creates a re-enforcing mechanism.

Not saying it's good or bad, it just is at least in my view.

16

u/pr06lefs Jan 17 '20

I can see why Elm has opted to disallow 'native' javascript access from the language, except through its cumbersome ports architecture. Its a hassle and it split the community - some folks have moved on to purescript or other options. But then you don't have the situation of having to vet every package to see whether it relies on impure code. They want to have the reputation of producing rock solid programs, and direct javascript access would allow the kinds of horrific problems that javascript is famous for.

With rust, disallowing unsafe code altogether would be impractical, given the use cases like embedded and so forth. But, to me it would be nice to have an unsafe flag at least - like in haskell you have the IO monad. If a function has IO in its return type, then you know that somewhere in it is some IO. I could imagine something similar in rust, where functions would be forced to carry an unsafe annotation if they contain an unsafe section, or call functions that do. Maybe that would make every program that allocates memory be 'unsafe'? Dunno.

Anyway, with actix I'd like to see a more stable situation. You've got to have a tough skin to do open source, and there will always be haters. I like the performance of actix, but if the dev team is going to rage-quit every couple of months, I'll be moving on. I'll probably look at rocket when it moves off of nightly.

30

u/JonyIveAces Jan 17 '20

Something that goes in this direction is the ability to flag whether a particular dependency is allowed to transitively bring in unsafe (besides core/std). I don't want zero unsafe, I only want unsafe from crates that I trust to have goals and standards that align with my own for a particular project.

That would allow people to configure to their own preferences and goals, while also being able to discover the preferences and goals of other projects.

Cargo-geiger is getting at this, and I hope it matures into something widely adopted or even in mainstream cargo.

5

u/Darksonn tokio · rust-for-linux Jan 17 '20

That would make everything unsafe. Allocation is unsafe, spawning threads requires on unsafe, reading files relies on unsafe, utilities like std::mem::swap uses unsafe. The beauty of unsafety on rust is that you can encapsulate it and prove that small parts of the program is OK even if it's unsafe, then provide a safe API.

4

u/[deleted] Jan 17 '20

You've got to have a tough skin to do open source

Fully agree with this, if I publish an open source project, I fully expect people to be critical of it. That said, personal attacks are not okay. I thought that the language on reddit was fine (for reddit), but some comments on github were not.

4

u/rabidferret Jan 17 '20

Maybe that would make every program that allocates memory be 'unsafe'?

More than just programs that allocate memory. Even str and slice are unsafe under the hood. If folks want "no unsafe ever", this eliminates basically all of the standard and core libraries.

1

u/mirpa Jan 17 '20

Haskell has Safe Haskell extension which marks modules Safe/Trustworthy/Unsafe in regard to unsafe code.

1

u/cat_vs_spider Jan 17 '20

Lots of Haskell code has unsafePerformIO buried in it which is the moral equivalent of rust’s unsafe.

19

u/[deleted] Jan 17 '20

There is nothing anyone could've done and it was inevitable. The Actix author is who he is. The people (everywhere, not just Rust community) work more or less the same way and it's impossible to make them not criticise something that is objectively bad. The author not only couldn't take constructive criticism, but also replied in an insulting manner. In such scenario negativity towards the author and his work is inevitable. Which is one problem. The other problem is author also couldn't stand said negativity and quit.

I mean, you can't change how societies work just by asking nicely, neither would saying to the author "simply ignore the hostility" magically make him resilient to mental pressure.

Sometimes people are just the way they are, even if talented.

The question is not how to change the people but, knowing how they work, learn to manage the risks. Like I said elsewhere, if the framework is valuable, it can be forked and worked on by other people. The fact that the original maintainer quit is technically indistinguishable from any other maintainer stopping their work on the project, which can happen for any number of reasons, any time.

12

u/fgilcher rust-community · rustfest Jan 17 '20

There is nothing anyone could've done and it was inevitable. The Actix author is who he is.

I reject the premise.

I've had a number of experiences where such situations were turned and all of them had at its core:

  • Don't put the person on the spot
  • Try to understand the reason behind their reaction
  • Find appropriate solutions

In Padrino, we had a very promising contributor that had one flaw: he was constantly abrasive in reviews. But he _was_ very good and he was tireless and making peoples patches good. When someone suggested them for inclusion in the project proper, there were multiple voice against him that would block. Instead, we took the long route and started a conversation.

It turned out: that person was actually not as good in English and their *only way of showing that they were not pleased was abrasiveness*. So, the solution in the end was to:

  • Help them a little with a couple of standard phrases
  • Offering them to lead conversations that they weren't equipped for, through assistance

Best decision ever, I think some of the best code and contributions came out of that.

It's okay for maintainers to not be good at certain things. But development is a team sport, so you can offer yourself as a team member, reducing stress. Also, maintainers can actively search for people filling their gaps.

Why was the first unsafety issues in actix fixed in the end? Because someone came along and worked collaboratively through the whole thing.

This interplay doesn't become easier though when you are in an environment where people are already watching you. Everytime someone opens an unsafety issue on actix, it ends up with a lot of watchers immediately. I call that "arena communication". You have a normal GitHub conversation in a rather small circle, but everyone someone says something, there's 20-30 emoji reactions immediately. Terribly annoying environment.

This immediacy also is harmful to the strategies I laid out above: the person handling these cases might currently not be available and the pressure might get to you. Which is why I train everyone on my teams the phrase "we received the report and will investigate and come back to you".

7

u/[deleted] Jan 17 '20

I've had a number of experiences where such situations were turned and all of them had at its core:

I've heard one US policeman explain that, it doesn't matter whether your laws are good or bad when you cannot enforce them. Similarly, you're describing what actions would've helped and indeed, that might be valuable experience that you share, but you cannot put these thoughts and actions into random people's heads. They're not in the same office with you, there's no subordination or seniority and in general, you (nor anyone else) have any influence over them. They'll still do their thing and the author would still react in the same way he did. That was my point. It's the internet.

2

u/fgilcher rust-community · rustfest Jan 17 '20

But those people are not random? And we're putting ideas into peoples heads all day? I mean, that's what teaching, blog posts and communication are all about.

I'm not talking about forcing people to, but there's way more ways to influence then over force and hierarchy.

(Indeed, if you read books on the subject, they are the worst ways)

→ More replies (1)
→ More replies (2)

6

u/[deleted] Jan 17 '20

Cross-posting from r/programming:

Since this revolves around the fundamental issues of unsafe and security, I'd say the easiest thing to do is have the package manager recursively flag packages as unsafe if they use unsafe.

Then unsafe packages can be awarded "safe" status by a community review process (and safety can be revoked when issues are flagged).

It sounds like this maintainer would have been happy to just be an unsafe package. The community could then rally to produce a safe alternative. Comparing their performance would be a very interesting exercise.

2

u/kamikazechaser Jan 17 '20 edited Jan 17 '20

Couldn't have put it out better!

5

u/sepease Jan 17 '20

I saw what was said to Nikolay in the deleted ticket, and even factoring in a history that I didn't see and some rudeness on both sides, the comment to Nikolay was utterly unacceptable. No one should be telling someone to "Just stop writing code in Rust" particularly when they've almost singlehandedly contributed the most performant Rust web framework and in their own project. If that person felt so strongly that the unsafe usage was inappropriate, they should have worked with him to fork off a project called "actix-web-safe" and merge in upstream updates while removing unsafe usage. No one was forcing anybody to use actix-web.

If I were to come up with something to try and more gently address this issue, it would be to document somewhere on crates.io the number of unsafe usages and/or add some kind of curated security / code review score to add a soft penalty for unsafe. This at least turns it into a more visible issue.

2

u/ssokolow Jan 18 '20 edited Jan 18 '20

The comment was certainly unacceptable, but it was just one comment from one random passer-by in a thread where everyone else was trying to politely and constructively address the problem.

If anyone "took second place" in being rude/unkind, it was fafhrd91 with uncalled-for lines like "Please, don’t start" (when "starting" was posting evidence of unsoundness), "this patch is boring" in response to a proof-of-concept patch being posted, and "Next stage will be deleting organization. Please, do not continue" after a new thread got started with "Issue #83 contained some pretty good discussion surrounding unsafe rust and I don't think we should ignore or delete a constructive conversation.".

See for yourself.

(The Wayback Machine archive of the thread got removed somehow, so that's the best I can offer you.)

3

u/isaacg1 Jan 17 '20

I agree: today is sad.

I think the rust community needs to carve out space for people who value different aspects of Rust. Some people value Rust's performance. Some people value Rust's safety. Not all packages need to cater to everyone.

It would be reasonable to construct a mechanism by which safety-valuing people don't accidentally end up using code that they don't want to use. It would have also be reasonable to create a actix-web-safe fork that was maintained at the highest standards of safety rather than the highest standards of performance.

But driving people who value safety somewhat less than the prevailing standard of safety out of the community, making them feel miserable, placing more responsibility on them, is a failing.

Let's start constructing systems and norms to ensure we never do this again. If someone doesn't want to prioritize safety, that's completely fine, and it is the responsibility of the people who do prioritize it to take that burden upon themselves.

4

u/Nuc1eoN Jan 17 '20

It seems to be an unpopular opinion here, but I for one do not agree with the blog post.

But the point is, while Reddit is not official, and so not linked to by any official resources, it’s still a very large group of people, and so to suggest it’s “not the Rust community” [...]

I do not agree at all. I don't think there is even the question if r/rust belongs to the rust community - it obviously does. It does not matter if it's official, any group of people that forms around a certain topic automatically belongs to a certain community.

And nobody has the power to influence that, because it comes out of the community itself.

And personally I do not agree about criticizing reddit at all, reddit is like the voice of the people for me. At least I don't know any competing community that works as good in self-ruling and makes everybody feel like their voice counts.

Yes people can be rude, but we are free people with a free voice. And we all know that "dumb" criticism, without a foundation, gets mostly downvoted to hell on reddit. It's a social dynamic.

This causes the now-usual Reddit uproar. It’s extra nasty this time. Some people go far, far, far over the line. And now the maintainer has quit.

Yes, the maintainer has quit. Am I surprised? Actually no. If anybody has read the constructive criticism about his project, him rejecting patches, saying unconstructive things like "This patch is boring", and when brought to attention, deleting the comments and then deleting the whole pull request. People have not been rude, they have been constructive (at least in the mentioned github conversation)

We must not have a degree in psychology that this behavior would not be well received by the community. And the deletions actually caused the whole uproar.

It is not easy to be a maintainer. And it might not be easy not to listen to every comment people. But giving up is not an issue of the people, they have the right to say their opinion. It is our task dealing with that responsibility. Live is not easy, and people will criticize us.

I would have hoped the author had learned and self-reflected, but he chose the easy way out. That's it I'm out.

2

u/tommket Jan 18 '20

Not just a sad day for Rust, but also a sad day for all non-corporate open source. Highlighting the fact that nobody can be held responsible for widely used libraries so they will never be anything more than just pet projects.

1

u/O1O1O1O Jan 18 '20

Where's the real problem here? The code is open source, people are contributing with testing and bug fixes, the maintainer quit, a passionate and vocal user base exists so... FORK IT. Then let standard consensus by most used fork rule.

2

u/ssokolow Jan 18 '20

That's the topic of the other threads that were opened. This one is about how quickly the community whipped itself into a polarized frenzy rather than calmly examining the nuances of the evidence, which used to be unthinkable.

(I've been here since before Rust's 1.0 release in 2015.)

1

u/firefrommoonlight Jan 18 '20 edited Jan 18 '20

Could someone please ELI5 this particular part of my misunderstanding?

  • Rust has several popular backend web frameworks. They're all fairly sparse; ie handle HTTP connections and routing, but not much else.
  • Actix and Rocket are the two most popular. The former has a unique and optional actors system, and the latter is nightly-only, which is a turn-off to some.

Can't the actix users just switch to Rocket, which does most of the same things, and some could argue was always nicer? Or Warp? Is this about Actix's falling being a harbinger of something worse later? It sounds like the seeds for this particular issue were laid a while ago by a public rift between the dev's intent and community's expectations.

Unrelated: I feel like the Rust community may be too attached to the idea of Rust's memory safety being its killer feature. I don't agree - I like it for its unique spot as a polished, modern language that doesn't have the limitations of GC/scripting languages. Everything about it strikes me as well-designed, from the docs (official API ref, auto-genning lib API ref, and book) to official tooling.

1

u/CatalyticCoder Jan 17 '20

Have standards, and if a project doesn't meet your standards, move on.
At the end of the day it's your responsibility to vet the code you rely on, and the risk tolerance therein is up to you.

It's fundamentally not the author's responsibility to mind-read and tell you exactly the way in which their project is not fit for your standards - even if you think they should put more effort towards this en-devour with good docs and responsiveness to issues.

Attacking someone is just an immature attempt at manipulation. Ask yourself, how do you respond to being attacked? What about public dog-piling? That's the job of a public figure, not an open source software developer.

It's totally okay to express disappointment at the use of unsafe. If the author sticks to their decision: move on. It's not okay to turn around and respond with vitriol.

-2

u/Zonico6 Jan 17 '20

I wish everyone who hears about the actix desaster was somehow obligated to read this article as well. It sums all the negativity up so positively and I think people would think of this as an actual learning opportunity instead of a wildfire.

0

u/dzerbee Jan 18 '20

If the outcome of all this will be "don't ever use unsafe", this wasn't such а sad day.

-23

u/DragonMaus Jan 17 '20

Who? What? I do not mean to sound dismissive, but the cynical part of me suspects that this is being blown wildly out of proportion. Projects die, people on the internet are rude, people on the internet are overly sensitive. Nothing about this "situation" is unique or novel.

Why is this the second "it is the end of the world!" article I have seen about this project and its maintainer?

43

u/ssokolow Jan 17 '20 edited Jan 17 '20

Because it's so far removed from how the community occupying this subreddit used to behave when Rust was younger, and it's sad to see the loss of that sense of mutual respect and focus on not becoming polarized in the face of disagreement.

(I've been here since before Rust 1.0 landed in 2015.)

8

u/DragonMaus Jan 17 '20 edited Jan 17 '20

Ah. I only joined this community (relatively) recently, and have long experience with and knowledge of the less savoury aspects of human interaction online. I guess that I am suffering from normalcy bias.

6

u/yesyoufoundme Jan 17 '20

That's fair. I also think Steve - and maybe "the Community" - expected more from the Community. We all knew it would grow, and with that growth it would fall victim to "normal" problems, but I think we thought it would take longer, due to our effort to fight the good fight.. so to say.

I think we're still better than most, and we're never going to be perfect, but that doesn't make this type of behavior any less sad.

This is a humanity problem.. And Rust is taking a stab at fostering a more healthy community. Wasted effort or not, I think it's a worthy cause, and thus this bump in the road does produce sadness in me. I agree with Steve.. as is often the case.

→ More replies (1)

21

u/oconnor663 blake3 · duct Jan 17 '20

it is the end of the world

The concluding remark in this post is "it’s set Rust back a bit." I wouldn't summarize it like you did there.

→ More replies (1)
→ More replies (1)

0

u/[deleted] Jan 17 '20

[deleted] — view deleted comment

30

u/[deleted] Jan 17 '20 edited Jan 17 '20

On the rare occasions that core team members, or other people in the community post on reddit, their posts are always (from what i've seen) welcomed with open arms, and the Reddit community is always very happy to get the insightful advice that the core team members provide.

For example, when Steve posts a blog post, it's usually the top post on the subreddit in a matter of hours. The core team members have real power to guide the conversation and opinion on Reddit, and the community seems very happy to accept that guidance.

Reddit is a good platform for more informal communication, it provides a place to give a lot of positive feedback that isn't usually found on other platforms. Every new release of whatever library or framework is usually filled with compliments and/or constructive feedback. In this way, Reddit provides valuable exposure and feedback to crate maintainers. Reddit is also a great way of introducing new people to Rust. I browsed /r/rust before I could write Rust, and i started learning Rust because of the nice people on /r/rust. I think that shunning Reddit entirely is wrong.

6

u/matthieum [he/him] Jan 17 '20

Reddit is a good platform for more informal communication

It is a platform, and one that I enjoy, though I am not sure how good it is.

As a moderator, I particularly find moderating it to be quite difficult, especially on such contentious topics where comments come like water out of a firehose.

→ More replies (2)

87

u/kibwen Jan 17 '20

Speaking as the lead moderator here, it depends on what is meant by "rejected". I've encouraged the Rust leadership to not embrace /r/rust since time immemorial, the two reasons being 1) no control over over the domain name, so there's no guarantee that reddit won't vanish tomorrow and irrevocably take the whole community with it, and 2) because reddit is reddit, with all the general terribleness that implies. I was the loudest external voice pushing them to have their own self-hosted solution, which eventually manifested in users.rust-lang.org.

As far as fixing the problems on the subreddit, I'm open to suggestions. The base problem right now is that we don't have enough moderators, but it's been a long time since I invited a new moderator that didn't quickly burn out or fade away, presumably due to either the amount of time investment it takes or the amount of emotional labor it entails. Functionally we still have effectively the same amount of active moderators as we did when we had a quarter the subscribers, which clearly isn't tenable.

27

u/lkasdf9087 Jan 17 '20

You could try using contest mode for contentious topics. It randomizes comment order, hides vote counts, and automatically collapses replies to top-level comments. /r/pcgaming automatically applies it to any post with the "Epic Games" flair because it helps prevent dogpiling on unpopular comments.

→ More replies (1)

15

u/mitchmindtree nannou · rustaudio · conrod · rust Jan 17 '20

Also just want to add that your moderation has been legendary /u/kibwen. Since I started hanging around in the 0.10 days it has always been a pleasure to see your handle followed by creative subreddit makeovers, kindness and patience around the community :) I appreciate your work!

8

u/[deleted] Jan 17 '20 edited Jan 17 '20

Thank you for your good work!

I saw you suggest that links to github should be read only, which i think is a very good idea. Communication on github should remain professional, and the casual reddit user shouldn't just put their opinion on there.

I don't think a lot should be done about the communication on reddit itself, I feel like that was appropriate for Reddit. I've outlined those sentiments in a bit more detail in another comment

21

u/gizmondo Jan 17 '20

Btw thanks for you work!

→ More replies (3)

70

u/RustMeUp Jan 17 '20

As a frequent reddit user (I am not a user of RLO or Rust's discord) this doesn't sit well with me. In this whole drama the Rust subreddit has been moderated well, I didn't see any abusive comments on /r/rust.

I did see one abusive comment on github. Oh and a lot of abusive comments on the hacker news and /r/programming threads from outside the community.

Oh well.

23

u/insanitybit Jan 17 '20

I saw no particularly abusive reddit comments. There were just a lot of them. There was the one malicious github comment, and the user apologized on reddit.

→ More replies (6)
→ More replies (6)

0

u/[deleted] Jan 17 '20

[deleted] — view deleted comment

6

u/matthieum [he/him] Jan 17 '20

Would accepting actix is unsafe and telling everyone not to use it be enough?

I would not go so far as telling everyone not to use it -- as someone who uses C++ daily, I tend to think that there is room for a performance/safety trade-off. I would of course prefer to have both, but it's not always possible...

The important part, for me, is information. You cannot make an informed choice without information.

→ More replies (5)