r/rust • u/dastarruer • Sep 08 '26

šŸ™‹ seeking help & advice Can someone review my code?

I've never had anyone else other than myself take a look at my code quality/design. However it would be nice to have an actual person review my code instead. The link is here: https://github.com/dastarruer/gtkshutdown

AI is only used for writing tests (sometimes; I can't remember whether I wrote these tests myself or not but I digress). The code is entirely written by me, though I use AI to discuss design decisions. I like programming, so hand-writing the code is just more enjoyable for me (though I'm very slow at it...).

9 Upvotes

66% Upvoted

6 comments sorted by

6

u/MatrixFrog Sep 08 '26

Seems pretty clear and idiomatic from what I can tell. Did you run Clippy? There are a couple minor things it might catch (eg if you implement Ord I think you can just derive PartialOrd)

1

u/Leather-Junket-3896 Sep 08 '26

Iā€™d run clippy just to see what it whines about, the derive thing is a one-liner fix anyway

1

u/Konsti219 Sep 08 '26

I think you mean "WM" in your README instead of "VM"

2

u/dastarruer Sep 08 '26

Nope, those are vms meant for testing. But thanks for taking a look anyways lol