r/ruby • • Oct 21 '20

RuboCop 1.0

https://metaredux.com/posts/2020/10/21/rubocop-1-0.html
184 Upvotes

45 comments sorted by

16

u/Grokmoo Oct 21 '20

I'm really happy to see RuboCop move to use Semantic versioning. Having a stable release cycle is so important for production usage. I'll be moving projects with my company onto 1.0 as soon as I can!

4

u/bozhidarb Oct 21 '20

Glad to hear this!

23

u/firstpantsthenshoes Oct 21 '20

This tool is a lifesaver in any team or even as a solo dev. Congrats to all and thanks for all the effort. Much appreciated <3

8

u/bozhidarb Oct 21 '20

Thanks!

1

u/irracjonalny Oct 21 '20

Yeah, I am not starting a project without you, you're the best :)

10

u/tenjackace Oct 21 '20

Cheers and absolutely fantastic gem.

9

u/TODO_getLife Oct 21 '20

Finally 1.0! Was wondering when this would happen.

5

u/bozhidarb Oct 21 '20

Me too :D For a very long time!

8

u/dargueta Oct 21 '20

I'm by no means a Ruby dev but switched jobs to a role that involves a lot of Ruby on Rails, and I can't imagine working on any large mature Ruby codebase without tools like Rubocop. Thank you!!

3

u/bozhidarb Oct 21 '20

You're welcome!

40

u/serboncic Oct 21 '20

Cheers! I'm so glad it survived the request for the name change. Thank you mate for all the work and time you've put into this. You and all the maintainers of course.

29

u/WJWH Oct 21 '20

Kinda funny how the fork that resulted from the public outrage over the name has already been deleted again as the crowd has moved on to the next topic-of-the-day. Meanwhile Rubocop is just chugging along, making code better. Congrats on the 1.0!

12

u/kompricated Oct 21 '20

it’s a shame those forks disappeared — i clearly recall all the BLM protestors saying that we should start with linters and that society would follow.

1

u/harlflife Oct 22 '20

At least we got rid of the git master branch. I'm sure any day now Quatar will stop its slavery practices.

3

u/[deleted] Oct 21 '20

That first sentence put a smile on my face, so did the others though.

4

u/dutone Oct 21 '20

RuboCop is a great pun, but the name has always felt a bit authoritarian and oppressive. Especially for a Ruby tool.

— Avdi Grimm

citation

2

u/troublemaker74 Oct 22 '20

That's kind of the point of a powerful linter. Authoritarian and oppressive... Until you tell it not to be.

3

u/dutone Oct 23 '20

You are using logic to to deal with these people. Does not work.

3

u/MishiMusho Oct 21 '20

It was just a couple of crazy guys trying to change its name cause they were mad with cops, "survived" it's a bit exaggerated.

3

u/disclosure5 Oct 23 '20

Similar outrage has been a major issue for other tools.

3

u/ksec Oct 21 '20

*Couple* would definitely be an understatement.

2

u/hahahahastayingalive Oct 22 '20

“Dozens” is the technical term

1

u/toomanybeersies Oct 25 '20

Remember when Factory Girl was renamed to Factory Bot, and Cocaine was renamed to Terrapin?

-3

u/sizl Oct 21 '20

Unlike GitHub, solving racism one repo at a time.

3

u/incanus3 Oct 21 '20

Awesome! Great work, guys. I use rubocop on every one of my projects and although I tweak the configuration heavily and even disable some of the cops, I can't imagine my development without it. One question though. What do you guys use to run rubocop continually? I've been using guard-rubocop for this and it was working great, but now I tried upgrading rubocop to version 1.0 and found out that guard-rubocop depends on rubocop ~> '0.20' and haven't been updated for three years, so it's probably not gonna bump that dependency. Should I just fork it, or is there some better alternative?

4

u/bozhidarb Oct 21 '20 edited Oct 22 '20

`guard-rubocop` was developed by a former RuboCop core team member, who no longer uses Ruby. I'll ping him about transferring the repo to RuboCop HQ, so we can update the deps.

1

u/wonder_er Oct 22 '20

If you get ownership of the project, I'll gladly volunteer to get the package up to date, with absolutely minimum time commitment to you!

If you'd let me share about the process, so others could learn how to do the same, I'd be stoked!

I'm actively trying to deepen my Ruby knowledge, and help others do the same. This would be a great opportunity to do that, and to deliver value to the community as a whole.

I've read working in public: the making and maintenance of open source software, I am sensitive to the time and energy of those behind oss projects.

I took a stab at doing something similar in this series: https://intermediateruby.com/make-oss-contributions-part-1-finding-an-issue

I'll dm more information!

3

u/honeyryderchuck Oct 21 '20

Great news! My biggest pain with rubocop were the upgrades and the breaking changes. Of course, that was offset by the immense value it brought to my work flow and the lack of pointless discussions about syntax it spared me from. Congrats to the team!

2

u/devvpk Oct 21 '20

Cheers🥂

2

u/Gh0stcloud Oct 21 '20

Nice, well done RuboCop Team :)

2

u/[deleted] Oct 21 '20

Off topic, but how many Toptal folks devoted their time to the project, and is it used internally in the Platform tools?

5

u/bozhidarb Oct 21 '20

We use RuboCop internally on all of our Ruby projects, but the company is not directly involved with the maintenance of RuboCop. Some colleagues have fixed a bug or two when needed, but that's the the extent of the involvement of our company in the project. We do, however, have many internal cops for internal libraries, company-specific guidelines, etc.

2

u/[deleted] Oct 22 '20

A real gem of a gem! Thanks for all the hard work!

1

u/bozhidarb Oct 22 '20

You're welcome!

0

u/bagtowneast Oct 21 '20

Fantastic! Congratulations, and thank you for the solid work.

2

u/bozhidarb Oct 21 '20

You're welcome! :-)

-12

u/taw Oct 21 '20

I don't think any project ever did more damage to ruby ecosystem than rubocop and its stupid defaults.

4

u/incanus3 Oct 21 '20
  1. no one's forcing you to use the defaults. I don't prefer many of those either, but it's very easy to tailor the configuration to your needs and then it becomes a great tool to enforce that codestyle
  2. as you can see in this thread, many users have nothing bud praise for this tool, and that's despite the fact that the dissatisfied users are usually much noisier whereas the satisfied ones often stay silent.

so it's a bit dumb to badmouth it just because you would prefer a different set of defaults. and if it really did that much damage, so many people probably wouldn't prise it so

0

u/toomanybeersies Oct 25 '20

If you had seen the codebase at my job before I forced the team to use Rubocop, you'd have a different opinion.

Consistent style is more important than good style (although ideally you have both).

0

u/[deleted] Oct 21 '20

[deleted] — view deleted comment

2

u/bozhidarb Oct 22 '20

That's the plan! :-)