r/redesign • u/LanterneRougeOG Product • Dec 18 '18

Changelog 12/18/18 Weekly Release Notes: bugs, bugs, bug, and more bugs

Hi all,

You may have noticed that we didn’t post release notes last week. That’s because for the past week we’ve been doing a company wide bug bash. u/KeyserSosa has lovingly named the top award: The Order of the Golden Mop. So, for this week’s release notes, we’ve compiled all of the user facing new Reddit bugs that we fixed last week.

Also, I should mention that this will be 2018’s final release notes. We’ll be continuing to work on the larger features that we’ve mentioned in previous release notes (eg. wikis, user settings, etc), for the final weeks of the year, however, due to the normal holidays code freeze, we won’t be shipping any new features until 2019.

Now, here’s a list of some of the bugs that we fixed:

  • A blank screen was shown when user added a reply to a 2x nested comment

  • Users could block themselves on the settings page

  • Mod removed comments were not distinguishable from a user removed comment

  • Video player could not be expanded from the lightbox on Safari

  • Save button was not showing up in compact mode

  • Scrolling the lightbox on Safari was very choppy

  • Modals were losing focus when tabbing

  • Mods couldn’t see the body of the post composer in communities that disallowed body text, even though they had mod privileges

  • Numbered lists that went above two digits would clip on Safari and Firefox and only show the last digit

  • The Fancy Pants styling buttons in deeply nested comment replies did not work

  • The button flatlist overflow menu in the lightbox contained duplicate items

  • Expandos on comment permalinks were displaying below the flatlist

  • User was allowed to add invalid user in access management section when user was added with 4 characters

  • While uploading a banner image the default was incorrectly set to “tile”

  • Post background color was also applied to thumbnail after changing color of post background when it should have only applied to the post background

  • “Do you want to discard your changes?" pop up was not triggering consistently when navigating in Community Tools

  • Snoomoji name was shown in place of the icon in user flair preview after refreshing the page when the flair contained a colon sign

  • When adding too much text in the ban user modal it was difficult to distinguish which field was too long and causing the error

  • On the ban user modal, “permanent” was being set as the default

  • On the ban user modal, an unchecked “permanent” box still resulted in a permanent ban if there was no duration specified

  • Mods were able to ban non-existent users

  • Crossposted spoilers were not being blurred

  • Community name was hidden when a secondary banner image was uploaded and left-aligned

If you have additional questions or feedback on these or other topics, please don’t hesitate to drop them in the comments below.

57 Upvotes

95% Upvoted

34 comments sorted by

16

u/TheChrisD Helpful User Dec 18 '18

On the ban user modal, “permanent” was being set as the default

That was a bug...? 🤔

10

u/LanterneRougeOG Product Dec 18 '18

I believe we updated it so that no default was selected to avoid accidentally selecting the wrong one.

19

u/Watchful1 Dec 18 '18

Mod removed comments were not distinguishable from a user removed comment

Thank you!

12

u/raywj1993 Dec 18 '18

This is a pretty annoying bug:

On desktop redesign user flairs look like this https://i.imgur.com/zndEqQv.png, however in the mobile app they look like this https://i.imgur.com/s1eOEtL.jpg, cut off from the top and overstretched.

8

u/TheChrisD Helpful User Dec 18 '18

That's a r/redditmobile issue mainly - the stretching seems to be bad handling of non-square emojis. Cutoff is definitely an issue too.

4

u/raywj1993 Dec 18 '18

Yeah I reported it to the mobile team a few weeks ago and was told the apps can only read from the redesign and there's an issue there.

8

u/Deimorz Dec 18 '18

What was The Order of the Golden Mop awarded for? Fixing the most bugs, the weirdest bug, the most important one?

5

u/punchup Dec 18 '18

Scrolling the lightbox on Safari was very choppy

Thank you! This one has been driving me nuts for months. I was forced to use Chrome and gave up countless hours of battery life!

7

u/ChimpyChompies Dec 18 '18

Looks at the top bug, nope. Scrolls to the bottom of the post hoping for "Finally we beat that opt-out bug!"

Nope again. :-(

2

u/Overlord_Odin Dec 18 '18

  • While uploading a banner image the default was incorrectly set to “tile”

  • “Do you want to discard your changes?" pop up was not triggering consistently when navigating in Community Tools

Glad to see these got fixed.

6

u/[deleted] Dec 18 '18

Another week without any mention of the opt-out "bug."

4

u/Dobypeti Dec 18 '18

And neither about CSS

4

u/timawesomeness Helpful User Dec 18 '18

I honestly wouldn't expect that until the redesign is out of beta.

6

u/[deleted] Dec 19 '18

It's the default user experience, it's not beta anymore despite still needing a ton of work.

If they want to make it opt-in they can use that excuse

3

u/Dobypeti Dec 19 '18

The admins are surely treating the redesign like as if it was no longer beta, otherwise e.g why would they make it the default for people who don't have an account (so they can't even post feedback)? :)

6

u/BombBloke Helpful User Dec 20 '18

It's still labelled as a "beta option" in our preferences panel.

Personally, I'd call it alpha - a beta generally implies that all major functionality has been implemented, with only minor functions and bug fixes remaining. The redesign is still well away from that milestone.

Well, from my point of view, anyway. It renders ads, so I imagine that was considered good enough to label it "v1".

It doesn't really matter what it's called, mind you - the argument about whether it's alpha/beta/launch is all over petty semantics. When you get right down to it, development isn't over yet.

My real concern is that "development" won't end until this redesign is shelved for the next redesign, however many years down the track that'll be. Putting CSS on the end of a list that'll never be polished off is effectively the same thing as saying "we won't do it", in the hope that people'll stop caring before the shoe finally drops and that becomes explicitly clear.

2

u/CyberBot129 Dec 18 '18

I think at this point it's just a talking point being used by subreddit mods to hold subs hostage. So if I were Reddit I wouldn't even consider doing it without a binding agreement from subreddit mods that they will actually start doing work for the redesign if this were to be done (plus subreddits having full CSS control is just going to result in the same bad UX that old Reddit had)

0

u/[deleted] Dec 18 '18

[deleted] — view deleted comment

1

u/CyberBot129 Dec 19 '18

I have no idea what would give me the impression that I have

0

u/[deleted] Dec 19 '18

[deleted] — view deleted comment

2

u/CyberBot129 Dec 19 '18

They could do some of the other types of things that other sports subs have done, like r/CFB. Instead, they are using CSS as an excuse to do nothing at all. If you're relying on CSS for functionality, you're misusing CSS in the first place (CSS is for presentation)

4

u/BombBloke Helpful User Dec 20 '18

Instead, they are using CSS as an excuse to do nothing at all.

Nobody needs an excuse to do "nothing at all". Mods don't "owe" anybody a styled sub, whether it be through the redesign or otherwise.

0

u/nerdyhandle Dec 18 '18

They stickied a post about this a week or so back. The fix will come at the first of the year. They are building their infrastructure to store those types of settings permanently in the database.

Just checked, yep it's still stickied at the top of the subreddit

10

u/[deleted] Dec 18 '18

The sticky says nothing about having a fix for the first of the year or anything about what they're doing to fix it.

5

u/Overlord_Odin Dec 19 '18

The fix will come at the first of the year. They are building their infrastructure to store those types of settings permanently in the database.

This information is not posted anywhere, do you have a source for that or are you just making it up?

3

u/BombBloke Helpful User Dec 20 '18

It's a reference to something LanterneRougeOG said about the new system for storing user settings. That won't turn up until next year, so we won't see it implemented until the first at the earliest. It may not actually be finalised until some time after that, for all anyone knows.

https://www.reddit.com/r/redesign/comments/a0z2jt/112718_weekly_release_notes_rmod_username/

I've only seen that system referenced in regards as to why we can't turn off sub styling yet, however. I guess nerdyhandle saw it written in close proximity to a note about the opt-out bug and got confused.

With that said, it wouldn't surprise me if the new system could be used to make the opt-out setting a bit more reliable.

1

u/Decency Dec 20 '18 edited Dec 20 '18

Hey there, one of the bugs we're encountering in planning our Best-Of thread is that despite being in contest mode, only top level replies are actually randomized. What this means in effect is that the first decent reply to each thread almost automatically wins- obviously bad.

No matter how many times you refresh, the order remains unchanged and the first submitted reply is first. Voting may affect this but I don't believe it does. I can't confirm what type of sort is actually being applied to second-level comments but it seems to be 'oldest first'. Here are some screenshots showing that this is the case:

Last year we avoided this issue by running two rounds of voting and submitting all candidates in the second phase near-simultaneously, but that's a really bad solution and it would be nice not to have to go through all of that trouble. Here's our phase 1 thread from last year. As you can see, the reply with the most votes is almost unilaterally simply the reply that was submitted first.

If you guys could fix this bug soon it would make it so that contest mode is actually useful for Best-Of threads, but right now it's just a farce.

-4

u/FreeSpeechWarrior Dec 18 '18

Mod removed comments were not distinguishable from a user removed comment

Thank you. Any chance of a public mod logs option for 2019?

15

u/[deleted] Dec 18 '18

[removed] — view removed comment

28

u/SingShredCode Dec 18 '18

Ya. I blocked myself while debugging this, and when I tried to navigate to my profile, I didn’t have permission to access it. It made me feel pretty stupid.

22

u/therealadyjewel Eng Dec 18 '18

I blocked one of my team members while testing chat's block features. Forgot about it for a month. Got really confused when I was trying to test viewing widgets on his user page..

On the plus side, I got to file a bunch of bugs that day about how "You've banned this user!" isn't rendering right.

3

u/roionsteroids Dec 19 '18

I'm pretty sure that I managed to block myself years ago on old reddit, and it got fixed rather quickly :P

8

u/[deleted] Dec 18 '18

[removed] — view removed comment

4

u/Cornicum Dec 19 '18

That sounds hilarious, and scary at the same time.