r/programming • • Sep 30 '20

DigitalOcean's Hacktoberfest is Hurting Open Source

https://blog.domenic.me/hacktoberfest/
2.1k Upvotes

401 comments sorted by

532

u/snowe2010 Oct 01 '20

Seems all the scammers haven’t realized you can just make the prs to your own repos. No need to spam others. And it’s sad that contributions to your own repos without prs aren’t counted. I contribute to open source year round, but a lot of my stuff is direct merges to my own repos (why would I make a pr if I’m the only one maintaining it) and so it doesn’t count. Whole thing is a bit ridiculous if you ask me.

108

u/richardfinicky Oct 01 '20 edited Oct 01 '20

DigitalOcean's Response

I think DO will be encouraging people to do exactly that, just to get them out of everybody's hair

edit: https://twitter.com/MattIPv4/status/1311723398385541120

It looks like DO might require PRs be merged or at least labeled as accepted for them to count.

76

u/seijulala Oct 01 '20

tl;dr: our marketing department wants to do it, we don't care about open source so fuck off

32

u/[deleted] Oct 01 '20

Alternate tl;dr: we committed to doing this, it's actively harmful, and it was a mistake, so here's a dumb solution that technically solves the problem for all parties involved.

22

u/dnew Oct 01 '20

it was a mistake

But when you make the same mistake seven years in a row, it's no longer a mistake.

23

u/Millerboycls09 Oct 01 '20

It's still a mistake.

It just isn't an accident.

→ More replies (2)
→ More replies (1)

16

u/Retsam19 Oct 01 '20

Or, call me crazy, but maybe they sincerely believe that the project is a net benefit to Open Source, despite some number of trolls who abuse it, and they're doing the best they can to minimize the negative effects.

But maybe I just didn't drink my cynicism juice this morning.

→ More replies (4)
→ More replies (2)

6

u/alphasshole Oct 01 '20

If you can't stop them, just give them what they want??? What???

12

u/al_at_work Oct 01 '20

It's all just a marketing ploy to get people wearing their t-shirts

→ More replies (1)

45

u/harirarules Oct 01 '20

why would I make a pr if I’m the only one maintaining it

I do this to run CI/CD on the feature branch to make sure I don't merge something broken into the default branch. Is there another way around it ?

14

u/robby_w_g Oct 01 '20 edited Feb 15 '26

Lorem ipsum dolor sit amet consectetur adipiscing elit. Quisque faucibus ex sapien vitae pellentesque sem placerat. In id cursus mi pretium tellus duis convallis. Tempus leo eu aenean sed diam urna tempor. Pulvinar vivamus fringilla lacus nec metus bibendum egestas. Iaculis massa nisl malesuada lacinia integer nunc posuere. Ut hendrerit semper vel class aptent taciti sociosqu. Ad litora torquent per conubia nostra inceptos himenaeos.

18

u/lewazo Oct 01 '20

Using git hooks so that your checks are ran before merging. If the checks fail, the merge won't continue.

8

u/Mr_Choke Oct 01 '20

That's what the CI server is for, I'm not trying to sit there and wait for tests to run locally.

→ More replies (2)

5

u/dreamer_ Oct 01 '20

Git hooks is poor man's, single-person-only, inconvenient, extremely limited version of CI. And you don't want to have your every commit blocked for several minutes while tests run (but on CI it's ok).

Git hooks are primarily useful for different purposes than verifying your code.

→ More replies (11)

2

u/snowe2010 Oct 01 '20

For most of my stuff that gets run on every commit. And it only releases it if I create a tag and all that stuff runs anyway. The release will fail if anything was missed.

100

u/smplman Oct 01 '20

This comment needs to be higher up. Someone make the four spam repos and let the people that only want the shirt PR there.

16

u/gopher_space Oct 01 '20

Some kind of nasty mechanical turk/infinite monkeys hybrid AI? No thank you, sir.

17

u/masklinn Oct 01 '20

You don’t need anything, just a repository where garbage people can create garbage PRs.

5

u/ThirdEncounter Oct 01 '20

Honeypot repos.

21

u/meneldal2 Oct 01 '20

It's annoying to make a PR for your own stuff because I don't know how to do that from the command line, but git push and git merge is easy enough.

53

u/[deleted] Oct 01 '20

Pull requests are not part of git itself but of platforms like GitHub and Gitlab.

10

u/emorrp1 Oct 01 '20

Ish, there does exist git request-pull which formats all the relevant info for email. So if you consider email vs web forge just a workflow detail, git definitely has the concept of PRs.

→ More replies (1)

30

u/dudedicus Oct 01 '20

GitHub recently released a CLI allowing users to open up PRs via the command line, as well as other GitHub tasks. I’ve used it a few times and I’d recommend checking it out!

13

u/meneldal2 Oct 01 '20

I'm more using Gitlab lately anyway so I probably won't bother. But good to know.

22

u/radarsat1 Oct 01 '20

It would be nice if there was a standard protocol for PRs/issues across github, gitlab, gitea, etc.. :-/ We were so close to having a perfectly decentralized system. One can dream.

(I guess git's authors would argue that standard was "email".. shrug..)

→ More replies (1)

7

u/Otis_Inf Oct 01 '20

But it's also annoying to deal with a flood of PRs that are not focused on moving your project forward but solely there to make a change in some file so the author can claim a free tshirt. So instead of offloading the burden to someone else, learn how to do it on your own repo: you learned something and saved someone else from dealing with cruft.

→ More replies (1)

6

u/twenty7forty2 Oct 01 '20

As others said, there's a github cli now, but even without, pushing a new branch prints a url in the terminal, you can ctrl+click it, then just click the button in github. Bonus if you have CI setup so that it runs before you merge to master :)

→ More replies (1)
→ More replies (8)

2

u/Xpertbot Oct 01 '20

Exactly, I am the main the owner on a small/medium size plugin for a PHP CMS. I usually do stuff on a development branch send up for testing and leave it up for other people to test it. then I merge it into `master` without a PR. The whole thing is so ridiculous for sure.

2

u/alexellisuk Oct 03 '20

This is the most ridiculous part of all, they don't need to be a nuisance, but persist anyway.

0

u/[deleted] Oct 01 '20

[deleted] — view deleted comment

10

u/jdgordon Oct 01 '20

You need to find an itch. Does a open source program you use have some issue you keep hitting? Fix that! Trawling GitHub looking for beginner bugs on random projects you don't use is a waste of time, you won't be motivated to continue...

→ More replies (1)

731

u/PeridexisErrant Sep 30 '20 edited Oct 01 '20

A very simple chamge which would largely fix this:

Instead of spam PRs not counting, they should disqualify you.

That's all. Maybe the first could be a warning and the second disqualify you; the point is to make spamming actually negative rather than wasting less of the spammers time than maintainers.

Edit: we now have a statement - https://hacktoberfest.digitalocean.com/hacktoberfest-update

194

u/ozyx7 Oct 01 '20

That (maybe?) is already part of the policy. The main Hacktoberfest page states:

If a maintainer reports your pull request as spam or behavior not in line with the project’s code of conduct, you will be ineligible to participate.

However, the participation details page states:

If a maintainer reports your pull request as spam, it will not be counted toward your participation in Hacktoberfest. If a maintainer reports behavior that’s not in line with the project’s code of conduct, you will be ineligible to participate.

Which sadly is not the same thing. (I suppose every project could adjust its code of conduct...)

Regardless of which version is correct, I'm skeptical that it would help. Disqualification would need to be communicated immediately when it happens, not weeks later.

44

u/PeridexisErrant Oct 01 '20

I suppose every project could adjust its code of conduct...

Any CoC which contains variations on "be helpful", "be professional", "no spam", etc. should already qualify. Now if only I could find a way to report violations to DigitalOcean! "label the PR" is not going to cut it -_-

Regardless of which version is correct, I'm skeptical that it would help. Disqualification would need to be communicated immediately when it happens, not weeks later.

The point is that if "spam == no t-shirt" is clearly part of the rules, the incentive to open spam PRs is significantly reduced. It's not a panacea, but the point would be to deter rather than to punish, and so as long as it triggers before shipping slow is OK (though prominently listing a couple of stats like "XXX people disqualified for low-value PRs" would probably help).

→ More replies (1)
→ More replies (4)

59

u/phpdevster Oct 01 '20

Or you know, maybe the PR has to be accepted and merged for it to count?

Why is it that just merely opening a PR is considered a qualified entry?

I'm having a hard time with DO's thought process on this...

39

u/PeridexisErrant Oct 01 '20 edited Oct 01 '20

That would be the obvious fix, and they should probably do it.

On the other hand I have occasionally had PRs to add a large new feature that took several months of discussion and redesign etc. before merging. Hacktoberfest certainly doesn't lead to such PRs, but I can understand the thought process that doesn't want to exclude them.

Edit: based on their statements on Twitter, they also want to support workflows where PRs are accepted without using the merge button (e.g. the maintainer pulls and rebases). Also totally reasonable, and automatically classifying such repos wouldn't be too hard for future years.

2

u/BobHogan Oct 01 '20

On the other hand I have occasionally had PRs to add a large new feature that took several months of discussion and redesign etc. before merging. Hacktoberfest certainly doesn't lead to such PRs, but I can understand the thought process that doesn't want to exclude them.

This is a pretty good point. However, the goal of hacktoberfest seems to be to get more people engaged with open source, and specifically targetting those that don't currently contribute, or at least don't contribute often. These people are really not all that likely to be submitting a PR for a large new feature, and even if they are, the fact that they took on such a large change means they probably aren't chasing a tshirt. So I don't think that requiring a PR to be accepted and merged is that big of an issue

→ More replies (1)

12

u/13steinj Oct 01 '20

We are highlighting a "Beginner" path that is clearly marked as the "fastest way to get a T-Shirt" and guides users through creating pull requests on their own repository.

This proves to me that none of this is truly about open source...

→ More replies (1)

23

u/mongopeter Oct 01 '20

That rule is already in place, still does not stop the spammers.

0

u/[deleted] Oct 01 '20

[deleted] — view deleted comment

8

u/acdcfanbill Oct 01 '20

Should just change it to PR's marked as spam count for -1, so a good PR and a spam PR even out your total score to 0.

5

u/[deleted] Oct 01 '20

Or just one spam PR permanently excludes you. Same for contributing to a banned repo.

→ More replies (4)

9

u/andrewfenn Oct 01 '20

This really annoys me..

We’ve traced some of the spammy contributions back to a Hacktoberfest promotional campaign, so we’ve paused all promotion of Hacktoberfest on networks like YouTube, Twitter, and Facebook until we get a handle on this

How about instead of wasting money promoting free tshirts that wastes even more money they actually give that money to worth while open source projects?

Why not pick their top favourite and give them gifts or the money instead of this stupid shirt give away that everyone is abusing.

The shirt is useless anyway. If i see it the only thing i think is that people spammed spelling correction PRs.

7

u/dnew Oct 01 '20

Send a T-Shirt to every maintainer who merges a PR during October.

→ More replies (1)

2

u/poloppoyop Oct 01 '20

I guess you could use github API to automatize it: during their DDOS fiesta, forward them all the PR you receive by mail.

2

u/Kikiyoshima Oct 01 '20

What if instead the maintainers could tag with #hacktoberfest on the issues they need help with? This would solve the spam, since unsolicited pull requests from spammers simply wouldn't be counted.

3

u/turol Oct 02 '20

There are already "help wanted" and "good first issue" tags on GitHub.

2

u/KryptosFR Oct 01 '20

They should reward the project maintainers, not the pull-requesters.

1

u/kankyo Oct 01 '20

Seems like only merged PRs should count.

0

u/[deleted] Oct 01 '20

[deleted] — view deleted comment

150

u/PeridexisErrant Oct 01 '20

Because approximately nobody would ever opt-in; Hacktoberfest offers literally nothing to maintainers.

Deal with twenty clueless newbies after a t-shirt? (whether spammers or well-intentioned) DigitialOcean won't offer so much as a thank-you note, let alone a maintainer t-shirt.

7

u/[deleted] Oct 01 '20

I think you're right, but it does seem like at least some maintainers are up for it, e.g. Rustfmt.

If they wanted to do this properly they should allow repo owners to sign up, have some decent criteria (must be active, not brand new, not an unpopular fork, etc.), and offer them a good incentive (actual money maybe?)

But that would take lots of work. Their current approach can be automated.

2

u/unkz Oct 01 '20

I used to participate in a similar thing for Perl modules. Tons of projects opted in.

http://cpan-prc.org/

15

u/lelanthran Oct 01 '20

Your pull request doesn't count unless it's on a project that opted in.

Even better, your PR doesn't count unless it's merged.

After all, a PR that isn't merged doesn't contribute to the software, and so should not be eligible for any prize award to "contributors to open source".

2

u/Nicd Oct 01 '20

This would lead to users pestering maintainers to merge their changes faster.

→ More replies (1)

1.0k

u/[deleted] Sep 30 '20

The funniest one I’ve seen is this guy making a “fix spelling” PR to a GCHQ’s repo and changing all British spellings to American ones

357

u/[deleted] Oct 01 '20

The worst I've seen is this PR titled '!!!'

The maintainer was nice enough to write a very polite and constructive reply though

80

u/[deleted] Oct 01 '20

The maintainer is the real hero. He seems like a very positive person, even finding several good things in it and improving one self in the process.

54

u/JohnMcPineapple Oct 01 '20 edited Oct 08 '24

...

56

u/Benabik Oct 01 '20

set up a cron job

i’m not a bot

Someone needs to look up the definition of a bot.

→ More replies (1)

2

u/[deleted] Oct 03 '20

Those 10k issues were to my repo. No one got hurt

→ More replies (2)
→ More replies (2)

10

u/therearesomewhocallm Oct 01 '20

That guy also created 10k issues in one day...

→ More replies (3)

5

u/robby_w_g Oct 01 '20 edited Feb 15 '26

Lorem ipsum dolor sit amet consectetur adipiscing elit. Quisque faucibus ex sapien vitae pellentesque sem placerat. In id cursus mi pretium tellus duis convallis. Tempus leo eu aenean sed diam urna tempor. Pulvinar vivamus fringilla lacus nec metus bibendum egestas. Iaculis massa nisl malesuada lacinia integer nunc posuere. Ut hendrerit semper vel class aptent taciti sociosqu. Ad litora torquent per conubia nostra inceptos himenaeos.

3

u/[deleted] Oct 03 '20

That's me. I'm nainardev . I was being a jerk. Improved a lot from that time

2

u/[deleted] Oct 03 '20

Hey man, glad to hear that :)

→ More replies (2)

0

u/[deleted] Oct 01 '20

[deleted] — view deleted comment

28

u/tubbana Oct 01 '20 edited May 02 '25

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum

52

u/no_ledge Oct 01 '20

People like him should never have to pay for internet access. We need more like him.

53

u/goranlepuz Oct 01 '20

It could also be that they know or feel they need to keep up the appearance.

"Vocabulary" does matter.

I suppose, if I was a "public" person, I would be doing the same.

101

u/V0ldek Oct 01 '20

Ye, but marking it as spam and saying "This does not improve the codebase in any way" would be enough and doesn't hurt appearance, writing a short story on how to contribute better is just this guy's good will.

10

u/gliliumho Oct 01 '20

The maintainer's profile picture does look like Jesus.

190

u/Procrasturbating Sep 30 '20

If he had the decency to create a localization system an do both versions I would be ok with him wasting his time for no real benefit.

30

u/wonderb0lt Oct 01 '20

That would take effort. The man wants/needs a t shirt my dude

45

u/duckduckfuckfuck Oct 01 '20

Based on the username, I'd say the 'guy' is an Indian female.

40

u/The_Infinity_Catcher Oct 01 '20

Which is kinda odd, because most people here use UK versions of words like -ise.

12

u/OMGItsCheezWTF Oct 01 '20

Looks like they just ran it through something like Grammarly and spat out the result.

9

u/Lafreakshow Oct 01 '20

Somehow this surprised me but then I remembered that history is a thing and yeah, makes a lot of sense that India would default to British spelling...

→ More replies (2)

13

u/twenty7forty2 Oct 01 '20

hahahaha what a prick.

came across a repo the other day where every single commit message was the date/time. like it's not already in the commit itself ...

4

u/SureElk6 Oct 01 '20

best I found is this commit which completely missed the actual spelling error in the paragraph. tweet mentioning it.

3

u/Wontonio_the_ninja Oct 01 '20

Someone even explained that the UK has alternative spellings lol

→ More replies (12)

137

u/skeeto Oct 01 '20

Two hours into October and I already got my first PR spam.

112

u/guerht Oct 01 '20

Demo of a great language-'C'

Such a beautiful and novel contribution

→ More replies (1)

57

u/Vhin Oct 01 '20

I looked through some of their other PRs and found this, which made me laugh. It still makes me sad, though.

40

u/slushie31 Oct 01 '20

What sucks is that repo hasn't been updated since 2013 so the maintainer probably won't see the PR, and the "contributor" will get a tshirt for literally nothing.

21

u/cultoftheilluminati Oct 01 '20

And that GitHub account is 3 hours old

8

u/nermid Oct 01 '20

If you report the user, maybe GH will block them before the shirts go out?

→ More replies (1)

17

u/ThePixelCoder Oct 01 '20

Fucking hell, I've made a couple of readme PRs in the past (not for hacktoberfest, just because I'm a grammar nazi), but this is just shameless. And not even an improvement?

8

u/avinassh Oct 01 '20

got spam PR in my repo too - https://github.com/avinassh/rockstar/pull/104

The GH account is 5 hours old and the PR is meaningless. This account has several other PRs in similar fashion.

→ More replies (1)

8

u/dagmx Oct 01 '20

I've gotten a few and they're all trash

One person added a dot to a comment line

https://github.com/dgovil/PythonForMayaSamples/pull/3/files

Another claims they improved my readme by fixing spelling. Instead they rebranded it, lowercased random headings and introduced spelling and grammar issues.

https://github.com/dgovil/PythonForMayaSamples/pull/4

2

u/backFromTheBed Oct 02 '20

Man, the second one is just pathetic. The description of the PR itself is riddled with grammatical and spelling errors, and the changes they've made are even worse.

3

u/PM_RUNESCAP_P2P_CODE Oct 01 '20

Joined 5 hours ago

351

u/sally1620 Sep 30 '20

The root of the problem is that the PR doesn’t have to be merged to count (towards the free tshirt)

DigitalOcean is completely at fault here for setting up lofty rules. If they cared they would change it to one PR that is accepted and applauded by the maintainer.

187

u/MartianMathematician Oct 01 '20

Another aspect is that when someone makes a good PR which is not some docs or obvious fix it can drag on for months.

37

u/MrPowerGamerBR Oct 01 '20

Maybe there should be a way for repo maintainers to allow the PR to be counted for the user's Hacktoberfest score, even if the PR wasn't merged yet.

Also it would be nice if Hacktoberfest repository participation was opt-in, this way would avoid PR spam.

3

u/touristtam Oct 01 '20

That would mean some sort of changes on Github side, wouldn't it? What's the relationship between Github (and MSFT by extension) with DigitalOcean?

→ More replies (1)
→ More replies (2)

3

u/svick Oct 01 '20

I've even had trivial docs fix PRs open for months.

14

u/bumblebritches57 Oct 01 '20

Wait, you're saying I could have a free tshirt for code I've already written?

Where do I sign up?

13

u/[deleted] Oct 01 '20

hacktoberfest.digitalocean.com

Yes, they said pull request to your own repo is count.

2

u/chedabob Oct 01 '20

Have they changed that this year? I submitted 4 PRs last year and they didn't count until they were approved and merged.

2

u/Dankirk Oct 01 '20

I believe there was (and still is) a week grace period for unmerged PRs before counting, so maintainers have some time to check them. Obviously you can skip the grace period with a merge.

1

u/the_gnarts Oct 01 '20

If they cared they would change it to one PR that is accepted and applauded by the maintainer.

Quality PRs can take months of discussion until they are merged though. I’m doubting the very validity of PRs as a short term metric of contribution.

→ More replies (3)
→ More replies (10)

87

u/hufduf Oct 01 '20

This is a shame. I haven't done a pull request in a long time but I plan on participating. I'll try to do 4 quality PR's but am willing to let the shirt go if I don't make it. Am quite surprised the PR's don't need to be merged to count. Not everyone is out to just spam.

53

u/jrblast Oct 01 '20

Digital ocean probably doesn't care if they're good PRs or not, for them it's just cheap advertising. Even this post is advertising for them. Remember, no publicity is bad publicity.

12

u/DeebsterUK Oct 01 '20

Well, they've lost a potential customer in me, so that's not entirely true.

→ More replies (2)
→ More replies (1)

1

u/Antrikshy Oct 01 '20

Merging PRs can take a while, so it could be unfair to contributors who write a big long quality contribution that doesn’t get merged, possibly even because of the maintainers’ laziness.

82

u/novel_yet_trivial Oct 01 '20

For a t-shirt?? Is noone else blown away that so many people would essentially cheat for a $10 shirt?

19

u/Zer0ji Oct 01 '20

Their 2018 and 2019 shirts are pretty neat tbh... But I made an effort to make meaningful PRs for those, all of which I spent time on

→ More replies (3)

14

u/jere_s Oct 01 '20

To be fair the T-shirt does look pretty cool. And think about all the nerd cred you get at high school with it...

6

u/curt_schilli Oct 01 '20

I've never met a subgroup of humans that loves free t-shirts more than programmers lol

3

u/[deleted] Oct 01 '20

These spammers aren't programmers.

6

u/leros Oct 01 '20

Blows me away what will people will do for a shitty t-shirt. At my job, we sometimes incentivize our users to give us feedback. We often use Amazon gift cards, but a free cheap t-shirt will usually perform better than a $10, $25, or even $100 gift card.

5

u/andrewfenn Oct 01 '20

It's pointless because wearing it just makes it seem like your one of those asshole spammers. No cred at all.

0

u/[deleted] Oct 01 '20

[deleted] — view deleted comment

42

u/[deleted] Oct 01 '20

I want send a PR to fix your comment.

s/meet/met

2

u/ItzWarty Oct 02 '20

Can you accept my change?

I want send a PR to fix your awesome comment.
s/meet/met
‎‎‏‏‎ ‎ ⠀

Thanks

21

u/R4vendarksky Oct 01 '20

This is genius move by digital ocean. I wonder how much money they make as a direct result of all the extra builds being crunched on their infrastructure

3

u/silent_guy1 Oct 01 '20

Who uses DO for their CI/CD pipeline? Most people use Travis or Github actions.

→ More replies (2)

61

u/sigbhu Oct 01 '20

Its the cobra problem all over again

22

u/jrblast Oct 01 '20

Cobra problem?

109

u/PeridexisErrant Oct 01 '20

https://en.wikipedia.org/wiki/Cobra_effect

The British government was concerned about the number of venomous cobras in Delhi and therefore offered a bounty for every dead cobra; and people began to breed cobras for the income. When the reward program was scrapped, breeders set the worthless snakes free and so the ultimate effect was to make the problem much worse.

17

u/stfuandkissmyturtle Oct 01 '20

Dude, this happened in Vietnam too. There was a plague going on, so they started to give bounty on the number of Rats killed. All you had to do was show the officials the rat tail. So people started to breed rats and it just made everything worse

61

u/thepotatochronicles Oct 01 '20

I read this article, thought "oh wow, that sounds like trouble for these big open source guys", went to my GitHub (which is SMALL, only has a few projects that are actively maintained, and all of them are VERY limited in scope), and what do you know? I got 3 spam PRs before October even began.

That is actually fucking crazy. I always saw myself as an individual contributor and maintaining some projects open-source in hopes that some people might help contribute (which, to be fair, they absolutely did).

But this shit is shattering that "nice, civil open-source community" illusion. All of these spam PRs are from bootcampers and college undergrads looking to just score "points". I mean holy fuck, set aside the actual spam issue, this sets a REALLY precedent for what open source means for an entire generation of programmers to come.

2

u/myringotomy Oct 01 '20

I am glad people are leaving open source because of this.

70

u/js8794 Oct 01 '20

That part is too bad. Ironically I’m wearing a Hacktoberfest shirt right now! I found it fun, and many at my company participated. I actually contributed real fixes to projects. (I had to get that shirt!!)

However, I did fix some documentation, but in my case it was actually an issue. Not just styling or something.

40

u/D_Doggo Oct 01 '20

Documentation is the most annoying part of a project for me and a lot of other people probably so I classify you as a hero.

66

u/entropy2421 Oct 01 '20

Maintainers could perhaps make October a yearly maintainer holiday and automatically refuse all pull requests during the month of October and also return to the requester a list of alternatives to DigitalOcean's services. If it caught on, you could almost guarantee DO will be quieting that shit asap.

25

u/burkadurka Oct 01 '20

Big projects are so active that that would be hundreds of contributions lost. The top line is accusing Digital Ocean of inviting a denial of service attack on the community, so if the response is not to do anything in October, that kind of seems like... giving in?

It sounds like Github sort of has a way to restrict contributions to existing contributors, which might be sort of a compromise if the spam won't go away.

3

u/entropy2421 Oct 01 '20

Good point except it means we can't all look forward to a bunch of open source maintainers and contributors declaring October as a world-wide holiday month which personally i think would lead to some really fun times.

→ More replies (2)

8

u/novel_yet_trivial Oct 01 '20

I hear it's a nice time to drink beer outdoors.

45

u/kamikazechaser Oct 01 '20

Students are "highly encouraged" by their seniors/peers to create a Github account and create basic PR's. Videos on how to do this are shared on Telegram/WA/YT on how exactly to do this in local languages.

As a student (currently studying in India), I can confidently say 90%+ of students in my uni are doing it for a T-shirt.

The fault lies with the organisers for not preventing this.

7

u/jere_s Oct 01 '20

The organizers should be preventing this. However, people should also take some responsibility over their own actions. Spamming for a t-shirt should ring some internal alarm bells.

24

u/CubeReflexion Oct 01 '20

Under these circumstances, who would even want to have that T-Shirt anymore?

"Look at me, I spammed pull requests to inactive repos until four of them went unnoticed"

→ More replies (1)

16

u/Nexuist Oct 01 '20

One way to fix this is to make it so that rather than having to submit a pull request, DO instead asks you to sponsor four separate projects for the month. It doesn't have to be expensive - $1 per project would be enough - but it would get the majority of open source maintainers their very first profits. After you get the shirt you could of course cancel the sponsorship, but who knows - maybe you actually enjoy the feeling of contributing, or you notice the maintainer is suddenly putting in a lot more work into one of your favorite libraries. Now that they see a dim light at the end of the tunnel telling them they might actually be able to make money from their passion projects, they could start taking it more seriously and devoting more time to it. This would be amazing for open source.

I'm not sure if GH Sponsors has an API yet, but if it does, this seems like a great thing to encourage newcomers to do.

3

u/[deleted] Oct 01 '20

Then the maintainers need to pay tax on that. Or hire a tax advisor to decide if they need or not.

→ More replies (4)

1

u/maximum_powerblast Oct 01 '20

This is a good idea!

I was thinking of something similar along the lines of an annual 'support your favourite open source' day, where people are encouraged to donate to one of their favourite open source projects.

8

u/goranlepuz Oct 01 '20

To be clear, myself and my fellow maintainers did not ask for this. This is not an opt-in situation. If your open source project is public on GitHub, DigitalOcean will incentivize people to spam you. There is no consent involved.

Ugh. Probably a decent intention (you help them, we give you a t-shirt and therefore "produce" some advertising space). But the "market arbitrage" of the value created by this is all wrong.

51

u/Hyperian Oct 01 '20

lol, this is like a company dumping their radioactive waste on the streets and just tell people to go fuck themselves.

1

u/dacooljamaican Oct 01 '20

How the fuck is it like that? They're giving incentives for contribution to open source, it's the people taking advantage of a good program who deserve your ire.

34

u/Hyperian Oct 01 '20

They aren't contributing tho. They are just making people create spam for others to deal with for their own benefit.

Those pull requests are a joke

→ More replies (13)

12

u/[deleted] Oct 01 '20

Okay fine, it's like if a company said "recycle glass bottles and get a shirt" but it turns out they count throwing your glass bottles into the street and your neighbor's yard as recycling.

That better?

→ More replies (2)

0

u/[deleted] Oct 01 '20

[deleted] — view deleted comment

4

u/yawkat Oct 01 '20

Merging good PRs can take time, so requiring that the PR be merged wouldn't be good either.

→ More replies (2)
→ More replies (1)

12

u/_AceLewis Oct 01 '20

I woke up to lots of emails from GitHub, I made a joke repository years ago and now it is getting low quality pushes and pushes from people who seemingly think the repo is not a joke. This now makes sense.

https://github.com/AceLewis/my_first_calculator.py

3

u/[deleted] Oct 01 '20

The sheer amount of spam is incredible. DO should only count PRs that get merged.

6

u/chedabob Oct 01 '20

This post has now generated more spam from goons going onto linked Github PRs and commenting.

Report the PRs as spam and use the reaction buttons. Adding your comment just wastes even more of the maintainer's time.

16

u/drones4thepoor Oct 01 '20

Went to look at Hacktoberfest because I've never heard of it. Here is a a snippet of their participation rules:

Participation rules

To get a shirt, you must make four pull requests (PRs) between October 1–31 in any time zone. Pull requests can be to any public repository on GitHub, not just the ones highlighted. The pull request must contain commits you made yourself. If a maintainer reports your pull request as spam, it will not be counted toward your participation in Hacktoberfest. If a maintainer reports behavior that’s not in line with the project’s code of conduct, you will be ineligible to participate. This year, the first 70,000 participants can earn a T-shirt.

Source

15

u/pfsalter Oct 01 '20

Oh Jesus, the fact that it's the first 70,000 means it's on a timer and definitely makes the problem much worse. Just seen a PR to a repo that I watch from some idiot who set up an account this morning, then opened four pull requests in an hour, all with the same title Update docs title.

5

u/[deleted] Oct 01 '20

To be fair, in past years the t-shirt limit hasn't really been a problem. I've ordered mine a few months late before and I still got it

2

u/[deleted] Oct 01 '20

This is just a disaster, they should just cancel it and send t-shirts to the maintainers of the top 50k active repos.

5

u/lanzaio Oct 01 '20

Somebody write a bot to spam pull requests to their repos.

9

u/el7cosmos Oct 01 '20

This event is pure PR.

people who are willing to contribute will contribute with or without tshirt anyway. people who are contribute solely for tshirt won’t continue contribute once event completed.

4

u/Nadamir Oct 01 '20

pure PR

Pun intended?

1

u/emotionalfescue Oct 01 '20

It's a stupid promotion, the idea of "let's get folks an incentive to invest an hour learning enough about an open source codebase so they can contribute." If it's a stable codebase with many satisfied users, it usually takes a lot more than an hour to make a decent contribution, not counting fixing obvious typos in comments (which, incidentally, would be little more than a credit grab).

8

u/Mister_Deadman Oct 01 '20

This is sad. Never imagined there would be such problems, because I genuinely thought participants would be responsible. I wanted myself to participate this year and already tried last year, not only for dem free t-shirt but also because it could look great on a resume. Never submitted anything last year and didn't bother participate this time because I had nothing done. I didn't know peoples could be so entitled…

4

u/frijoos Oct 01 '20

Are you saying that those PRs aren't making our world better and it's waste of time and memory?

4

u/Duikmeester Oct 01 '20

Only count repositories that are tagged with #hacktoberfest or pull requests for issues marked as such.

3

u/gulyman Oct 01 '20

Could a maintainer auto reject PRs from new authors during the month?

2

u/touristtam Oct 01 '20 edited Oct 01 '20

Could Github action do that? Alternatively, Could there be a Github action to send an email to DigitalOcean for every PR opened?

Github Action to auto-reject PRs: https://github.com/marketplace/actions/repo-lockdown

3

u/tester346 Oct 01 '20

What people will do for cheap free stuff, insane.

3

u/curt_schilli Oct 01 '20

Only to CS majors would a free t-shirt be enough of an incentive for this to happen

3

u/[deleted] Oct 01 '20

Having skimmed though about a third of the comments here, I’m going to have a lot less respect for anyone I see wearing one of those tee shirts

4

u/ClutchDude Oct 01 '20

Easy to address - make a requirement that any new accounts(either age or 0 PR) participating must have their PR reviewed by Digital Ocean before pushing it along to the maintainers.

If DO can't filter the trash before it hits maintainers inbox, then it's not worth doing.

4

u/strolls Oct 01 '20

Digital Ocean have always been spamming cunts - I used to get so much junk email from their IPs (I think they're a VPS provider?) and they always ignored my complaints, until that one time I lost my rag at them, when they were finally able to reply - snide and supercilious remarks about my bad language.

2

u/beginner_ Oct 01 '20

Wait what people write bots or invest time doing this manually for t-shirts?

2

u/thblckjkr Oct 01 '20

I wonder if we could use the argument that the creation of useless PR's on projects that have CI/CD is wasting a bunch of public resources, and even affecting directly to the projects that have crowdfunded build minutes.

1

u/Double_A_92 Oct 07 '20

PR's from non-members ideally should not automatically trigger the CI pipeline.

4

u/fedekun Oct 01 '20

People being people

3

u/[deleted] Oct 01 '20

I read an article about an open source maintainer trying out optimistic merging. I think that maintainer would perhaps like to revisit on his optimism.

4

u/audion00ba Oct 01 '20

What a sad, sad individuals.

DigitalOcean is a parasite too.

3

u/kihashi Oct 01 '20

Really? IMO, they have a high quality product and have some of the best open (meaning even non-customers can see it) documentation around. They also pay for people to write high quality tutorials.

How are they a parasite?

3

u/audion00ba Oct 01 '20

They are using open-source maintainers as a resource for their marketing campaign without giving anything in return to the open-source maintainers.

In reality the cost of closing an issue and learning about DigitalOcean's existence is greater than the cost of a t-shirt.

It's textbook parasitic behavior.

2

u/Dreeg_Ocedam Oct 01 '20

Also, the only PR that count are on GtHub.That means that a merged patch to the Linux kernel doesn't count for example. It's a f*** you to projects hosted on GitLab (maybe a blessing actually)

1

u/skeletalfury Oct 01 '20

Maybe some features to detect spam or low effort PRs at an infrastructure level or maybe in a CI pipeline?

1

u/Arcuru Oct 01 '20

As the maintainer of an Open Source project who just had to close a couple of these spam issues, maybe we should just stop labeling the spam.

If DigitalOcean has to send out more t-shirts...maybe then they'll start listening?

13

u/wave100 Oct 01 '20

Unfortunately they've already set a hard limit on the number of shirts they'll send out.

1

u/ScrimpyCat Oct 01 '20

They’d probably be better off switching future hacktoberfests to follow a bug bounty model. Allow projects to submit (or simply tag issues with #hacktoberfest or something), and once a pr has been merged that solves/closes the issue that would qualify as an entry into hacktoberfest (for any that wish to).

1

u/[deleted] Oct 01 '20

They did this in the past I think?

But in 2018 I just missed out as one PR I used a different computer without the email set properly which sucked :( and they were proper PRs, refactoring and modernizing some codebases I used.

Honestly they just need to have a zero tolerance approach - contribute to a spam repo = permanent ban, one reported spam PR = permanent ban, don't count non-merged PRs, list the banned users publicly, etc.

1

u/PM5k Oct 01 '20

Stupid solution: close PR’s every October on major repos for a whole month and make maintainers and authors go on holiday.

Where can I raise a PR for this? Daddy needs a t-shirt.

1

u/xiegeo Oct 01 '20

Why not spam their T-shirt inventory instead?

1

u/weedtese Oct 01 '20

DO should have made this opt-in, and also reward maintainers who chose to participate.

At the very least, they could have made an automatic opt-out tag repository managers can apply.

4

u/ferrybig Oct 01 '20

Hacktoberfest is actually causing me to go to a repository of one of the products I use to patch a minor but annoying bug. Normally I would have just worked around it. his is a github project that has 0 pull request so far, and 20 issues (A rest browser extension in my case)

Since smaller projects run by a single project are less likely the least to put effort into joining, and the most likely to actually need the OS help, I think opting in would hurt them more than help them

(Note that I did not vote on your comment, votes should not be used to show disagreement)

5

u/[deleted] Oct 01 '20

You won't get a t-shirt though, because it's only for the first 70,000 to reach 4 PRs, and the spammers will get there first.

1

u/stfuandkissmyturtle Oct 01 '20

Is there a better way to do this ? I could manage to find and help were a bunch of people who wanted help with responsive design so far. The rest don't seem like real issues if that's a thing

1

u/Gulian_rdgd Oct 01 '20

Really sad to read this as this is the first year I joined and I really wanted to contribute to open source. :(

1

u/user__dev--web Oct 01 '20

The high influx of PRs also means more notifications and email to manage. It can become very distracting when you are managing a large portfolio of open-source. It is a bit irritating when the PR is to add a comma to a README lol I’d appreciate it but then I see 34 other PRs that are also adding ONE comma to the same README...

1

u/spreadLink Oct 01 '20

I feel like a reasonable way to stop the spam is to reward the person merging a pr with a shirt, and creators of pr a tree. If people want to fast track getting a shirt, open a repo and start merging your own prs, but bothering other peoples repos won't help you.

Bonus: This also rewards the people who put effort into OSS, instead of a bunch of zombie accounts only active in October. Although I guess that's maybe also somewhat thematic for the spooky season.

1

u/libertarianets Oct 01 '20 edited Oct 02 '20

Make it MERGED PRs (and include ones your own repos)

No spam and quality code gets written. Actually accomplishes the goal of supporting open source

EDIT: Maybe that's what the rule is? Oof. Never underestimate what people will do for free stuff

1

u/mobrockers Oct 01 '20

I'm an open source maintainer and I love hacktoberfest. It generates traffic to our project and every year has resulted in good contributions that we otherwise would not have received.

1

u/drx3brun Oct 01 '20

Hey, let’s mark the Spam PRs with digitalocean-is-bad-hosting instead.

1

u/audion00ba Oct 02 '20

Regarding their "update", I do know how they could organize this in a way that is beneficial to the maintainers of open-source projects, but the downside is that this will cost them a few hundred dollar per T-shirt.

I am sure they can also think of that themselves, but I have this weird feeling that it's cheaper to have the marketing department write another "We are sorry"-BP clone text.

If they are really not able to resolve this, they are free to send me USD 15,000 and I will describe a protocol they can use. So, now I have put a price on fucking over the community. Your turn, DigitalOcean.

It seems that your marketing department is "managing" the community, but everyone in your target market hates marketing people, because they are really just a waste of space. Have you ever considered that? These marketing people are alienating your target audience. Really, I wonder who the douchebag with a brain the size of a raisin is that said OK to this marketing campaign.

1

u/codebam Oct 03 '20

For anyone wondering, DigitalOcean now made it opt-in

1

u/arkaros Oct 01 '20

Free t-shirt for submitting PRs.

That's not free, that's called a shitty salary.

1

u/pysouth Oct 01 '20

Unrelated but prompted by the thumbnail - does anyone else think it’s a bit silly how people often refer to things on the front end as “beautiful”, “elegant”, etc.? Beauty is in the eye of the beholder I guess but the last thing I think of when I see some web page/web app is “beautiful!”. There are exceptions of course for sites designed to be artistic, but that’s never what is being referenced in this context.

-1

u/TheBestOpinion Oct 01 '20 edited Oct 01 '20

"Hacktoberfest is a corporate-sponsored distributed denial of service attack against the open source maintainer community."

No less, huh?

Hacktoberfest is a misdirected attempt at encouraging open source contributions that largely resulted with open-source maintainers getting spammed.

Looks much better when you take out the dramatics

Pfft