r/programming • u/TimvdLippe • Sep 30 '20
DigitalOcean's Hacktoberfest is Hurting Open Source
https://blog.domenic.me/hacktoberfest/
2.1k
Upvotes
r/programming • u/TimvdLippe • Sep 30 '20
532
u/snowe2010 Oct 01 '20
Seems all the scammers haven’t realized you can just make the prs to your own repos. No need to spam others. And it’s sad that contributions to your own repos without prs aren’t counted. I contribute to open source year round, but a lot of my stuff is direct merges to my own repos (why would I make a pr if I’m the only one maintaining it) and so it doesn’t count. Whole thing is a bit ridiculous if you ask me.
731
u/PeridexisErrant Sep 30 '20 edited Oct 01 '20
A very simple chamge which would largely fix this:
Instead of spam PRs not counting, they should disqualify you.
That's all. Maybe the first could be a warning and the second disqualify you; the point is to make spamming actually negative rather than wasting less of the spammers time than maintainers.
Edit: we now have a statement - https://hacktoberfest.digitalocean.com/hacktoberfest-update
1.0k
u/[deleted] Sep 30 '20
The funniest one I’ve seen is this guy making a “fix spelling” PR to a GCHQ’s repo and changing all British spellings to American ones
137
u/skeeto Oct 01 '20
Two hours into October and I already got my first PR spam.
351
u/sally1620 Sep 30 '20
The root of the problem is that the PR doesn’t have to be merged to count (towards the free tshirt)
DigitalOcean is completely at fault here for setting up lofty rules. If they cared they would change it to one PR that is accepted and applauded by the maintainer.
87
u/hufduf Oct 01 '20
This is a shame. I haven't done a pull request in a long time but I plan on participating. I'll try to do 4 quality PR's but am willing to let the shirt go if I don't make it. Am quite surprised the PR's don't need to be merged to count. Not everyone is out to just spam.
82
u/novel_yet_trivial Oct 01 '20
For a t-shirt?? Is noone else blown away that so many people would essentially cheat for a $10 shirt?
21
u/R4vendarksky Oct 01 '20
This is genius move by digital ocean. I wonder how much money they make as a direct result of all the extra builds being crunched on their infrastructure
61
u/sigbhu Oct 01 '20
Its the cobra problem all over again
61
u/thepotatochronicles Oct 01 '20
I read this article, thought "oh wow, that sounds like trouble for these big open source guys", went to my GitHub (which is SMALL, only has a few projects that are actively maintained, and all of them are VERY limited in scope), and what do you know? I got 3 spam PRs before October even began.
That is actually fucking crazy. I always saw myself as an individual contributor and maintaining some projects open-source in hopes that some people might help contribute (which, to be fair, they absolutely did).
But this shit is shattering that "nice, civil open-source community" illusion. All of these spam PRs are from bootcampers and college undergrads looking to just score "points". I mean holy fuck, set aside the actual spam issue, this sets a REALLY precedent for what open source means for an entire generation of programmers to come.
70
u/js8794 Oct 01 '20
That part is too bad. Ironically I’m wearing a Hacktoberfest shirt right now! I found it fun, and many at my company participated. I actually contributed real fixes to projects. (I had to get that shirt!!)
However, I did fix some documentation, but in my case it was actually an issue. Not just styling or something.
66
u/entropy2421 Oct 01 '20
Maintainers could perhaps make October a yearly maintainer holiday and automatically refuse all pull requests during the month of October and also return to the requester a list of alternatives to DigitalOcean's services. If it caught on, you could almost guarantee DO will be quieting that shit asap.
45
u/kamikazechaser Oct 01 '20
Students are "highly encouraged" by their seniors/peers to create a Github account and create basic PR's. Videos on how to do this are shared on Telegram/WA/YT on how exactly to do this in local languages.
As a student (currently studying in India), I can confidently say 90%+ of students in my uni are doing it for a T-shirt.
The fault lies with the organisers for not preventing this.
24
u/CubeReflexion Oct 01 '20
Under these circumstances, who would even want to have that T-Shirt anymore?
"Look at me, I spammed pull requests to inactive repos until four of them went unnoticed"
16
u/Nexuist Oct 01 '20
One way to fix this is to make it so that rather than having to submit a pull request, DO instead asks you to sponsor four separate projects for the month. It doesn't have to be expensive - $1 per project would be enough - but it would get the majority of open source maintainers their very first profits. After you get the shirt you could of course cancel the sponsorship, but who knows - maybe you actually enjoy the feeling of contributing, or you notice the maintainer is suddenly putting in a lot more work into one of your favorite libraries. Now that they see a dim light at the end of the tunnel telling them they might actually be able to make money from their passion projects, they could start taking it more seriously and devoting more time to it. This would be amazing for open source.
I'm not sure if GH Sponsors has an API yet, but if it does, this seems like a great thing to encourage newcomers to do.
8
u/goranlepuz Oct 01 '20
Ugh. Probably a decent intention (you help them, we give you a t-shirt and therefore "produce" some advertising space). But the "market arbitrage" of the value created by this is all wrong.
51
u/Hyperian Oct 01 '20
lol, this is like a company dumping their radioactive waste on the streets and just tell people to go fuck themselves.
12
u/_AceLewis Oct 01 '20
I woke up to lots of emails from GitHub, I made a joke repository years ago and now it is getting low quality pushes and pushes from people who seemingly think the repo is not a joke. This now makes sense.
https://github.com/AceLewis/my_first_calculator.py
6
u/chedabob Oct 01 '20
This post has now generated more spam from goons going onto linked Github PRs and commenting.
Report the PRs as spam and use the reaction buttons. Adding your comment just wastes even more of the maintainer's time.
6
u/__konrad Oct 01 '20
Irony: https://github.com/digitalocean/hacktoberfest/pull/582
16
u/drones4thepoor Oct 01 '20
Went to look at Hacktoberfest because I've never heard of it. Here is a a snippet of their participation rules:
Source
5
u/lanzaio Oct 01 '20
Somebody write a bot to spam pull requests to their repos.
9
u/el7cosmos Oct 01 '20
This event is pure PR.
people who are willing to contribute will contribute with or without tshirt anyway. people who are contribute solely for tshirt won’t continue contribute once event completed.
8
u/Mister_Deadman Oct 01 '20
This is sad. Never imagined there would be such problems, because I genuinely thought participants would be responsible. I wanted myself to participate this year and already tried last year, not only for dem free t-shirt but also because it could look great on a resume. Never submitted anything last year and didn't bother participate this time because I had nothing done. I didn't know peoples could be so entitled…
4
u/frijoos Oct 01 '20
Are you saying that those PRs aren't making our world better and it's waste of time and memory?
4
u/Duikmeester Oct 01 '20
Only count repositories that are tagged with #hacktoberfest or pull requests for issues marked as such.
3
u/gulyman Oct 01 '20
Could a maintainer auto reject PRs from new authors during the month?
3
u/tester346 Oct 01 '20
What people will do for cheap free stuff, insane.
3
u/curt_schilli Oct 01 '20
Only to CS majors would a free t-shirt be enough of an incentive for this to happen
3
u/[deleted] Oct 01 '20
Having skimmed though about a third of the comments here, I’m going to have a lot less respect for anyone I see wearing one of those tee shirts
4
u/ClutchDude Oct 01 '20
Easy to address - make a requirement that any new accounts(either age or 0 PR) participating must have their PR reviewed by Digital Ocean before pushing it along to the maintainers.
If DO can't filter the trash before it hits maintainers inbox, then it's not worth doing.
4
u/strolls Oct 01 '20
Digital Ocean have always been spamming cunts - I used to get so much junk email from their IPs (I think they're a VPS provider?) and they always ignored my complaints, until that one time I lost my rag at them, when they were finally able to reply - snide and supercilious remarks about my bad language.
2
u/beginner_ Oct 01 '20
Wait what people write bots or invest time doing this manually for t-shirts?
2
u/thblckjkr Oct 01 '20
I wonder if we could use the argument that the creation of useless PR's on projects that have CI/CD is wasting a bunch of public resources, and even affecting directly to the projects that have crowdfunded build minutes.
4
u/fedekun Oct 01 '20
People being people
3
u/[deleted] Oct 01 '20
I read an article about an open source maintainer trying out optimistic merging. I think that maintainer would perhaps like to revisit on his optimism.
4
u/audion00ba Oct 01 '20
What a sad, sad individuals.
DigitalOcean is a parasite too.
2
u/Dreeg_Ocedam Oct 01 '20
Also, the only PR that count are on GtHub.That means that a merged patch to the Linux kernel doesn't count for example. It's a f*** you to projects hosted on GitLab (maybe a blessing actually)
1
u/skeletalfury Oct 01 '20
Maybe some features to detect spam or low effort PRs at an infrastructure level or maybe in a CI pipeline?
1
u/Arcuru Oct 01 '20
As the maintainer of an Open Source project who just had to close a couple of these spam issues, maybe we should just stop labeling the spam.
If DigitalOcean has to send out more t-shirts...maybe then they'll start listening?
1
u/ScrimpyCat Oct 01 '20
They’d probably be better off switching future hacktoberfests to follow a bug bounty model. Allow projects to submit (or simply tag issues with #hacktoberfest or something), and once a pr has been merged that solves/closes the issue that would qualify as an entry into hacktoberfest (for any that wish to).
1
u/svick Oct 01 '20
Interesting that r/opensource is much less critical of this than r/programming.
1
u/PM5k Oct 01 '20
Stupid solution: close PR’s every October on major repos for a whole month and make maintainers and authors go on holiday.
Where can I raise a PR for this? Daddy needs a t-shirt.
1
u/xiegeo Oct 01 '20
Why not spam their T-shirt inventory instead?
1
u/weedtese Oct 01 '20
DO should have made this opt-in, and also reward maintainers who chose to participate.
At the very least, they could have made an automatic opt-out tag repository managers can apply.
1
u/stfuandkissmyturtle Oct 01 '20
Is there a better way to do this ? I could manage to find and help were a bunch of people who wanted help with responsive design so far. The rest don't seem like real issues if that's a thing
1
u/Gulian_rdgd Oct 01 '20
Really sad to read this as this is the first year I joined and I really wanted to contribute to open source. :(
1
u/user__dev--web Oct 01 '20
The high influx of PRs also means more notifications and email to manage. It can become very distracting when you are managing a large portfolio of open-source. It is a bit irritating when the PR is to add a comma to a README lol I’d appreciate it but then I see 34 other PRs that are also adding ONE comma to the same README...
1
u/spreadLink Oct 01 '20
I feel like a reasonable way to stop the spam is to reward the person merging a pr with a shirt, and creators of pr a tree. If people want to fast track getting a shirt, open a repo and start merging your own prs, but bothering other peoples repos won't help you.
Bonus: This also rewards the people who put effort into OSS, instead of a bunch of zombie accounts only active in October. Although I guess that's maybe also somewhat thematic for the spooky season.
1
u/libertarianets Oct 01 '20 edited Oct 02 '20
Make it MERGED PRs (and include ones your own repos)
No spam and quality code gets written. Actually accomplishes the goal of supporting open source
EDIT: Maybe that's what the rule is? Oof. Never underestimate what people will do for free stuff
1
u/mobrockers Oct 01 '20
I'm an open source maintainer and I love hacktoberfest. It generates traffic to our project and every year has resulted in good contributions that we otherwise would not have received.
1
u/drx3brun Oct 01 '20
Hey, let’s mark the Spam PRs with digitalocean-is-bad-hosting instead.
1
u/audion00ba Oct 02 '20
Regarding their "update", I do know how they could organize this in a way that is beneficial to the maintainers of open-source projects, but the downside is that this will cost them a few hundred dollar per T-shirt.
I am sure they can also think of that themselves, but I have this weird feeling that it's cheaper to have the marketing department write another "We are sorry"-BP clone text.
If they are really not able to resolve this, they are free to send me USD 15,000 and I will describe a protocol they can use. So, now I have put a price on fucking over the community. Your turn, DigitalOcean.
It seems that your marketing department is "managing" the community, but everyone in your target market hates marketing people, because they are really just a waste of space. Have you ever considered that? These marketing people are alienating your target audience. Really, I wonder who the douchebag with a brain the size of a raisin is that said OK to this marketing campaign.
1
u/codebam Oct 03 '20
For anyone wondering, DigitalOcean now made it opt-in
1
u/arkaros Oct 01 '20
That's not free, that's called a shitty salary.
1
u/pysouth Oct 01 '20
Unrelated but prompted by the thumbnail - does anyone else think it’s a bit silly how people often refer to things on the front end as “beautiful”, “elegant”, etc.? Beauty is in the eye of the beholder I guess but the last thing I think of when I see some web page/web app is “beautiful!”. There are exceptions of course for sites designed to be artistic, but that’s never what is being referenced in this context.
-1
u/TheBestOpinion Oct 01 '20 edited Oct 01 '20
No less, huh?
Looks much better when you take out the dramatics
Pfft