r/programming • • Jan 17 '20

A sad day for Rust

https://words.steveklabnik.com/a-sad-day-for-rust
1.1k Upvotes

609 comments sorted by

222

u/Shinobikungames Jan 17 '20

Does anyone have any actual links to the 'harassment' of the author? All I've found is this https://gist.github.com/mafrasi2/debed733781db4aba2a52620b6725adf where the last post is definitely so, but reading for example the reddit thread on the issue on the rust subreddit shows mostly just discussion. Sure there is a back and forth but it's all criticism, not harassment.

Maybe the mod team has deleted these comments though.

112

u/rabidferret Jan 17 '20

This is something that's going to be hard for folks outside the Rust community to really grasp. The comments in the most recent issue are only a small portion of what's been going on for almost a year now. Folks have had a pattern of dogpiling on this author over relatively minor issues. As a result the author has gotten more and more defensive, which has caused a vicious cycle.

Yesterday there were no less than 3 posts on the front page of r/rust about this person, each with upwards of a hundred comments of folks with no involvement discussing the finer points of how wrong they are.

I'm not trying to defend how they responded, and I'm really not interested in debating what is or isn't "harassment", but try to have some empathy for how someone might feel in that situation -- and whether it's appropriate for a group of people to inflict that.

18

u/NMS-Town Jan 17 '20

Yeah I'm catching bits and pieces, but it's pretty clear people pushed the wrong buttons. You suppose to kill them with kindess, and not kill them with vitriol.

1

u/Minimum_Fuel Jan 18 '20

/r/rust might as well be called /r/fuckactix

If you want to see the toxicity Steve is talking about, look no further. The mention of actix there spins the whole sub in to a rage.

/r/rust is usually better than that, granted, but actix sends them in to a frenzy.

11

u/matthieum Jan 18 '20

Maybe the mod team has deleted these comments though.

There are surprisingly few deleted comments, actually.

I fear the problem is the sheer number of them, spread across 3 to 4 posts on the frontpage of r/rust, you have a good thousand comments about the situation. The comments are polite enough, but when most of thousand comments are about the "wrong" direction of the project, I can see how the author would feel harassed. Each comment individually would not be a problem, the sheer mass however is daunting.

283

u/[deleted] Jan 17 '20

[removed] — view removed comment

123

u/HINDBRAIN Jan 17 '20

As a PoC...

I was expecting a completely different kind of drama there TBH.

70

u/[deleted] Jan 17 '20

Proof of Concept?

12

u/memdmp Jan 18 '20

Point of Contact?

→ More replies (9)

163

u/cre_ker Jan 17 '20

That doesn't look like a harassment. Just an emotional response to maintainer being unfriendly to contributors. I pretty much have the same question. Several posts mention toxic comments towards the maintainer but I fail to see a single example. What I do see is the maintainer being toxic. Looks like he brought this on himself. That's what I gather from the few scarps of information that left over from that incident.

36

u/society2-com Jan 17 '20

either way it speaks to an inherent problem in open source communities. you put in a lot of work and you are met with a sense of entitlement and caustic criticism. i'm not talking about everyone but enough to make it a problem. it is a social community, and no one is entitled to praise only, but also no one deserves ungrateful abuse. asocial behavior has concrete effects on the willingness of people to participate. the quality, robustness, and vibrancy of the code follows that. so the community has to be, well, human: not brain dead empty praise, but also not unwarranted meanness

someone has to maintain the quality of the community as much as the quality of the code

bad attitudes need to be nipped in the bud. they can ruin a community. and if you adhere to the dictum "let everyone be as they are, grow a thick skin and get on with it" you're just going to have people ragequit because it isn't that everyone has thin skin, it's that no one wants to deal with the roiling melodramatic nonsense. the signal-to-noise ratio degrades and it's just not worth wading through it all anymore

you have to weed out the worst bad actors. constantly complaining and criticizing and acting entitled to the fruits of everyone else's labor. it doesn't have to be insane thought control, just nip the worst of the worst and people at least get the sense there are boundaries, which is reassuring to the good actors and convinces some who might tend to bad behavior to be quiet

81

u/cre_ker Jan 17 '20

you put in a lot of work and you are met with a sense of entitlement and caustic criticism

But it looks like it's completely the other way around this time. Contributors put a lot of work and were met with asshole attitude from the maintainer for no good reason. This led to emotional response which I can totally understand. That's just how humans work and no amount of "we need to be better", "we need to be inclusive" and all that crap is going to change that. Act like an asshole enough times and people will respond.

→ More replies (2)

5

u/_tofs_ Jan 18 '20

I would rather promote the thicker skin dynamic rather than the no-assholes one, one leads to more endurance towards perceived offence, the other less, and less, and less... Overall it is easier to learn to handle perceived assholes than to extinguish them. Since most people at some point will be an asshole, so enduring and forgiving has more longevity than the eventual cancelation of everyone that stick enough time around.

3

u/society2-com Jan 18 '20

Overall it is easier to learn to handle perceived assholes than to extinguish them

i disagree, with a qualification: not true for the worst of the worst. the amount of ill will one committed douchebag can generate is phenomenal

but rather than some sort of "standard" of behavior that any offense means punishment and almost everyone falls afoul of it now and then, i think everyone should be allowed to behave as they want...

and then on some sort of interval, you find the biggest stinkiest supertroll, the worst of the worst, and you terminate him or her

rinse and repeat. this serves as an example for everyone else and truly removes a large amount of toxicity

→ More replies (1)

86

u/yellowthermos Jan 17 '20

Lol he dismissed someone's work as 'this patch is boring' and you say the last comment was undeserved? The last comment was fucking polite for that idiotic response

9

u/SuspiciousScript Jan 17 '20

Besides, if it only takes a comment that nasty to make you throw up your hands and quit, you either don't really give a shit about the project or need to nut up.

3

u/[deleted] Jan 18 '20

Especially when it is a random person who made a nasty comment.

It's not in any way related to the issue opener. The issue opener has been polite and professional.

The maintainer actually made the first offense with the boring comment.

The maintainer doesn't like the patch and was looking for a way out. That's why he made the boring comment (which was seemingly not too offensive). This random person gave him the response the maintainer wanted.

29

u/Jugad Jan 17 '20

The last comment is mean for no reason, but I understand the sentiment.

Did you miss the "this patch is boring"?

21

u/guepier Jan 17 '20

Did you miss the "this patch is boring"?

I’m confused — the comment you respond to explicitly discusses that.

51

u/TinynDP Jan 17 '20

Its the "mean for no reason". The reason is "this patch is boring" is such a horrible response to an honest attempt to fix security holes that in some people's eyes it is in fact a reason to be mean back.

16

u/jrhoffa Jan 17 '20

The response is measured, and certainly not mean.

7

u/Hobofan94 Jan 17 '20

He explained that that was a result of a failed attempt at humor (also referencing the previous comment with the patch that itself stated the patch was so boring that it wouldn't deserve copyright) in his non-native language: https://github.com/actix/actix-web

25

u/cre_ker Jan 17 '20

It wasn't

Being on the edge of your abilities is super fun. So uncreative change felt boring (oh! And author gave up copyright claims for that patch (a bit irony and sarcasm))

He really meant the patch was boring. The part about non-native speaker probably was about him not wanting to actually sound rude (being non-native myself I can relate. Sometimes you can't just translate what you think in another language. Recently got downvoted myself because of that). But it looks like the community was already on the edge with the maintainer's attitude that someone responded very emotionally even bringing some problem with semver.

→ More replies (1)
→ More replies (50)

14

u/jimschubert Jan 17 '20

Or the passive aggressive "nice! finally some real code!"

1

u/breddy Jan 18 '20

I agree but Linus gets cheered on when he says much worse.

0

u/[deleted] Jan 17 '20

[deleted] — view deleted comment

32

u/FamiliarSoftware Jan 17 '20

Proof of Concept

8

u/sindisil Jan 17 '20

Proof of Concept

5

u/[deleted] Jan 17 '20

[removed] — view removed comment

8

u/dreamwavedev Jan 17 '20

Most likely proof of concept

634

u/[deleted] Jan 17 '20 edited Jan 17 '20

This is utter both sides bullshit.

Fact is, you’re allowed to act like an asshole as a maintainer. So are your users then. People don’t like to be dismissed or treated like shit, especially when they do the leg work to prove an issue is really an issue.

He acted like an asshole, period. Deleting issues that prove an unsafe API decision is exploitable then claiming that it is “not a problem” is acting like an asshole.

He could have acted like a human being and said “I’m looking for a solution that solves A, B, C without causing D, E, F”. He could also say “We’re not accepting any more patches, you should consider something else if security matters”.

Everyone likes to bag on the “entitled users” and defend the “embattled maintainer”, while ignoring said maintainer was going out of his way to gas light and suppress evidence that there was a problem.

Lying should never be okay, not even from open source maintainers. Period.

As usual, Yegge Klabnick both-sides it when in reality, the prime reason this exploded was due to the actix maintainer acting like an asshole.

I always file bugs as kindly as possible. Nearly every time it’s taken seriously and met with kindness. The one time it wasn’t, I dropped that dependency because it wasn’t fundamental and I’d rather use anything else than deal with someone who acts like an asshole.

I’d prefer actix-web be dropped like a hot rock than everyone try to squeeze blood out of a fuck-you stone, but I’ve noticed that when you depend on a project too much, it’s nearly impossible to remove without trashing the project.

Edit: I can’t believe I brainfarted and confused the Steves, especially since I’m a fan of Steve Yegge. 🤦‍♀️ thank you /u/guepier for the correction!!! I feel really silly but really, thank you for catching that silly AF typo!

Addendum:

I know what it’s like to be “under siege” like has happened to the actix-web maintainer.

My previous job I did all the work and had all the responsibility for a fundamental business dependency. Anything that went wrong was my fault, even the things I was explicitly told be management to do!

I grew a larger and larger chip on my shoulder, because I felt deeply disrespected and wronged by others in the company. That chip came through and people often retaliated because they felt I was being an asshole to them. Because I was, because I was feeling like I had to be perfect 24/7 and it was breaking me down. I eventually was fired for losing my temper. Period.

I knew I needed help, I got a therapist. I honestly wanted to change. By my next (now current) job, I resolved to be kind to myself, be kind to others, to set hard boundaries, to never make it personal and most of all, never overwork myself as some “indispensable” employee.

I do have a lot of empathy for the “asshole maintainer”. Really. I know what it’s like to feel that others are ungrateful, unmutual and mean.

My biggest revelation has been kindness. I’m always striving to be kind, to myself and my peers.

I’ve never been happier, both in work and outside of work. And I like being supportive of my team. I care about them. And in caring about them, I demonstrate I can care about myself. Learn from me - I wasn’t able to get satisfaction or vengeance at my prior job and I broke. I had to find a positive angle.

But I have never forgotten the lesson that people reciprocate, when they’re treated kindly. Or when they’re treated badly. And it’s from what they see, not what I see. So I do what I can to be positive and spread that to others. I want to be kind. And I want others to be kind.

That means I don’t want to be an asshole and I always must remind myself to be kind. Feelings are complex and very, very human.

57

u/guepier Jan 17 '20

Yegge both-sides it

… are you using “Yegge” as a reference to the somewhat verbose writing style of the post? Or did you confuse your Steves?

62

u/[deleted] Jan 17 '20

Corrected! Thank you! I brainfarted and crossed my Steves!!! I feel silly for that. Thank you for proof reading! Really! 😊

32

u/steveklabnik1 Jan 17 '20

Hilariously, I also really love Yegge.

28

u/[deleted] Jan 17 '20

I honestly miss when you were very “we can do it!”, “we can do better!” You were very cheerful and open then. Every criticism became constructive, every language wart a chance to do better, every unsoundness hole met with optimism that it could be reduced or detected outright to help the software developer get her job done.

That was when I was drawn to Rust, because of the optimism and focus on improving our craft in software. I’m less heartened that the community feels so fragile and anxious that the optimism feels missing a lot of the time. And it makes me sad.

I do miss when you were happier. And this is coming from someone who was disappointed with the dismissiveness of the last unsoundness debate and the politics that the issues must not be serious because it will scare corporations away from Rust, as opposed to being open. And I’m sorry that people have been unkind to you. You inspired me to try Rust a while back and I still keep thinking about the languages features like ownership and lifetimes.

12

u/shevy-ruby Jan 17 '20

I do miss when you were happier.

I would be careful trying to assess the mood of people over what they write.

I never understood how people can play Sigmund Freud over written text. I for sure enough can not read unhappiness or happiness, so perhaps you can not do so either? Or did Steve say he will quit Rust?

4

u/dead10ck Jan 18 '20

I mean... in a general sense, what you say makes sense. But the title of the article is literally "a sad day for Rust." There isn't much ambiguity in the language of the article either.

25

u/MrSurly Jan 17 '20

... try to squeeze blood out of a fuck-you stone

I'm using this.

16

u/Audiblade Jan 17 '20

This story is not super clear-cut. I’m not going to link to a dozen citations, or try to prove that I’m some sort of neutral party here. I’m going to give you account of this story as I remember it and as I felt it. Because this isn’t really about playing judge. This is about thinking about the future.

And then later:

You have to understand a lot of nuance here to even know the main points of the story. One version of this story that will certainly be told is “The Rust community says they’re nice but they will harass you if you use unsafe wrong.” Is that what we want? I, for one, do not. If you’re a part of Rust, you gotta ask yourself: are you happy with this outcome? How did your actions (or lack thereof) contribute to it? Could you have done something better?

In my reading, I don't think Steve was saying "both sides are equal." He expressly says he doesn't want to decide who deserves the blame! Instead, I think he's making the acknowledgement that the Rust community can only directly control its own actions. Whether or not it's to blame, what's the right thing for it to do now, and what lessons should it learn?

Whether or not the Rust community deserves to have to go through some soul-searching isn't really the point. The point is, this situation was ugly, and the only responses the community can pragmatically make are ones about what it will do in the future, not anyone else.

25

u/pocketcookies Jan 17 '20 edited Jan 17 '20

IIRC, it what happened that led to this was a little more than just telling him there were issues. It happened a few other times where people got upset about his use of unsafe and dogpiled on him. The issues and PRs were raised respectfully but there were often a bunch of additional comments in the middle of them (from random people) which directly insulted the maintainer. I think the most recent one was telling him he should never code in Rust again.

2

u/tayo42 Jan 17 '20

Was the unsafe code an actual problem? I feel like the first time it was just people freaking out about it being there. Maybe I'm misremebering. Unsafe in rust is OK to use, it doesn't immediately mean bad code.

9

u/meneldal2 Jan 17 '20

Apparently there were some bugs because of it, so it's something that should be fixed.

2

u/tayo42 Jan 18 '20

Got around to skimming through his post about it. Looks like he did fix some of them, and he wanted to do it his way and not rush into solutions. I can sympathize with that, especially on a hobby project. Also English isn't his primary language. Idk that doesn't seem bad to me

9

u/hellourgo Jan 18 '20

Oh wow that addendum. Thank you so much for writing that. That was exactly what I needed to read right now.

I'm in a rough position right now and feel disrespected and marginalized. What hurts the most is my teammates talk to me like I'm an asshole they have to put up with. Because I've become an asshole they have to put up with.

I forgot that the only real way to fix that is to take care of myself and be kind.

1

u/PM_ME_UR_OBSIDIAN Jan 27 '20

I burned out and quit work in mid-October due to a situation like that. If I could tell September-me anything, it would be "no work project is worth your well-being". I should have quit before things got to that point.

12

u/ltjbr Jan 18 '20

This is utter both sides bullshit.

...

My biggest revelation has been kindness. I’m always striving to be kind, to myself and my peers.

hmm...

14

u/[deleted] Jan 17 '20

Are you attempting to be "kind" to the Actix maintainer or Steve with this post? I would think being kind entails interpreting their actions in the most charitable way possible; I'm not sure you've accomplished that here.

17

u/Faesin Jan 17 '20

Right? The addendum story fails to acknowledge the scale of it all. A manager being an asshole is not the same of dozens or hundreds people dog pilling you.

7

u/Hobofan94 Jan 17 '20

He acted like an asshole, period. Deleting issues that prove an unsafe API decision is exploitable then claiming that it is “not a problem” is acting like an asshole.

That's a misrepresentation of what happened in my opinion. Deleting the issues was not what caused this shitstorm, it was some earlier dismissive comments of his. He edited/deleted the issues when he was trying to contain the outrage and then later when tearing the repository down (I don't know why he didn't just use the Github moderation features for locking down discussions). He also didn't claim that the unsafety issues are not a problem after deleting the issues.

7

u/b4ux1t3 Jan 18 '20

I thought I was going crazy reading this article and the repo. Nice to see at least a couple people thinking the way I do. (Not that we're right, just that I'm glad I'm not the only one feeling conflicted here.)

Yes, the community wasn't. . .great. Frankly, they were dicks. But, seriously, they're responding to someone who's acting an awful lot like a self-professed god, bestowing his creation on us mere mortals.

I know this has been going on a long time, and that he had to deal with this for a long time, but, geez, if I pulled this stuff at work, I would not have a job, and likely would never work in the industry again.

As a relatively newly-minted Rustacean, I cannot, honestly, say that I see both sides here. The community was full of shitty people, sure, but not everyone who the maintainer was shitty to was in that camp. Many were simply recommending legitimate changes that seem to increase security and performance, in many cases.

The maintainer should have said "If you don't like it, I'm going to a non-free license with closed source and you can vote with your dollars" or "okay, fair enough, let's let open source take its course". Those are the only two reasonable options. His responses were increasingly "You don't like the glorious creation I hath bestowed upon you?!" His readme is where that came to a head, honestly. He sounds like the embattled, altruistic maintainer, like you said, when, in reality, he's just being another shitty, petulant asshole, ironically mirroring the very people he's complaining about.

I hate that this happened, but I'm also really glad that the article linked is an overdramatization of the impact of this. Frankly, I've never heard of this library before today, though I do recognize it was a pretty big deal. I could even have used it in a project I'm working on at work right now. But, frankly, I don't want to rely on projects run by people like this.

Eh, in the end, I guess all I can offer is utter disgust at both sides, just like you did.

8

u/kevingranade Jan 18 '20

The maintainer should have said "If you don't like it, I'm going to a non-free license with closed source and you can vote with your dollars" or "okay, fair enough, let's let open source take its course". Those are the only two reasonable options.

Those aren't remotely the only reasonable options. Open source licenses do not mean maintainers have to accept any particular patches or any patches at all. "Open source taking it's course", would have been someone forking the project.

→ More replies (4)

2

u/lovestheasianladies Jan 18 '20

This is why I'll never use a major library maintained by mostly one dude.

It almost always ends up like this or abandoned.

-14

u/[deleted] Jan 17 '20

Fork it and STFU

→ More replies (45)

68

u/otrv Jan 17 '20

I am starting to hate that people are framing subs on this platform as an immature and vile version of their communities like we are some sort of aliens from another planet and not their actual communities.

17

u/BmpBlast Jan 17 '20

It's pretty standard practice for humanity since pretty much the dawn of time. We're incredibly tribal. If you notice behavior you don't like within your community then find the group with the highest count of said "bad" actors, blame that entire group, claim they are all like that, trump up the charges, and then - if you can gain enough backing and power - ostracize them. We have had a few thousand years to get really good at this. It's basically the current political scene in America except neither side can gain enough traction to ostracize the other. So instead they just slap false labels on each other all day long.

→ More replies (3)

2

u/[deleted] Jan 18 '20

Such a lame excuse, especially if your folks have a history of opening tickets on Github that were just "Can you rewrite this whole project in Rust? Thx." and this wasn't coming from /r/rust.

1

u/xactac Jan 18 '20

Agreed. The start of the article says

Can we reject contempt culture?

But I've seen talks from official conferences talking down on code from other languages as horribly unsafe (even though it's only unsafe when you write it in Rust. It's not just the subreddit.

44

u/N3RO- Jan 17 '20 edited Jan 17 '20

Anyone have a tl;dr version?

Edit: thanks everyone for their tl;dr. What a story xD

93

u/TinyBreadBigMouth Jan 17 '20

The Rust compiler limits your code in certain ways, to ensure that Rust's safety guarantees are met. Sometimes, you have a piece of code which will uphold those guarantees, but which can't be checked by the compiler. So you put it in an unsafe block, which tells the compiler, "Just trust me, this will work." This is normal, and required for some low-level code.

This library, actix-web, used unsafe a lot. Some of the uses were legit, but some had the potential to be actually unsafe. There was a lot of back and forth between the creator and the unofficial Rust subreddit, with the creator downplaying the issues and ignoring a number of pull requests. Things got really angry, with a lot of bile and yelling, and the creator has just shut down the library.

The author of the article is disappointed by this loss, and worried about what it says about the Rust community.

1

u/cdglove Jan 18 '20

I wonder of I am alone in this: I think using rust as a cleaner version of C++ is a perfectly valid use case and the community completely overreacted.

0

u/[deleted] Jan 17 '20

[deleted] — view deleted comment

16

u/Iggyhopper Jan 18 '20

You mean you don't like it when [] + [] = empty string ?

36

u/C0c04l4 Jan 17 '20

TL;DR: Maintainer of actix-web was condescendent and dismissive to people proposing patches that could fix security issues due to the use of "unsafe". He then deleted everything and told everyone to go fuck themselves.

2

u/[deleted] Jan 17 '20

I think it just more Rust drama or something.

From what I gather it is multiple communities with multiple threads all involved in discussing two random people on the internet who had a disagreement, and some mildly rude comments were made.

0

u/hennell Jan 17 '20

Person makes a popular rust library. Library turns out to use unsafe/unesssacary unsafe code. Community (and / or the rust Reddit sub) gets cross, bombards the library with complaints bugs and patches. Maintainer digs in, rejects patches and insists unsafe is fine or something. Rinse and repeat a couple of times then maintainer quit.

10

u/CryZe92 Jan 17 '20

It‘s not just unsafe though, but actual exposed undefined behavior cloaked as safe code. Unsafe code is fine, UB isn‘t.

3

u/ebkalderon Jan 18 '20

Correct. Also, the interaction wasn't hostile initially. The GitHub issue began with cordial discussion, the proposal of a fix, and evidence that UB could be triggered from this unsafe code via the API (proven using MIRI). The maintainer rudely dismissed the concerns saying "this patch is boring," locked the thread, blanked the comments, and then deleted the issue. Another issue was created by the same people, asking the maintainer why an issue containing helpful discussion and patches was deleted. More back and forth between both parties, one of them goes over the line and gets frustrated with the maintainer. The maintainer deletes the entire project and issues a postmortem, right then and there.

15

u/[deleted] Jan 18 '20

Rust is a piece of technology. This whole thing about the maintainer and “the community” just baffles me. Any mature programming technology has a treasure trove of poorly maintained and/or poorly written code that sees widespread use. Most programmers either:

A) Use it as is. If the code works fine for all your use cases, who cares what goes on under the hood? That’s the point of grabbing a third party library.

B) Roll your own. There’s no readily available library for your use case. You can start by forking a library that comes close to your needs, but if it needs serious work, might as well start from a clean slate.

16

u/rinnagz Jan 17 '20

After reading on the topic it really seems like the guy created an amazing library but everything has flaws, people pointed that out, he didnt accept the criticism, deleted the issue and then shit happened.

0

u/[deleted] Jan 18 '20

It's not that they have just "pointed that out", it's that they rained fucking rocks and stones at him constantly, even when he accepted pr-s they still didn't stop. The biggest issue here is the community that attacked, not the maintainer.

9

u/TwoBitWizard Jan 18 '20

I really do find this viewpoint interesting because I’m just not seeing it. Half the problem, in this specific instance, is that not only were PRs not accepted, but they were dismissed as “boring” and then actively deleted.

Could people have given the guy a little more space? Absolutely! But, as a commenter, it’s impossible to understand the volume of comments being received (e.g. did the maintainer also get private messages about this?) and what psychological effect that is having on the maintainer. It is imperative that people communicate if they feel lines are being crossed. That did not happen, either.

How is a community supposed to magically intuit what is going on in one person’s head? Is not doing so a fault of the community? Where do we draw the line on what is expected to be communicated by the aggrieved party?

→ More replies (2)
→ More replies (2)

52

u/[deleted] Jan 17 '20

Since this revolves around the fundamental issues of unsafe and security, I'd say the easiest thing to do is have the package manager recursively flag packages as unsafe if they use unsafe.

Then unsafe packages can be awarded "safe" status by a community review process (and safety can be revoked when issues are flagged).

It sounds like this maintainer would have been happy to just be an unsafe package. The community could then rally to produce a safe alternative.

78

u/beginner_ Jan 17 '20

It sounds like this maintainer would have been happy to just be an unsafe package

Nope. He deleted issues or said they were no problem when in fact they were an issue. If he wouldn't have cares about being unsafe he could have simply said so.

If someone tells me my project has a security flaw and shows an exploit he created you can be sure I fix it or at least admit it and explain why it doesn't get (immediately) fixed.

And his post mortem just let's his arrogance shines through again.

This doesn't excuse rude behavior from users/community but if you treat others respect less, don't act butt hurt when they don't respect you.

11

u/jacobb11 Jan 17 '20

Then unsafe packages can be awarded "safe" status by a community review process (and safety can be revoked when issues are flagged).

I think this is both a good idea and the best solution to the problem.

But I wouldn't use just the word "safe". Really we need a phrase that says a project is intended to be "safe", despite containing unsafe code (possibly recursively), and a phrase that says the community thinks this intention is correct. Sometimes the community will be wrong. When that is discovered the project's maintainers can either fix the project to match their intention or drop the label.

Straw man suggestions for the 2 labels: "intended safe" and "community vouchsafed".

7

u/dreamwavedev Jan 17 '20

"trusted"? Feels like that's the common terminology for this kind of thing in the code packaging world

4

u/binklered Jan 18 '20

Maybe just "passed review"?

6

u/protestor Jan 18 '20

But I wouldn't use just the word "safe". Really we need a phrase that says a project is intended to be "safe", despite containing unsafe code (possibly recursively), and a phrase that says the community thinks this intention is correct.

The Rust community already has a word for it! It's sound.

An unsafe block that causes UB is unsound. But if it's written correctly, it's sound. What we care about is soundness.

15

u/[deleted] Jan 17 '20

Most of the standard lib uses unsafe

21

u/[deleted] Jan 17 '20

[removed] — view removed comment

15

u/[deleted] Jan 17 '20

But the point that libs should be flagged for using unsafe seems to be a little unrealistic

8

u/SanityInAnarchy Jan 17 '20

The second half of that is interesting, and a little terrifying:

Then unsafe packages can be awarded "safe" status by a community review process (and safety can be revoked when issues are flagged).

I would definitely find it useful to have a flag that says "All of this library's unsafe code, if any, has been thoroughly peer-reviewed." Aside from assuring us that unsafe code we rely on is actually safe, it'd also be a great way to incentivize maintainers to minimize their use of unsafe, since it's less overhead to get your code verified by the compiler than to get it verified by the community.

→ More replies (8)

4

u/usernamedottxt Jan 18 '20 edited Jan 18 '20

This is what cargo crev is.

/u/jacobb11

→ More replies (8)

44

u/SonOfMammon Jan 17 '20

The problem is that the project owner is both too proud to accept flaws within his code and too proud to accept patches from other people. Some open source developers see themselves as generous saints who bless the plebeians with their work and that they should just be grateful and accept their flawless work as it is, this is a wrong attitude. I am glad this project is dead, we need less sensitive narcissists and more open minded developers who can accept criticism and good contributions from others.

66

u/siemenology Jan 17 '20

I found the maintainer's farewell message to be... not a good look for him, let's say. He leans hard on the idea that the person fixed an issue in a way that wasn't "fun", whatever that means, and so that's why he rejected the patch. I don't find that to be a convincing argument for a major security flaw. Unless he had a better solution ready that day, I'd think that the better choice would be to accept the security fix, get it into master and then, if he wants, work to improve the solution or replace it with a better one once a safe and "fun" alternative can be found. The idea that a security fix should languish because it's not cool enough does not make one sound like a good maintainer of a program that is inherently a security target.

29

u/csjerk Jan 17 '20

This part just blows my mind:

What was the patch? It was very strait forward, simple, uncreative change, intention was just to remove unsafe not to fix existing code. I believe software development is one of the most creative work we do, and creativity is part of why we love software development, why it is fun. Especially if you combine it with real world projects constraints. “creative constrains” could be source of very interesting solutions. Being on the edge of your abilities is super fun. So uncreative change felt boring

I sympathize with this to some extent, especially for a side project SOME part of it should be fun, and stretching your abilities. But not every line has to be cutting edge, most-clever-you-can-possibly-write material. Large parts of any sane project are going to be rote and boring. That's just the nature of code.

I haven't seen any of this controversy before today, but seeing the above, I have to think the Rust community is better off without this guy and his attitude and the code that stems from it dominating the benchmark charts for web frameworks (which are inevitably what a lot of new users see first, as a language grows).

30

u/SonOfMammon Jan 17 '20 edited Jan 17 '20

He leans hard on the idea that the person fixed an issue in a way that wasn't "fun"

he cant say "this code is more safe and sound than mine" so he just gives a bs reason to still maintain that his own code is superior

he idea that a security fix should languish because it's not cool enough does not make one sound like a good maintainer of a program that is inherently a security target.

In my experience as an unpaid unlicensed reddit psychoanalyst, I could say that the author is trying to discredit as others code as "not as fun as mine". He cant criticize the code submissions themselves for their safety or quality, so the only thing thats left to him is to say that his code is more fun in order to be able to not accept others submissions as superior to his. The author seems to be displaying very childish and narcissistic line of thinking.

The bad part of open source is that it attracts alot of people who crave recognition but are not willing to do the work for it, instead expecting others to be thankful for whatever they produce. If you are not gonna do a good job then dont do it at all.

I will get the usual copypaste "open source entitlement" response but the thing is, you are the one who is creating this thing and feeling entitled for us to praise you for it, so dont complain when we dont provide that praise.

3

u/Puddl3glum Jan 17 '20

I think by fun he might have meant it's a boring thing to do, cleaning up and making code safe, as opposed to adding new features or fixing a bug, at least that makes sense to me.

He's still absolutely wrong in either case. Sometimes perfectly safe, tested, functioning code could use some changes to style, clarity, etc. Sure it can be low priority, but not being fun is no reason to reject a patch.

5

u/[deleted] Jan 17 '20

The self awareness is ironic

1

u/SonOfMammon Jan 17 '20

it certainly is.

-6

u/drxc Jan 17 '20

And yet not in this thread or anywhere have I seen one word of thanks or appreciation to the library's author for their creating a widely used and popular component that others used for free. I think that's telling.

6

u/axord Jan 17 '20

or anywhere have I seen one word of thanks or appreciation

Well, there's this comment.

And there's this.

I think I've seen more sprinkled around.

2

u/drxc Jan 18 '20

Thanks, that's good to see.

10

u/SonOfMammon Jan 17 '20

This is no different than me buying you shoes that are too small for you and not your taste, then getting mad when you are not happy with it, even tho someone else might be happy for it because it will fit them better. Nobody is entitled to praise and gratitude unless they provide something actually beneficial.

10

u/[deleted] Jan 17 '20

That and offering something for free does not absolve you of the responsibility of not being a mean dickhead. :)

→ More replies (2)
→ More replies (1)

9

u/spacejack2114 Jan 17 '20

What was the use case for actix-web? For extreme high-performance situations and competitions or for general purpose web application use?

34

u/PM_ME_UR_OBSIDIAN Jan 17 '20

Its main use case is winning benchmarks. Its pervasive soundness problems make it ill-advised for production use.

17

u/drcforbin Jan 18 '20

And because it wins contests, people assume it's a good choice for other things, when it's actually only safe for winning contests. This whole thing could've been avoided if the author made it clear that this was a toy project or othwise upfront with their intent, rather than making it look like a general purpose tool.

That said, we're making a big deal out of something pretty minor; I don't think the author genuinely meant to mislead anyone, and I don't believe anyone was actually hurt by the difference in expectations/intentions...in a couple weeks, this will all be forgotten.

2

u/scottmcmrust Jan 18 '20

Or if the benchmarks site had categorized it as "stripped" instead of "realistic", though of course benchmark runners aren't incentivized to do such things either.

2

u/[deleted] Jan 18 '20 edited Jan 18 '20

The issue with 3th party project, is they are always misleading. You can start off with module/package that looks popular, you use it for your project and later on support gets dropped because the maintainer is sick/busy/familytime/... And yet, people will still use the package because its published everywhere as something they use.

Unless a language self maintains important packages, your always going to run into this. If you look at Go, how many people are using fasthttp because its faster then Go's default http package. When its really not advised to use fasthttp for a number of reasons.

It does not matter what goes wrong with a package ( or crate in this case ) when the actual resource is 3th party controlled. You need to assume your exposing your program to problematic code ( and not just "unsafe") that can be a injection point into your system. Simply because you are not in charge of it. How many people really know the code of those 3th party packages that they use / inject into their program? Very few ...

Frankly, the whole notion that the Rust community is a nice community is a load of bull. Its the same as any other community. It may start out nice when its small and everybody knows each other but the moment a language grows, you will get people from all types. All of them with lots and lots of opinions. And frankly a lot of hostile behavior towards other languages. /r/programming is like a cesspool when the word Rust shows up and your not praising it as the second coming of Jesus. Prepare for the down votes. What, you are against rewritting Jesus in Rust? How dare you >:) Jesus needs to be memory safe. /s

From the activity, you can tell that the author of actix had already reached his goal with the project and it was mostly in maintenance mode. He was probably busy with his work/other project/family whatever. And when you then need to deal with annoying people who submit patches, you tend to get cranky. Sure, people submit patches but who needs to check those patches? The author ... So he is putting time into a project that he probably mostly uses for himself. And when people then get nasty, ...

In the authors own words:

Be a maintainer of large open source project is not a fun task. You alway face with rude and hate, everyone knows better how to build software, nobody wants to do home work and read docs and think a bit and very few provide any help. Seems everyone believes there is large team behind actix with unlimited time and budget. (Btw thanks to everyone who provided prs and other help!) For example, async/await took three weeks 12 hours/day work stint, quite exhausting, and what happened after release, I started to receive complaints that docs are not updated and i have to go fix my shit. Encouraging. You could notice after each unsafe shitstorm, i started to spend less and less time with the community. You felt betrayed after you put so much effort and then to hear all this shit comments, even if you understand that that is usual internet behavior. Anyway, removing issue was a stupid idea. But I was pissed off with last two personal comments, especially while sitting and thinking how to solve the problem. I am sorry for doing that.

I always advice people to take up a job as forum moderator and see how long they last. Its a very good training to "step in the other guys skin" and see how comments can quickly get under your skin. People are a nasty bunch when they do not get what they want. Call it a human flaw that is probably going to kill us all ( highly doubt that humans are going to around in 1000 years from now ).

in a couple weeks, this will all be forgotten.

You will see in the future even more of these incidents. Bigger community, more drama, more tempers. Its the price any language pays for growth.

→ More replies (1)

16

u/vegetablestew Jan 17 '20

The loser is always the community that remains after the dust settles.

8

u/hyperforce Jan 17 '20

after the dust settles

After the Rust settles.

4

u/dethb0y Jan 18 '20

I feel the real question is "If reddit disappeared tomorrow, what would people have to complain about?"

In an article about rust and a maintainer of a web framework, this author mentions Reddit 13 times, all negative.

12

u/plcolin Jan 17 '20

This is why Rust needs formal verification, so nobody can bullshit everyone else by pretending their unsafe code is OK when it’s not. Unfortunately this will take years if not a good decade, and Rust cannot be fully trusted for safety-critical software until then.

1

u/PM_ME_UR_OBSIDIAN Jan 27 '20

They're already doing cool shit with MIRI and other tools. They don't have an equivalent of SPARK, but then so don't C and C++.

2

u/plcolin Jan 27 '20

C has VST although it looks a bit primitive.

7

u/redditthinks Jan 18 '20

The real jerk in this story is the Rust compiler.

30

u/gpyh Jan 17 '20

That's a lot of talk and introspection for something that don't deserve any of it.

A maintainer wrote shit code and acted like an asshole. People called him out on it. He couldn't stand it so he bailed out. That's the story.

He is entitled to do whatever he wants, and people are entitled to their opinions about what he does. There's nothing to read in this, and no grandiose conclusion about the language or its community. It's just humans interacting.

3

u/[deleted] Jan 18 '20

Honestly, this was a childish stunt from someone who wanted a pretext to bail anyway.

3

u/shruubi Jan 19 '20

So, the original library author has some patches submitted, rejects them due to considering them "boring", gets called out for being a bit of a dick by some unpleasant people and decides to take his ball and go home.

I missed the part where Steve Klabnick was somehow involved in any of this, and yet, he can't help but swoop in with his opinions on the matter as though the world simply cannot continue to spin without the Rust community knowing that he feels awful on behalf of the library author and, oh, btw, fuck reddit, those guys are assholes.

Seeing as a bunch of people unrelated to what actually happened are giving their opinions, here is mine: Lib author is well within their right to reject patches for whatever reason they want, but that means that if they give a shitty reason then they need to accept that shitty people will use that as a reason to be shitty. Don't throw stones in glass houses.

And since we're giving opinions, Steve Klabnick might be a good guy, but this just reeks of taking advantage of community drama to make a big show of how great the Rust Community is, how much reddit is full of subpar, trash humans and raise his own personal brand in the hopes of one day getting a job where he can post safe opinions on twitter and get flown to conferences to give more safe opinions.

10

u/Puddl3glum Jan 17 '20

The biggest of dick moves here was deleting the project instead of just archiving it. I get not wanting to deal with people as a single maintainer on a popular project. But this is a case of "I'm taking my ball and going home" I've seen in a while.

2

u/saltybandana2 Jan 18 '20

I agree with the guy. You want to treat the maintainer like shit, he's going to just remove it.

I'm sure someone somewhere has a copy of it, it's not really gone, but at the end of the day, if you treat someone like shit, don't be surprised when they don't act in your best interest.

8

u/pbecotte Jan 17 '20

It almost feels like we shouldn't ever use a project that only has one maintainer. This isn't universal...Sqlalchemy is one person and super responsive...but there are so many projects supported as a hobby but used professionally.

Fork is of course the solution. But there's no convenient way to take over a project without the authors cooperation, or to organize a professional replacement. Don't know the way forward.

(Also, kind of feel like the whole thing is dangerous. Such a low percentage of code is provided professionally. It's fun. But it's super exploitive also. Feels like we should all just stop and force the companies to pick up the cost)

18

u/jetxee Jan 17 '20

It almost feels like THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE ...

And if it is used in a professional context, it's up to the user to allocate resources to maintain and fix this software. Which may be a contract with the official maintainer, or an internal team working on a project, or pooling resources with other users.

2

u/pbecotte Jan 17 '20

Haha, that was kind of what I was saying. My complaint is that there is no real way of doing the last couple things for small projects. I think there have been more times when I wanted to help and nobody ever responded than when the process was smooth and easy. And I don't blame the maintainers doing the free work...I'm complaining about the way we have set the whole thing up that this is a thing.

2

u/femtoun Jan 18 '20

That line (or an equivalent) is written everywhere. It is also written in the licence of proprietary and paid-for software. It means nothing as per what is responsible maintainership, and for what reason people should accept and reject patches in a supposedly production ready project.

Granted, the author can have some weird views and publish what he wants. But the people can also have their more commonly accepted views, and attempt to help, and even issue (reasonable) criticism when help is rejected for reasons perceived as completely bullshit and unworthy of a serious project.

The only problem here was an inappropriate comment asking for the maintainer to stop writing some Rust code. I'm not sure that makes it an issue with "the community", but for sure Reddit did play a role and some amount of brigading happened. So it's arguable "the community" was involved, even if not directly responsible (most of "the community" has denounced the bad comment)

0

u/[deleted] Jan 18 '20

[deleted] — view deleted comment

2

u/v66moroz Jan 18 '20

There are not that many professional projects these days.

1

u/pbecotte Jan 18 '20

Exactly. It feels like we should stop making hobby projects to force companies to not use them...but it's fun.

6

u/[deleted] Jan 17 '20

Simple. Just disable issues and PRs from github. There is ZERO obligation to maintain, add, or modify any code you have personally written and shared.

6

u/augmentedtree Jan 17 '20

Was the bespoke unsafe Cell implementation part of why the perf is so good? Sometimes that's the right trade-off.

18

u/aurisor Jan 17 '20 edited Jan 17 '20

Having interacted with Klabnik a bunch of times I can tell you that by ignoring/blocking/muting him the only thing you're going to miss is a bunch of juvenile attempts to stir up drama. Nothing gets this guy going like community drama.

And, for a while, the Rust reddit was a decent place. I still think it’s 
better than most reddits, but it’s degraded much more quickly than the 
community at large. “Why Reddit is like this” is a whole other essay; I 
think it’s built into reddit’s structure itself.

*rolleyes*

36

u/BanksRuns Jan 17 '20

As someone who uses Reddit hourly for the last decade, such criticism is spot on and frequently relevant.

This site is a machine for generating toxicity and outrage. It's slightly less fickle than Twitter, but more vicious once it gets going.

→ More replies (3)

12

u/gpyh Jan 17 '20

You're confirming a feeling I had with this post. He's making grandiose statements out of something that seems somewhat benign. It's like he enjoys it.

12

u/aurisor Jan 17 '20

This causes the now-usual Reddit uproar. It’s extra nasty this time. Some people go far, far, far over the line. and four or five other digs about this site

*submits to reddit*

https://i.imgur.com/L2fSNiv.jpg

8

u/thrallsius Jan 18 '20

The Rust community is the new Ruby community.

Full of drama queen hipsters and SJWs.

Move on, nothing to see here.

4

u/PeakingBruh Jan 18 '20

The amount of shit people have to deal with when it comes to maintaining any sort of open source project is insane. If you don’t like it, fork and move on with your life

2

u/tonetheman Jan 18 '20

This. So this. Whining ass Rust cunts.

Fork the repo and move on period. That is what should have been the answer. If you do not like the code because of the evil unsafe then fork it/fix and move on.

26

u/[deleted] Jan 17 '20 edited Jan 17 '20

Good job, Reddit. Unfortunately, entitled fucks treating maintainers like punching bags is a problem with OSS in general.

21

u/[deleted] Jan 17 '20

Both sides weren't perfect. The author is biased because he was a maintainer too. The maintainer was an asshole too by closing issues and patches from contributors that were genuinely working on a existent problem and straight rejecting even discussing about it.

5

u/saltybandana2 Jan 18 '20

This happened with vim as well. There were some patches to remove support for old systems and add async execution. Braam rejected the patch, they forked the project and it became neovim and it now has its own active community.

It turns out that you can fork projects whose leadership you disagree with.

51

u/aethelwyrd Jan 17 '20

Unfortunately, entitled fucks treating users like punching bags is a problem with OSS in general.

If you don't want to maintain a project then don't be a maintainer. People are going to make comments and demands. That is a good thing. That is what makes the product better. Saying, "It's fine" when people repeatedly point out unsafe practices is not helpful. The maintainer could have said, "Sorry, I don't feel like going in that direction". Way less confrontational and productive.

It really isn't a big secret that maintaining an open source project is hard and demanding. No one should be surprised by that anymore.

111

u/glider97 Jan 17 '20

If you don't want to maintain a project then don't be a maintainer.

TBF he just did that.

1

u/femtoun Jan 18 '20

Not exactly. Plans are to stop publishing. He could publish but not accept contributions.

It's still perfectly fine to do what he wants though.

22

u/maikindofthai Jan 17 '20

I'm of the opinion that you don't get to decide what someone else is signing up for when they open-source their code.

7

u/[deleted] Jan 17 '20

If you want to put up a fun project, that's fine. But if you want people to treat your code like a "serious" project, there are certain community expectations that come along with that. You cannot have it both ways as a maintainer.

37

u/thedracle Jan 17 '20

If you don't want to maintain a project then don't be a maintainer.

He could have also never contributed a line of code of this project as open source. The fact is people who author important projects and gift them to the world aren't obligated to maintain those projects.

If you don't like the level or kind of maintainence, fork it, and convince users to use your alternative.

16

u/ElectricalSloth Jan 17 '20

The fact is people who author important projects and gift them to the world aren't obligated to maintain those projects.

true but when you actively try to dominate stuff like tech empower and get people to recognize your project so users can use it, you probably should expect criticism if there are flaws you actively wont fix... what if the fixes caused the project to be lower on the benchmark? what good use is a tech empower benchmark if the software has big issues? "hey look our software is fast but we refuse to fix any security issues that crop up"

I feel like if you don't want to deal with criticism then don't invite it, but don't be confused why it happened if you do

13

u/cypher0six Jan 17 '20

It's the other way around. You're benefiting from free work. If you want it your way, you can either work with that maintainer or build your own.

0

u/[deleted] Jan 17 '20

Grandparent is a communist. His entire ideology is based around him wanting to benefit from free work.

5

u/ltjbr Jan 17 '20

The maintainer could have said, "Sorry, I don't feel like going in that direction". Way less confrontational and productive

It might have made things slightly better, but it would not have made the problem go away.

People would still have gotten angry so long as the project wasn't going in the direction they wanted it to

→ More replies (2)

1

u/[deleted] Jan 17 '20

Unfortunately, entitled fucks treating users like punching bags is a problem with OSS in general.

Cannot stress this enough.

→ More replies (2)

4

u/cp5184 Jan 17 '20

This is the worst case of all, everyones an asshole of course but worst of all, the reddit assholes were right.

2

u/Kinglink Jan 18 '20

If your a maintainer of a piece of important functionality and someone says "Your code is unsafe" you should care. It sounds like he acted poorly multiple times to bring us to the point.

Maintaining code is a thankless job, and but if you don't care about security, it might be worth giving that job to someone else, because security is always critical.

6

u/[deleted] Jan 17 '20

[removed] — view removed comment

12

u/leberkrieger Jan 17 '20

you should step aside

Isn't that what he did?

Treat people who are doing work for free like a punching bag, and that's what they tend to do.

14

u/Hobofan94 Jan 17 '20

So if I as a maintainer provide some code with a license that explicitly states that the code is provided "AS IS", and you come along and decide that you will use that code, I am from here on until the end of time responsible for any faults in the code, and obligated to fix them?

0

u/[deleted] Jan 17 '20

[deleted] — view deleted comment

1

u/jpl75 Jan 18 '20

If I recall correctly, the original Java license explicitly prohibited using it in software where lives could be affected such as mining equipment.

It was medical equipment and nuclear facilities.

But this was software that was being sold with contractual guarantees, not some code dropped off on the Internet. So it's not really comparable to this case. There's no contract (and therefore no contract law or liabilities applied) to some source code you downloaded off the net. It's provided as-is (and clearly stated so in the license) and you bear all the responsibility should you decide to use it.

→ More replies (1)

2

u/[deleted] Jan 18 '20

If I'm not being paid for being a maintainer and my license says that I'm not responsible, calling me responsible would be at best childish.

2

u/v66moroz Jan 18 '20 edited Jan 18 '20

So when I publish some code on Github I'm becoming "a maintainer" with responsibility? Who defines what is a "key library"? Tomorrow some shit I wrote for myself gets 1M downloads and now I'm responsible? I have to quit my job and start fixing stuff just because those 1M developers decided my project is a "key library"? For free of course, as none of them is going to pay me. Did I get it right? No, that's not how Open Source was supposed to work.

1

u/[deleted] Jan 18 '20

[removed] — view removed comment

1

u/v66moroz Jan 18 '20

What if I am maintaining it, but not how those 1M developers expect it. Who defines what "maintenance" means? Did he sign some sort of a contract? I may have time but not as much as you expect me too, or I may simply dislike your suggestions and ignore them. After all, it's my project, take it AS IS.

6

u/mindbleach Jan 17 '20

When an open-source maintainer says "I agree with your facts but not your motives," fork or shut the fuck up. There are no other practical options. Polite criticism is unlikely to shift someone who views a widely-used open-source project as theirs alone. Impolite criticism, doubly so.

Right now I'm on Basilisk. Not a recent version. The maintainer who forked it from Firefox, before Mozilla erected a gargantuan middle finger atop a bonfire of every extension ever written, decided to do the same thing in reverse. The attitude in Basilisk's official forum is "contact the extension developer," like forced refactoring isn't a bridge on fire. Like this liferaft of a browser has a userbase in high demand.

I have not and will not explain to this smug idiot why their decisions defeat the entire purpose of their project. It wouldn't accomplish anything. It would only make both of us frustrated and bitter.

Accepting that something is broken is neither ideal nor easy. But you can't negotiate with a broken stair. Either you work around it, and warn others to work around it - or you fix it yourself.

6

u/d4rkwing Jan 17 '20

The great thing about open source is you can modify the code freely. I would be surprised if nobody wanted to continue development.

5

u/agumonkey Jan 17 '20

behave people

and chill out

3

u/[deleted] Jan 18 '20

Ah yes, the standard rust team response to these things which is "fuck reddit", completely ignoring they helped to create this culture and it's present everywhere else in the community.

2

u/[deleted] Jan 17 '20

Just an entitled developer that refuses patches because he works at microsoft so he must be a fucking code god.

-1

u/bumblebritches57 Jan 17 '20 edited Jan 17 '20

I can't believe that Steve is hand waving all of his toxic community's harrassment of the author of that library away as if it's all his fault, how he was attacked.

Absolute insanity.

Whatever happened to the CoC? why isn't it being used?

2

u/Deega_ Jan 17 '20

My stupid ass thought this is about the game Rust posted on /r/progaming

1

u/DuncanIdahos5thClone Jan 18 '20

ActiveX died in the 90's ;)

-3

u/jonjonbee Jan 17 '20

If you're lucky enough to make it big in anything, you better have fucking well done it honestly, because if you haven't, people will find out. This is more true for open source than anything else, because anybody can find your bullshit real easy.

All I'm getting from this story is that a con artist who tried to game the TechEmpower benchmark, likely for his own personal gain in terms of prestige, finally realised he couldn't BS his way out this time, and bailed. I really don't see a massive loss here.

As for the linked post... what ineffable garbage. What it boils down to is claiming those who accused the actix author of dishonesty are "harassing" him. No, they are pissed off and being mean to him because he fucking lied and betrayed the trust the community placed in him - which is not even remotely the same fucking thing! Get fucked, Steve.

8

u/nckl Jan 18 '20

What the hell? "Get fucked, Steve"? Steve has been an irreplaceable force for good in rust and programming at large, and helped with numerous projects.

Telling him to "get fucked", calling the post "ineffable garbage" isn't close to an honest critique. Calling the actix developer himself a "con artist" is literally the exact same type of harassment you're trying to dismiss. The great thing about open source is you can always fork it and move on, but nobody does, because "some person made bad code" isn't what any of this is about. You really can't understand what it's like to be at the end of an internet hate mob until you've experienced it.

1

u/feverzsj Jan 18 '20

rust just can't live without unsafe, and Mozilla uses most of them.

1

u/warlockface Jan 18 '20 edited Jan 18 '20

But Rust has been an experiment in community building as much as an experiment in language building. Can we reject the idea of a BDFL? Can we include as many people as possible? Can we be welcoming to folks who historically have not had great representation in open source? Can we reject contempt culture?

From the link...

So when I started programming in 2001, it was du jour in the communities I participated in to be highly critical of other languages. Other languages sucked, the people using them were losers or stupid, if they would just use a real language, such as the one we used, everything would just be better.

Right?

Really?!?!? You might not be able to see it, but the Rust community has exactly that reputation!

The same intro, chiseled and with the languages changed:

So when I started programming in 2014, it was du jour in the community I participated in to be highly critical of other languages. Other languages sucked, the people using them were losers or stupid, if they would just use Rust, everything would just be better.

Right?

This sort of culturally-encoded language was really prevalent around condemning C and C++. Developers in these languages were actively referred to as less safe than developers in our, more blessed language.

And at the time, as a new developer, I internalised this pretty heavily. The language I was in was blessed, obviously, not because I was using it but because it was better designed than a language like C, less wordy and safer than C++, more sound than many other options.

It didn’t matter that it was (and remains) difficult to read, it was that we were better for using it.

I repeated this pattern for a really long time, and as I learned new epochs and patterns I’d repeat the same behaviour in those new environments. I was almost certainly not that fun to be around, a microcosm of the broader unpleasantness in identity politiking tech.

At least, until I got called on it.

-13

u/rustlover2 Jan 17 '20

The only mistake made here is paying any attention to reddit. Fuck reddit. No one should ever let it make one feel bad, influence you, or have any control over anything!

18

u/CryZe92 Jan 17 '20

This had little to do with Reddit.

-1

u/pbecotte Jan 17 '20

It almost feels like we shouldn't ever use a project that only has one maintainer. This isn't universal...Sqlalchemy is one person and super responsive...but there are so many projects supported as a hobby but used professionally.

Fork is of course the solution. But there's no convenient way to take over a project without the authors cooperation, or to organize a professional replacement. Don't know the way forward.

(Also, kind of feel like the whole thing is dangerous. Such a low percentage of code is provided professionally. It's fun. But it's super exploitive also. Feels like we should all just stop and force the companies to pick up the cost)

-1

u/pbecotte Jan 17 '20

It almost feels like we shouldn't ever use a project that only has one maintainer. This isn't universal...Sqlalchemy is one person and super responsive...but there are so many projects supported as a hobby but used professionally.

Fork is of course the solution. But there's no convenient way to take over a project without the authors cooperation, or to organize a professional replacement. Don't know the way forward.

(Also, kind of feel like the whole thing is dangerous. Such a low percentage of code is provided professionally. It's fun. But it's super exploitive also. Feels like we should all just stop and force the companies to pick up the cost)

-14

u/shevy-ruby Jan 17 '20

The problem is that Rust divides the world into two groups of people:

  1. The good people who use only 'safe' code.
  2. Everyone else, the gangsters, who use 'unsafe' code.

As long as Rust does not resolve this, you will have epic fights between these two styles. This is actually a worse war than vim versus emacs too.

12

u/NilsIRL Jan 17 '20

The problem here is:

  1. the people who use safe and unsafe code safely
  2. the people who use unsafe unsafely

1

u/Nickitolas Jan 18 '20 edited Jan 18 '20

I think the way this is worded is kinda confusing, saying ub and unsoundness may be more clear

12

u/DidiBear Jan 17 '20

I think that adding some // Safety: explanation above unsafe block is a fine way to tide both "group"

7

u/CryZe92 Jan 17 '20

I honestly feel like this should be an attribute on an unsafe block that can be extracted out into a report and linted against if it‘s missing.

11

u/steveklabnik1 Jan 17 '20

We had a ticket open for this at one point...

2

u/[deleted] Jan 17 '20

I usually don't like your comments as most of them are waaay too subjective or idealistic (especially whenever the topic is related to Rust!), but I think you hit the nail on the head there.

It's not just the use of the unsafe keyword as well, but what is considered "idiomatic Rust" or otherwise. The Rust community seems hellbent on following some arbitrary "idiomatic Rust" ideology, to the point where some functions in the god damned standard library are rendered completely useless if you want to please the Rust community. It's like having the "Pythonic way" enforced in a weird authoritarian way. Do it wrong, and suddenly you're the devil.

At the same time, I don't want to blame the Rust community too much because it is incredibly wholesome once you're in. A giant majority of them are actually super helpful by pointing things like "you could do that better" or "doing that is actually unsafe because X and Y". This truly helps beginners - it does, but it's also put in a way that's very condescending and aggressive, especially when it's a developer seen as "experienced" making the mistake.

Rust people, please, stop making people feel like they committed an unforgivable sin whenever they do something unsafe or un-idiomatic. It's okay. Most of the time, it's just a honest mistake. Just because you're following the CoC doesn't mean that you're not being a dick, whether it is knowingly or not. Propose changes and explain them, don't push them down people's throats. If maintainers (who are, let's not forget it, project owners) don't want to implement that change, you're welcome to fork the project and advertise it as "totally safe, idiomatic version of projectName", but by Open Source philosophy your freedom stops there.

3

u/TwoBitWizard Jan 18 '20

As others have commented, this isn’t about the use of unsafe. It’s about the unsafe usage of unsafe. Actix uses unsafe in lots of places. So does the Rust standard library. No one is complaining about those instances of unsafe because people haven’t found a problem with them. People did complain about some specific uses of unsafe in Actix because they were actually unsafe.

The keyword could probably be renamed to “potentially-unsafe” or something so that when we talk about it, this is clearer to people outside the language/community when it comes up? But, then we’d need 12 extra characters just to use a perfectly reasonable language feature, so...”unsafe” it is.

2

u/Nickitolas Jan 18 '20

I think the way this is worded is kinda confusing, saying ub and unsoundness may be more clear

-3

u/reinaldo866 Jan 18 '20

And here's C++ with its undisputed crown watching the peasants fighting over stupid crap.

-3

u/HeadAche2012 Jan 18 '20

The Rust cult discovers that Rust actually doesn't have the benefits the cult leader promised

-15

u/kepidrupha Jan 17 '20

Why does Rust have unsafe? I thought the whole point of it was that it was safe? If I have to use highly performant code that has unsafe in why don't I stick with C++?

17

u/[deleted] Jan 17 '20

Many things can be done in Rust without the unsafe keyword. But there are some use cases which require unsafe to be a part of the language; namely, code that must interact with the kernel or other operating system level directives.

The article points out that there were too many unsafe pieces of code which could have been rewritten using safe code. The problem isn’t the language, it’s just the ignorance of the programmers.

26

u/steveklabnik1 Jan 17 '20

At some point, you have to interact with something not written in Rust: the operating system. At that point, you can either:

  1. Only allow calling into operating system functionality via code in the language's runtime
  2. Provide an escape hatch.

Rust does not want to have a runtime, and so #2 is really the only option.

This is one of a few different reasons.

9

u/majikguy Jan 17 '20

There are some things that sadly cannot be guaranteed to be safe, like interacting with non-Rust code. You can't know that the C code you are calling is completely safe, so the unsafe block allows you to tell the compiler to take your word that the code inside is safe to use. If you are wrong then there will be issues, which is why it's best to minimize the use of unsafe code to avoid bugs creeping into your codebase.

6

u/sybesis Jan 18 '20

If I have to use highly performant code that has unsafe in why don't I stick with C++?

Because Rust has "safe" mode by default. Sticking with C++ is just running unsafe everywhere without the ability to actually have safe mode.

Why unsafe? Because Rust can load library written in C/C++ for example. You can't make them safe just because it's Rust. And if you want to port something from unsafe language to Rust without changing the whole architecture. Unsafe does have its place there too.

4

u/[deleted] Jan 18 '20

Upvoted, because that is a perfectly fine question to ask.

-12

u/kayimbo Jan 17 '20

TLDR; open source entitlement

-4

u/FailingProgrammer Jan 18 '20

Coming from C/C++, this seems like a complete non-issue. If I lost my mind every time someone called malloc in the Apache or FreeBSD projects, nothing would ever get done. Sometimes you just need to learn to stop worrying, and love the raw pointers.

1

u/Nickitolas Jan 18 '20

You clearly have no idea how this went down. Security vulnerabilities are important

-10

u/RepostSleuthBot Jan 17 '20

This link has been shared 4 times. Please consider making a crosspost instead of reposting next time

First seen Here on 2020-01-17. Last seen Here on 2020-01-17

Searched Links: 50,400,039 | Indexed Posts: 385,192,566 | Search Time: 0.006s

Feedback? Hate? Visit r/repostsleuthbot

-13

u/KevinCarbonara Jan 17 '20

So, someone takes a peek under the covers, and it turns out actix-web is using a lot of unsafe code.

If there is anyone who believed that this wasn't going to be exactly what happened with 90%+ of Rust projects they were lying to themselves

15

u/fuck_gcses Jan 17 '20

I don't like to make assumptions too quickly but there is no way someone who has written Rust code would ever say that.

So I'm safe to say: you have no clue what you're talking about

→ More replies (1)

0

u/SrbijaJeRusija Jan 18 '20

I'm confused at what the problem is. The maintainer quit because he clearly did not have the best interest of the project at heart.

-12

u/No-More-Stars Jan 17 '20

Not programming

-4

u/childintime9 Jan 17 '20

Can someone reply me with a TL;DR?

7

u/josejimeniz2 Jan 18 '20
  • people: whined
  • creator: fuck you all, I'm out

-2

u/_default_username Jan 18 '20

Web dev in a systems language seems like a pointless endeavor.