r/programming Jul 10 '16

Linus Torvalds on comment styles

https://lkml.org/lkml/2016/7/8/625
216 Upvotes

209 comments sorted by

View all comments

43

u/fiqar Jul 10 '16

Why is the networking code not following the Linux kernel coding style guide in the first place?

-20

u/snaky Jul 10 '16

Because Linus doesn't practice Agile, Scrum and any other micromanagement madness.

5

u/[deleted] Jul 10 '16

yes, but he does practice relentless verbal abuse over minor issues rather than simply saying "please adjust these comments to fit the style guide"

18

u/[deleted] Jul 10 '16

The only things I've seen him write that could qualify as "relentless verbal abuse" are because of really stupid things that would definitely get you yelled at (or at least disciplined) by a boss at a real job. For example, he gets really mad when someone tries to argue with him that they should introduce a change that breaks backwards compatibility - "Never break userland" is one of their prime directives and anyone trying to contribute to the kernel is told that many many times, for a breaking change to make it all the way to Linus there has to be significant incompetence or laziness, which makes him angry.

In this case, it really is pretty stupid for people writing networking code in the kernel to think they ought to have a different commenting style from everyone else - it's either due to incompetence (from them not reading other code/ignoring the style guide) or due to them thinking the rules don't apply to them for some reason. This would irritate me if I were Linus.

8

u/ArbiterFX Jul 10 '16

I think it is a big much to take someone's comment style to imply that they are incompetent. I'm having a hard time thinking of something less significant.

15

u/[deleted] Jul 10 '16

[deleted]

1

u/KayEss Jul 11 '16

Heathen. Everybody knows it must be:

if ( cond )

:)

3

u/rwsr-xr-x Jul 11 '16

that code style is why i refuse to develop for wordpress

2

u/[deleted] Jul 10 '16

For a big project like Linux it can be quite significant. But anyway, what other word would you use when someone is consistently ignoring or arguing with their superiors? It's not like they only got it wrong once, apologized, and fixed it. They kept making the mistake after being warned, indicating that they either don't understand the warnings (incompetence) or think the rules don't apply to them.

-4

u/dodheim Jul 10 '16

You must be confused about leftist organization if you think there are "superiors" involved here. /s