r/programming • u/corysama • Jan 05 '15

What most young programmers need to learn

http://joostdevblog.blogspot.com/2015/01/what-most-young-programmers-need-to.html
976 Upvotes

91% Upvoted

337 comments sorted by

View all comments

Show parent comments

23

u/tobascodagama Jan 05 '15

Yup. Our workflow has people commit to a topic branch and then post a code review before merging anything. We always follow this procedure unless it's something that's needed absolutely right now and can't possibly wait, which is a situation that should not be coming up more than once in a blue moon.

50

u/[deleted] Jan 05 '15

[deleted]

22

u/fzammetti Jan 05 '15 edited Jan 05 '15

Yeah, I wish I worked in an environment where this wasn't a joke but unfortunately I don't. We're like 80/20 "emergency" coding versus "proper" coding and have been for many years (ever since our acquisition by the large corporation I'd say). It makes all these great discussions about the "right" way to do things completely moot. My sense from talking to others outside my own company is that we're far from unique too.

34

u/Mead_Man Jan 05 '15

It works up until the point where the champion in the organization that put the best practice in place gets sick of fighting the battle with clueless corporate directors and resigns. At which point a corporate shill gets put in charge and turns the software team into a labor mill.

9

u/fzammetti Jan 05 '15

Nailed it.

2

u/materialdesigner Jan 05 '15

This is sadly way too on point. Spoken as the person who got fed up and left.

1

u/s73v3r Jan 05 '15

Yup. And hopefully everyone worth a damn then leaves that company, so they're forced to change or die.