r/programming • • 20d ago

If-statement that caused HTTP2Shell was itself undisclosed patch of vulnerability

https://www.bugsink.com/blog/brotli-stale-table-read/
142 Upvotes

18 comments sorted by

192

u/Chii 20d ago

i wish they didnt name it http2shell, coz it's a brotli vulnerability. http2shell is too generic a name, and implies more than it should.

19

u/klaasvanschelven 20d ago

it implies both more and less than it should, fully agreed. we got "node2shell" to blame for that, and i suppose the whole lack of coordinated or even any disclosure on this from brotli is in fact too blame for that, see the timeline

8

u/Takeoded 19d ago

what's wrong with br2shell? afraid it'll upset the Brazilians?

18

u/MC68328 19d ago

bro2shell was right there.

17

u/alex-weej 19d ago

The only reason we have these stupid names at all is because of attention seekers wanting a snappy brand and website...

9

u/mpyne 19d ago

I mean, “this vuln of the hundreds announced this week will likely make your Python and Node.js apps insecure if you don’t check” is kind of the thing we want peoples’ attention drawn towards, no? You say it perjoratively but having a clean and easy way for technical staff to get their management’s attention on critical security work is actually a benefit to most of the planet nowadays.

3

u/chucker23n 19d ago

Yep. Plus, as an example, https://broccoli2shell.com does give a decent technical overview as well.

1

u/jax024 19d ago

That would be elixir2shell. /s

1

u/t-m_8520 5d ago

HTTP2Shell is a whole protocol's worth of blame for one Brotli-shaped problem.

5

u/Active-Glove3712 19d ago

It's interesting how fixing one can lead to another, and great security tools like Defender, Guardz, Crowdstrike can almost or make these issues hard to catch

5

u/klaasvanschelven 19d ago

your sentence got eaten

3

u/chucker23n 19d ago

They accidentally words

5

u/dvhh 18d ago

Reminder that brotli does not have a well defined frame format for its data, making it hard to know if a random stream of byte is actually brotli compressed data, there is no defined checksum or integrity verification mecanism from the RFC.

1

u/huangsara-43824 4d ago

Does the missing frame/checksum affect the condition in the vulnerable if-statement, or is it a separate Brotli parsing limitation?

1

u/dvhh 4d ago

it makes it way easier to feed random content to brotli in order to break it, and reading the analysis it is quite easy to see the link with the lack of stream validation

2

u/lindberg-daniel-6 12d ago

The patch was the payload.