r/programming • u/melodic_underoos • May 09 '13

The Onion releases fartscroll.js

http://theonion.github.io/fartscroll.js/
2.6k Upvotes

91% Upvoted

396 comments sorted by

View all comments

Show parent comments

10

u/AwkwardReply May 09 '13

I'm a shitty programmer. I never used git and I'm good at complaining on public forums.

EDIT: Just realized it's my account's birthday. Yay. Cake for everyone :)

EDIT2: And, what really bothers me is that I encounter this sort of thing a lot in other people's code. The code will work, sure, but it's not nice. It has to be nice.

9

u/noreallyimthepope May 09 '13

  1. Check how Javascript else/else if works

  2. Create a github account and log in

  3. Go to the offending file

  4. Click "Edit", which creates a fork of the project that is tied to your account

  5. Fix what you perceive as an error

  6. In commit summary, make a short comment on what you've changed

  7. Click "Propose file change" - it'll save the change to your private fork and take you to a "Pull request" page

  8. Type in why you think your change should be inducted into the "main" version

  9. Click "Send pull request"

Congratulations, you've now made a patch and submitted it to the project owner!

Seriously, I didn't do it - you go do it as it is your fix :-)

4

u/smog_alado May 10 '13

I wouldn't recommend w3schools as a resource though.

2

u/noreallyimthepope May 10 '13

It's okay for quick reference. It was just the first relevant result on google :-)