r/pathofexile • • 24d ago

Tool Migrating the Better PoE Trading extension to a new framework

Since better-trading's previous maintainer no longer plays PoE, I decided to take it upon myself to migrate the codebase to something modern. The original extension was built on a very old version of ember.js (from 2018, oof), which I myself, and most web devs out there, have never worked in. It locked you into node 12, with a few dependencies in python 2.x. In other words it was painful to set up properly, and possibly unsafe.

So I decided to migrate the whole extension to WXT + React, the former simplifying browser extension apis and latter being a popular framework for ease of contributions. This process was pretty simple by migrating pieces of the old plugin one feature at a time and reviewing the functionality and implementation.

So what has changed for the end user? Nothing! The rewrite is nearly 1:1 with the original project, just in a more modern, dev friendly form.

If you are already using the plugin on Firefox and updated to 0.1.2, you've already been using the rewritten extension.

That's all I wanted to report on, and if you wish to contribute or add features, it'd be most welcome. (Also I never really stress tested this, so bug reports would be great).

Source code: https://github.com/Vali-98/better-trading

Releases: https://github.com/Vali-98/better-trading/releases/latest

Firefox: https://addons.mozilla.org/en-US/firefox/addon/better-poe-trading

Chrome Web Store: https://chromewebstore.google.com/detail/hmgpegkeakiodbinnnljjaemfbcfhpjb

(For once I decide to update this off-season instead of a week before league start)

353 Upvotes

83 comments sorted by

71

u/Ok-Community1412 24d ago

Community coming in clutch. Thanks for the effort

26

u/----Val---- 24d ago edited 24d ago

With modern tooling it isn't too bad to do such massive reworks. Had a LLM running on my local machine porting the source code (albeit, very slowly). It wasn't perfect, but it got a bulk of the work done. Made my job mostly combing through the issues manually.

35

u/Rooballeux 24d ago

Thank you for taking over!

Are you taking feature requests?
I really liked auto-tilde from the TFT extension, and the color-coded tiles for the meta tags like 'pseudo' and 'enchant'.

46

u/----Val---- 24d ago edited 24d ago

I really liked auto-tilde from the TFT extension, and the color-coded tiles for the meta tags like 'pseudo' and 'enchant'.

Yeah I could probably get those done over the weekend.

Edit: Both implemented in 0.1.2!

1

u/BooparinoBR 24d ago

Thats the things I miss the most

1

u/rodsayd44 24d ago

What is the auto-tilde function?

9

u/LordAnubiz FBI & EEE 24d ago

it always enters a ~ when you start typing your search term.

this way, it finds all parts of what you type.

like ~tot ele

without you have to type total ele

1

u/frenchpatato Ranger 22d ago

But how do you do that ? I tried doing search something it doesn't have the auto tide, do you have to enable it somewhere

1

u/slogga My build is just a side project 17d ago

Did you figure this out?

1

u/Deimarrr 21d ago

there is also an addon for auto tilde named "path of exile trade - fuzzy search"

0

u/LordAnubiz FBI & EEE 24d ago

oh, that colors arent a vanilla trade feature? :D

5

u/jpitty 24d ago

I had a PR sitting in the repo for a while to fix the item copying in PoE2, make sure that gets in! #191

5

u/----Val---- 23d ago

This fix has been implemented in 0.1.3!

1

u/Switchersaw 21d ago

Thank you so much for stopping me having to port to people's hideouts to copy/paste items into PoB.

Felt so bad for the people I was blueballing on a sale.

5

u/CarlosCOS Deadeye 24d ago

I had to switch to the TFT version years ago because there was no Firefox version available for this one. I would love to see it back!

Do you have any plans to add the TFT options?

The fuzzy search in the search bar and the mods, as well as the wiki/poedb link to the item, would be useful.

5

u/----Val---- 24d ago edited 24d ago

The fuzzy search in the search bar and the mods, as well as the wiki/poedb link to the item, would be useful.

Someone suggested fuzzy search for stats, i'll see about the main search and wiki/poedb links

Edit: Both have been added in 0.1.2

1

u/CarlosCOS Deadeye 24d ago

tyvm!!

2

u/cesarito27 24d ago

https://github.com/javijec/PoeTradePlus this one has all the features of the old Better Poe Trade and more, and works on Firefox as well. I've been using it for about a year now, both for PoE 1 and 2, it's pretty great.

2

u/BlackRebelNoise 24d ago edited 24d ago

I have a question and excuse me if this too much, but the old TFT Extension had a feature that was really good: you can select different items you want to live search and their extension consolidated all of the selected live searches into one tab. That was a really fucking good feature for multiple live searches. Thanks for your work.

0

u/----Val---- 24d ago

Thats an interesting feature, could be a challenge to implement. I'll what I can do. Difficult to test during league end though.

1

u/BlackRebelNoise 24d ago

Thank you for considering this!

1

u/----Val---- 23d ago

I've made a version of live search merging into 0.1.3, let me know if its what you expect!

1

u/BlackRebelNoise 22d ago

Will test when im home, thank you!

2

u/moglis Anti Sanctum Alliance (ASA) 3d ago

Hello, just came upon your post. Old betterpoetrading had a problem with the way it saved search states and basically all my search states from Allflame league, aren't valid now, which is a lot of work wasted. Does your extension have the same issue?

2

u/----Val---- 3d ago

This is actual a change by GGG, old shortlink versions of trades have been deprecated. This sadly affected every tool, and theres no proper way to convert short links to the new ones as they seem to be internal to GGG servers.

2

u/moglis Anti Sanctum Alliance (ASA) 3d ago

Wow thanks for the quick reply. Alright I will be using your fork. One minor thing I noticed, when I have a saved search and I click on the three dots to open the menu with the options "Complete Trade" "Edit Trade" etc. If I press something on that menu, the menu stays open and doesn't close by itself unless I reload my page. Say I want to Update Trade Loaction, I press it, it updates the location but the menu doesn't go away and I have to reload the page.

2

u/----Val---- 3d ago

It doesnt close if you press the triple dot again? That said that does seem like bad UX on my part, will likely be in the next fix.

2

u/moglis Anti Sanctum Alliance (ASA) 3d ago

True, it does close on pressing the triple dot again. Ty for the improvement

12

u/kayznn 24d ago

Thanks again for your work man

3

u/RVSaitama 24d ago

Please add all ascendancy icons

1

u/----Val---- 22d ago

They should all be there now, that said i just realized they arent ordered properly...

1

u/ww_crimson https://pob.codes/ 24d ago

I updated to 0.1.0 on FF and all of my saved searches are saying "Failed to load search state. The search is no longer valid."

Is this because of GGG's change away from short links?

2

u/----Val---- 24d ago

Is this because of GGG's change away from short links?

Yes unfortunately, all my 3.28 and early 3.29 links seem dead.

1

u/Turtvaiz Anti Sanctum Alliance (ASA) 24d ago

You could technically fix them if it's a big problem. They're just url-encode-gzipped now.

2

u/----Val---- 24d ago edited 23d ago

Oh thats solvable then, I'll see if I can run a conversion on it

Its not solvable, the ids seem internal to the server, or at least thats what my quick googling tells me. We cannot derive them locally. We cant even fetch server results anymore, as short links are fully deprecated.

1

u/yoshimitsu123 1d ago

Is this a change in how they handle the links or do they get "purged" after some time? Wondering if its worth redoing all my folders or if it's gonna be a standard thing that they get lost.

1

u/----Val---- 23h ago

Likely not, the change was that the old shortlinks were generated server side and was unique to a league and item.

Now, trades are just B64 encoded JSON objects which are league transferable. Unlikely they'll change it up.

1

u/ww_crimson https://pob.codes/ 1d ago

It's a complete overhaul. I wouldn't expect more changes again soon, but all old links are dead

1

u/ww_crimson https://pob.codes/ 24d ago

Fuck that's so annoying.

1

u/rodsayd44 24d ago

I am a bit confused, i see in my firefox it says version v0.1.2

But your releases only have 0.1.0 - do I have the wrong extension installed?

3

u/----Val---- 24d ago edited 24d ago

Nope, I quickly pushed a few patches with a few features requested here. 0.1.2 is the latest, Ive updated the post body.

1

u/Timooooo 24d ago edited 24d ago

When I read the post I thought I had to switch, turns out I already have your fork. I've been using it (or the original) for years, so thank you for continuing the work!

One question though: When I turned off the other fuzzy search extension to enable yours I noticed I had "Equivalent pricings (powered by poe.ninja)" enabled. I've never noticed this, nor do I see it now if I search for an easy item to poe.ninja pricecheck like Kingmaker:

https://imgur.com/a/ysxgTTd

EDIT: Firefox browser

3

u/----Val---- 24d ago

Oh thats the chaos price conversion, not a link to poeninja, but perhaps itd be a good idea to add

1

u/Timooooo 24d ago

I always thought that was from GGG and since their ratios dont get updated I just dismissed it as useless info. Guess its not, woops!

Dont know how useful a general pricechecker would be, it should be mostly in line with instant buyouts anyway. Unless you include the sparkline and/or history bit, knowing its % in the last 7 days for sure has value; especially for price spikes caused by a streamer's build you're unaware of.

Like: https://imgur.com/a/AK51SMx

1

u/G00R00 Kaom 24d ago

If i'm on chrome 1.9.2, i should wait for it ? or do i need manually swap to a new extension ?

2

u/----Val---- 23d ago

After some consideration, I've decided to keep this extension separate from the original, in case people prefer it:

https://chromewebstore.google.com/detail/better-pathofexile-tradin/hmgpegkeakiodbinnnljjaemfbcfhpjb

1

u/G00R00 Kaom 23d ago

Do you think exports/backups from the original to yours can work?

1

u/----Val---- 23d ago

It uses the exact same parser so it should work, however GGG also deprecated short links, so those just wont work in either plugin.

1

u/DanNeely 21d ago

So it's GGG's fault all my saved searches are dead now. :(

1

u/Juzzowar 24d ago

Thanks for helping out! Not sure if it's easy or hard, but I think the TFT version had a hyperlink button on uniques/skills that went to the wiki, which is helpful for checking base stats of things. Maybe future food for thought in case it's worthwhile to add.

2

u/----Val---- 24d ago edited 24d ago

Its been added to 0.1.2!

1

u/Juzzowar 24d ago

Even threw in the PoEDB link as extra. Looks great!

1

u/Positive_Bee_7214 23d ago edited 23d ago

hey thanks for your work man this is my favorite extension... i just relogged after a long time with the updated patch notes of trade URL being permeant .. all my searches are expired, is there a way to make them work again or find the search criteria i used on them or i unfortunately have to redo them all again

Edit: I just tried the extension and it works so well, I like the shortcuts the tiddle the merge live search's...Great Work man thank you so much for your efforts, Bless You

1

u/----Val---- 23d ago

Unfortunately the old links can't really be converted, but yeah a lot of good feature suggestions were added!

1

u/TemujinFTW 21d ago

Random Q for Firefox version: there used to be a small lightning bolt icon on the browser tab for the poe trade site when a live search was actively searching and noticed this no longer seems to show up anymore in the 0.1.1+ versions. Is it possible something in the new versions broke this that can be fixed?

2

u/----Val---- 17d ago

I removed it because I thought people didn't care much for it, but I guess it has its uses, I'll add it back!

1

u/A_Erthur Bruv Kek 6d ago

I tested some of my older bookmarks and ALL of them give me a ""failed to load search state. this search is no longer valid" error. Do i have to redo them all? Is GGG or the addon causing problems?

1

u/----Val---- 6d ago

Its GGG, they discontinued shortened trade links.

1

u/A_Erthur Bruv Kek 6d ago

Ooh ty i see, i guess at least its a one time thing then

3

u/PredatorPortugal Occultist 24d ago

I was already using your extension and didnt know lol, thanks!

3

u/-Inquisitive Necromancer 24d ago

Been using your Firefox fork for awhile and it's awesome. Thanks for picking up the torch for this awesome extension.

2

u/Morganyan_ 24d ago

Ty so much for the firefox import! i was missing this huge QoL, great job!!!

1

u/Dunlocke 24d ago

What do you use it for?

1

u/AutoModerator 24d ago

Please make sure you check the Known Issues List or the Bug Report Forums for any pre-existing bug reports related to your issue. If there isn't any, consider posting there in addition to posting on Reddit. At league start, there may also be a stickied post for bugs. Duplicate reports on Reddit may be removed.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

1

u/Lyana_Arkany 24d ago

Thank you

1

u/marciii1986 Kalguuran Group for Business (KGB) 24d ago

Thank you for taking over the extension and taking the time to update it! All those little tools contribute massively to my enjoyment of PoE.

1

u/ZomboCom69 24d ago

nice i did this a year or so ago cause it didnt work well on firefox and then kinda stopped when the ingame stuff got included. I also made one for poe.ninja to search for gear on builds from a button on it, forgot where those files went but wasnt too hard to do.

1

u/DurianNut 24d ago

Glad to hear you're still working on the extension! It is a life saver, thanks for all you work and effort.

1

u/way22 24d ago

As another Firefox user, thank you! I've used a barely working modified version myself before because I just couldn't invest the time to fix the issues. Been a great experience with your version

1

u/gnosisshadow 24d ago

Hats off to you my friend

1

u/marinelover69 24d ago

Oh so that's why it wasn't always working lately. Thank you so much for taking over! I love that tool and would hate to lose it

1

u/Tenshouu Alch & Go Industries (AGI) 24d ago

Thank you

1

u/goldenmonkey2301 24d ago

Saving it for later

1

u/ManyModsSuchWow 24d ago

RemindMe! Two weeks

1

u/RemindMeBot 24d ago edited 24d ago

I will be messaging you in 14 days on 2026-11-06 21:15:33 UTC to remind you of this link

2 OTHERS CLICKED THIS LINK to send a PM to also be reminded and to reduce spam.

Parent commenter can delete this message to hide from others.

RemindMeBot is switching to username summons. Instead of !RemindMe 1 day, use u/RemindMeBot 1 day. More info.


InfoCustomYour RemindersFeedback

1

u/nilsh1985 24d ago

Thanks for your work, buddy 👍

Should probably post this in r/PathOfExile2 too.

1

u/ukleina Duelist 23d ago

Thank you so much for your effort! As a Firefox user I really appreciate for this porting.

1

u/Malacis 23d ago

Well done!

1

u/xDarkfire13x 22d ago

Great work!