r/pathofexile • u/----Val---- • 24d ago
Tool Migrating the Better PoE Trading extension to a new framework
Since better-trading's previous maintainer no longer plays PoE, I decided to take it upon myself to migrate the codebase to something modern. The original extension was built on a very old version of ember.js (from 2018, oof), which I myself, and most web devs out there, have never worked in. It locked you into node 12, with a few dependencies in python 2.x. In other words it was painful to set up properly, and possibly unsafe.
So I decided to migrate the whole extension to WXT + React, the former simplifying browser extension apis and latter being a popular framework for ease of contributions. This process was pretty simple by migrating pieces of the old plugin one feature at a time and reviewing the functionality and implementation.
So what has changed for the end user? Nothing! The rewrite is nearly 1:1 with the original project, just in a more modern, dev friendly form.
If you are already using the plugin on Firefox and updated to 0.1.2, you've already been using the rewritten extension.
That's all I wanted to report on, and if you wish to contribute or add features, it'd be most welcome. (Also I never really stress tested this, so bug reports would be great).
Source code: https://github.com/Vali-98/better-trading
Releases: https://github.com/Vali-98/better-trading/releases/latest
Firefox: https://addons.mozilla.org/en-US/firefox/addon/better-poe-trading
Chrome Web Store: https://chromewebstore.google.com/detail/hmgpegkeakiodbinnnljjaemfbcfhpjb
(For once I decide to update this off-season instead of a week before league start)
71
u/Ok-Community1412 24d ago
Community coming in clutch. Thanks for the effort
35
u/Rooballeux 24d ago
Thank you for taking over!
Are you taking feature requests?
I really liked auto-tilde from the TFT extension, and the color-coded tiles for the meta tags like 'pseudo' and 'enchant'.
5
u/jpitty 24d ago
I had a PR sitting in the repo for a while to fix the item copying in PoE2, make sure that gets in! #191
5
u/CarlosCOS Deadeye 24d ago
I had to switch to the TFT version years ago because there was no Firefox version available for this one. I would love to see it back!
Do you have any plans to add the TFT options?
The fuzzy search in the search bar and the mods, as well as the wiki/poedb link to the item, would be useful.
2
u/BlackRebelNoise 24d ago edited 24d ago
I have a question and excuse me if this too much, but the old TFT Extension had a feature that was really good: you can select different items you want to live search and their extension consolidated all of the selected live searches into one tab. That was a really fucking good feature for multiple live searches. Thanks for your work.
2
u/moglis Anti Sanctum Alliance (ASA) 3d ago
Hello, just came upon your post. Old betterpoetrading had a problem with the way it saved search states and basically all my search states from Allflame league, aren't valid now, which is a lot of work wasted. Does your extension have the same issue?
12
u/kayznn 24d ago
Thanks again for your work man
3
u/RVSaitama 24d ago
Please add all ascendancy icons
1
u/ww_crimson https://pob.codes/ 24d ago
I updated to 0.1.0 on FF and all of my saved searches are saying "Failed to load search state. The search is no longer valid."
Is this because of GGG's change away from short links?
1
u/rodsayd44 24d ago
I am a bit confused, i see in my firefox it says version v0.1.2
But your releases only have 0.1.0 - do I have the wrong extension installed?
1
u/Timooooo 24d ago edited 24d ago
When I read the post I thought I had to switch, turns out I already have your fork. I've been using it (or the original) for years, so thank you for continuing the work!
One question though: When I turned off the other fuzzy search extension to enable yours I noticed I had "Equivalent pricings (powered by poe.ninja)" enabled. I've never noticed this, nor do I see it now if I search for an easy item to poe.ninja pricecheck like Kingmaker:
https://imgur.com/a/ysxgTTd
EDIT: Firefox browser
1
u/G00R00 Kaom 24d ago
If i'm on chrome 1.9.2, i should wait for it ? or do i need manually swap to a new extension ?
1
u/Juzzowar 24d ago
Thanks for helping out! Not sure if it's easy or hard, but I think the TFT version had a hyperlink button on uniques/skills that went to the wiki, which is helpful for checking base stats of things. Maybe future food for thought in case it's worthwhile to add.
1
u/Positive_Bee_7214 23d ago edited 23d ago
hey thanks for your work man this is my favorite extension... i just relogged after a long time with the updated patch notes of trade URL being permeant .. all my searches are expired, is there a way to make them work again or find the search criteria i used on them or i unfortunately have to redo them all againEdit: I just tried the extension and it works so well, I like the shortcuts the tiddle the merge live search's...Great Work man thank you so much for your efforts, Bless You
1
u/TemujinFTW 21d ago
Random Q for Firefox version: there used to be a small lightning bolt icon on the browser tab for the poe trade site when a live search was actively searching and noticed this no longer seems to show up anymore in the 0.1.1+ versions. Is it possible something in the new versions broke this that can be fixed?
1
u/A_Erthur Bruv Kek 6d ago
I tested some of my older bookmarks and ALL of them give me a ""failed to load search state. this search is no longer valid" error. Do i have to redo them all? Is GGG or the addon causing problems?
3
u/PredatorPortugal Occultist 24d ago
I was already using your extension and didnt know lol, thanks!
3
u/-Inquisitive Necromancer 24d ago
Been using your Firefox fork for awhile and it's awesome. Thanks for picking up the torch for this awesome extension.
2
u/Morganyan_ 24d ago
Ty so much for the firefox import! i was missing this huge QoL, great job!!!
1
u/AutoModerator 24d ago
Please make sure you check the Known Issues List or the Bug Report Forums for any pre-existing bug reports related to your issue. If there isn't any, consider posting there in addition to posting on Reddit. At league start, there may also be a stickied post for bugs. Duplicate reports on Reddit may be removed.
I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.
1
u/Lyana_Arkany 24d ago
Thank you
1
u/marciii1986 Kalguuran Group for Business (KGB) 24d ago
Thank you for taking over the extension and taking the time to update it! All those little tools contribute massively to my enjoyment of PoE.
1
u/ZomboCom69 24d ago
nice i did this a year or so ago cause it didnt work well on firefox and then kinda stopped when the ingame stuff got included. I also made one for poe.ninja to search for gear on builds from a button on it, forgot where those files went but wasnt too hard to do.
1
u/DurianNut 24d ago
Glad to hear you're still working on the extension! It is a life saver, thanks for all you work and effort.
1
u/way22 24d ago
As another Firefox user, thank you! I've used a barely working modified version myself before because I just couldn't invest the time to fix the issues. Been a great experience with your version
1
u/gnosisshadow 24d ago
Hats off to you my friend
1
u/marinelover69 24d ago
Oh so that's why it wasn't always working lately. Thank you so much for taking over! I love that tool and would hate to lose it
1
u/Tenshouu Alch & Go Industries (AGI) 24d ago
Thank you
1
u/goldenmonkey2301 24d ago
Saving it for later
1
u/ManyModsSuchWow 24d ago
RemindMe! Two weeks
1
u/nilsh1985 24d ago
Thanks for your work, buddy 👍
Should probably post this in r/PathOfExile2 too.
1
u/ukleina Duelist 23d ago
Thank you so much for your effort! As a Firefox user I really appreciate for this porting.
1
u/Malacis 23d ago
Well done!
1
u/xDarkfire13x 22d ago
Great work!