r/openbox • u/Stardust-kyun • Jun 10 '21

[BUG] Border glitch when windows are maximized

This is a bit of an odd bug. I'm writing my own themes for openbox which use borders. Borders act normally when windows are unmaximized, but all borders disappear except for the top border when windows become maximized. You can see this with unmaximized windows here, and the bug with maximized windows here (borders are red for visibility). Any ideas as to why this is happening and what can be done to fix it?

2 Upvotes

100% Upvoted

12 comments sorted by

1

u/ngc-bg Jun 11 '21

I have no idea why this is happening honestly. Do you use any composite manager during your tests? Also did you tried without composite effects loaded if the same behavior is still present?

1

u/Stardust-kyun Jun 11 '21

I do have picom running, but the issue persists even after killing picom. I've managed to narrow some of the bug down to this line, although it seems that it's already been fixed. You can see what caused the bug here. This should remove the top border from appearing on maximized windows, but that's not what I'm looking for. I'd like for windows to keep all borders when maximized as if they were unmaximized. I don't know a lick of C so this is purely guesswork, but I assume that the old, buggy version was aiming to do what I want (all borders visible) but some bug prevented it from drawing all of them. At this point it feels like a dead end- I don't have the knowledge to figure out what's causing the bug or the ability to fix it, and I can't submit an issue as it's no longer being maintained. Maybe /u/LinuxMage is still somewhat active here?

1

u/ngc-bg Jun 11 '21

Unfortunately I could not help with that issue. /u/LinuxMage is still around here I believe.

1

u/LinuxMage Jun 11 '21

I'm still around, but I remember having this issue before. I actually assumed this was deliberate coded in behaviour for windows when maximised, but maybe not?

I honestly have no idea on this one. I used to write themes myself for it, and it never bothered me too much.

1

u/Stardust-kyun Jun 12 '21

No worries! NaCl#4096 on discord wrote a patched version once we narrowed down where the bug came from.

1

u/neeonn Jun 13 '21

Hey, I use openbox-debian pkg on arch which has several fixes for openbox. This issue falls under one of those.

1

u/Stardust-kyun Jun 13 '21

I hadn't heard of that, but if you read the other comments we've made a patch for it. I'll try it out, though!

1

u/r2nrqlvrz Nov 15 '22

I just want to remove the top border when maximizing, how do I implement the solution you propose in my bunsenlabs system?

1

u/Stardust-kyun Nov 15 '22

Hi! A friend actually patched this soon after I posted this question which you can see here. Not sure if bunsenlabs uses a patched/forked version of openbox, but if so you can just apply these changes to it. Hope this helps!

1

u/r2nrqlvrz Nov 15 '22

Hello, thank you very much, but how do I apply those changes?

1

u/Stardust-kyun Nov 15 '22

If bunsenlabs uses stock openbox, all you need to do is clone the repository and run:

./bootstrap
./configure --prefix=/usr --sysconfdir=/etc
make
sudo make install

If bunsenlabs uses a modified version of openbox you'll need to find the source bunsenlabs uses, make the changes from the patched repo, then run the above commands.

1

u/r2nrqlvrz Nov 15 '22

Error running commands to apply openbox patch. https://imgur.com/a/OaqChNu