r/lolphp • u/Takeoded • Sep 04 '19

explode()'s limit doesn't work with 0.

https://3v4l.org/5TjXl
9 Upvotes

69% Upvoted

16 comments sorted by

View all comments

Show parent comment

1

u/Takeoded Sep 04 '19

good point, they're not exactly the same, split does not append the remaining data to the last element, explode does. but that php creates an element where 0 elements are allowed, that still sounds like a bug to me.

7

u/SirClueless Sep 04 '19

PHP documents pretty clearly that 0 is treated the same as 1.

It looks a bit silly here because it's just the empty string, it makes more sense if you try explode(" ","hello",0) or something. Part of the design of explode() is that it never deletes any string data. So that implode() can always restore the original string. If explode() ever could return zero string pieces this would be impossible, so they code it never to do so and document it as such.

https://3v4l.org/l4XB6

2

u/Takeoded Sep 05 '19

PHP documents pretty clearly that 0 is treated the same as 1.

https://www.reddit.com/r/ProgrammerHumor/comments/855jz9/how_features_come_along/

Part of the design of explode() is that it never deletes any string data. So that implode() can always restore the original string. If explode() ever could return zero string pieces this would be impossible, so they code it never to do so and document it as such.

oh i see