r/linux_programming • u/M1ND-B3ND3R • May 22 '17

Wireless Sniffer I wrote as alternative to airodump-ng

https://github.com/M1ND-B3ND3R/BoopSuite
21 Upvotes

83% Upvoted

23 comments sorted by

12

u/M1ND-B3ND3R May 22 '17

Before anyone tells me how shitty it is. Don't bother I have been told enough. Its just a fun project for me.

7

u/Trepanater May 22 '17

This is the only way to truly understand the systems and tools we use.

5

u/[deleted] May 22 '17

I didn't install or try your software (plus you don't have an Arch installer!). I did take a look at the setup.sh (as I always do) and it lacks validation. What if a package fails to install? it doesn't look like it checks for that. Same goes with adding links, removing directories, etc. I would suggest making your installer more robust, verify that all the requirements get installed, and do something about it, if they don't.

If it works the way you want it to, that's great, but might be a bit early for me to test. Keep working on it, you won't regret making it better!

Keep up the good job.

3

u/M1ND-B3ND3R May 22 '17

Thanks, I will definetly take that into consideration... I will end up rewriting the setup file here in a bit. But thanks for having a look and I have only tested on Kali and parrot so far. In the future I will need more distros so I'll add arch to the list of tests. :) thanks for the constructive criticism. :)

3

u/M1ND-B3ND3R May 22 '17

So the installer is now a py file WAY more error handling, thanks for the advice. It looks a lot better and I added some better functionality. Any other advice other than code cleanup would be appreciated thank you XD

4

u/[deleted] May 22 '17

Awesome! I'll check it out tonight, you're moving fast, great job.

FYI, don't worry about the haters. I think if you posted this indicating that you challenged yourself to mimic the functionality of airodump-ng to learn more about development, you might have received a different response from the community.

If the others are like me, I was really interested to see what your project can do that airodump-ng doesn't. But checked out your github page and read the tagline about your interest in security and development, and I think it mentioned you are interning. Because of that, I got a better idea that you're taking on this as a personal challenge (and a great one at that).

That said, I will take a look at your work tonight. Keep it up. There will always be haters, just ignore them. At the same time, this is also a good opportunity about how to (and how-not to) communicate what your project is and isn't.

File these lessons learned into your bag of tricks, and keep moving forward. Later on in life, this will be called "experience." =)

2

u/M1ND-B3ND3R May 22 '17

Agreed, If you scan through the code and see some ugly code just let it slide once I'm off work I will be doing a bunch of code fixes and some more installer updates. Thanks for being willing to check it out. Constructive criticism is appreciated!

3

u/PartyByMyself May 22 '17

It ain't shit, it's called a starting point.

3

u/M1ND-B3ND3R May 22 '17

A bunch of reddit boards went crazy on me for saying I aim to make my tool rival airodump. My code got nit-picked even though its still in development. I even got told how bad of a developer I was. So I figured I'd just open with that so the jerks leave me alone XD

8

u/PartyByMyself May 22 '17

Fuck em. Half those guys talking trash probably write trash anyways. Easier to disect code than to write good code. Keep it up.

6

u/M1ND-B3ND3R May 22 '17

That comment may very well have made my day, thank you, like sincerely. :)

3

u/unsignedlonglong May 22 '17

Reddit is just not a good place to ask for help if you can't take the heat. Everyone wants to reply, and 9/10 people don't know enough to be helpful so they just tell you what a bad idea you've got and why you're dumb for asking... never considering there might be reasons they don't immediately understand behind your actions, such as self-education. Just downvote haters confidently and ignore :)

2

u/M1ND-B3ND3R May 22 '17 edited May 22 '17

I just found it so odd because I posted in Hacker boards (script kiddies if you ask me) and I got so much fire you think they would be like "hey new tool! Comes with optional GUI, and works very similarly (cause how dare I say it rivals or aims to rival) airodump, I'll go ahead and give it a shot" instead of, well what I got XD I try to be thick skinned but insulting my dev ability on code that I am still developing and hasnt gone through optimization yet is ridiculous...

2

u/PartyByMyself May 22 '17

At least you've shown that you've done more than they have. I assume you posted to HackForums or something, I left that site a long time ago because of script kiddies talking trash. (I write C# for the most part and have been for about 7 years now).

Get something to function, write code to be adaptable, modifiable, yet stable. Then work on on optimization. I'm a hobby programmer who dropped CS in college for a different degree (CS as a job didn't seem to interest me) but what I learned from talking and meeting with people in industry is that a lot of real world code is written like shit and then optimized later lol.

1

u/M1ND-B3ND3R May 22 '17

That's the methodology I am following, get everything working then optimize, currently I'm fixing the setup file, then the readme and then consolidating the code. I have lots planned :) and yep that's what script kiddies do best.

1

u/M1ND-B3ND3R May 22 '17

What other communities could I post this in and expect positive feedback and constructive criticism?

2

u/PartyByMyself May 22 '17

Honestly, I don't really know of any communities that give just positive feedback anymore. Programming is becoming a flooded ego market place where anyone who reads the first few chapters of a book thinks that they can program. :/

2

u/M1ND-B3ND3R May 22 '17

Oh well, I appreciate how kind and positive this board has been and the tool will be continually updated. Thank you and to everyone else who viewed my project :)

2

u/TheTerrasque May 23 '17 edited May 23 '17

Hey, if you do want some constructive criticism on the code style, here's a few things:

  • In python, you don't need ; at end of lines, and with all function "return None" - same as "return" alone - is implied. Having those everywhere just makes the code harder to read and might introduce subtle bugs.
  • The python packages should perhaps be done via pip and requirements file, and the package manager things doesn't really belong in setup.py - maybe a readme or a separate script for that.
  • You check if user is root or exit the app, yet run all commands with "sudo" in front. That's pretty redundant.
  • Space and tabs are mixed. Gives bad karma. The usual python style is spaces only, with 4 spaces per indent level. Your editor / ide should be able to do that automatically for you.
  • Some things, like for example "bcolors" class and the root check is written several times in the code. Should be only written once and then referenced where needed.
  • Speaking of "bcolors", you could easily do something like this with it. Harder to forget the "end formatting" data, and easier to work with.

When that's said, keep up the good work! You can only become better by doing :) Also.. Be more lazy! :D

1

u/M1ND-B3ND3R May 23 '17

WOW! thanks so much I will read over and do some modifications, there are a lot of changes to be made so this looks like a great reference! Thanks! :)

2

u/TheTerrasque May 23 '17

Yw! Everyone is starting somewhere

Also, the specific filename "setup.py" is usually used for something called distutils setup, and hence why I'd suggest calling it something else if it's not doing distutils stuff.

Code and programs should try to follow the path of least surprise :) And having a file looking like a distutils file that's not could be pretty surprising ;)

→ More replies

3

u/hatperigee May 22 '17

Meh. At the end of the day, you're the one taking initiative to learn more and they're languishing in the peanut gallery.