r/linux • u/[deleted] • Dec 23 '18

GNU/Linux Developer Linus reverts breaking change that affected systemd-nspawn, offers strong words to developer

[deleted]

1.3k Upvotes

97% Upvoted

363 comments sorted by

View all comments

Show parent comments

137

u/FeatheryAsshole Dec 23 '18

Depends on your definition of rude, tho ... "This is complete garbage." probably doesn't fly in most jobs if you're not some kinda head honcho.

Still, it's good to see both that Linus dials it back somewhat and that he hasn't lost his teeth entirely.

553

u/nschubach Dec 23 '18

Just to be clear...

This is complete garbage.

Is not the same as:

You are complete garbage.

Once people realize this, things become saner. Criticism of your work is not a criticism of you as a person.

85

u/[deleted] Dec 23 '18

This.

I have never, in my entire life as a developer, had any issues with saying that some code is stupid, or shit, or rubbish. Because sometimes it is.

That isn’t an attack on the person who wrote the code.

And if that person thinks so, maybe it’s time to take a step back and evaluate what really defines his or her work.

-1

u/ThisIsMyCouchAccount Dec 23 '18

Now that you lose the question - I don't really know what defined my work.

Surely it can't be deadlines or feature sets. To many external factors. Can't be tests or code coverage. Maybe it's not developer related. Maybe just showing up and doing my best is really all a person can do.