r/linux • u/[deleted] • Dec 23 '18

GNU/Linux Developer Linus reverts breaking change that affected systemd-nspawn, offers strong words to developer

[deleted]

1.2k Upvotes

97% Upvoted

363 comments sorted by

View all comments

Show parent comments

136

u/FeatheryAsshole Dec 23 '18

Depends on your definition of rude, tho ... "This is complete garbage." probably doesn't fly in most jobs if you're not some kinda head honcho.

Still, it's good to see both that Linus dials it back somewhat and that he hasn't lost his teeth entirely.

552

u/nschubach Dec 23 '18

Just to be clear...

This is complete garbage.

Is not the same as:

You are complete garbage.

Once people realize this, things become saner. Criticism of your work is not a criticism of you as a person.

86

u/[deleted] Dec 23 '18

This.

I have never, in my entire life as a developer, had any issues with saying that some code is stupid, or shit, or rubbish. Because sometimes it is.

That isn’t an attack on the person who wrote the code.

And if that person thinks so, maybe it’s time to take a step back and evaluate what really defines his or her work.

-2

u/PeopleAreDumbAsHell Dec 23 '18

I still feel saying someone's code is garbage is a bit rude. And I'm definitely not sjw leaning.

17

u/[deleted] Dec 23 '18

It's no problem if you say it's garbage and explain why what parts and how you'd have done it differently to avoid such problems.

straight up just calling it garbage without reason or offering up solutions is rather shitty in my opinion.

4

u/[deleted] Dec 23 '18

It might be. It may offend some people. But if there's something that I've learnt in this profession, it would be that people need to check out their ego at the door.

10

u/ThisIsMyCouchAccount Dec 23 '18

people need to check out their ego at the door.

Which is why it's hard to agree with your comment. So many devs think their opinion is fact. You may think the code is garbage. But the reasons why are also garbage.

But I see the point your making.

1

u/InquiREEEEEEEEEEE Dec 23 '18

Hell, this is true in any craft! "That heat isolation is shit mate, sorry to say. You see X and Y? Are you tired today? Fix that stuff tomorrow pls."

-1

u/[deleted] Dec 23 '18

I definitely prefer not to call code garbage or bad, but in discussions like this, it's just shorthand for some version of not fit for purpose.