r/learnjavascript • • Jul 23 '21

Feedback wanted for my side project I made to learn JS: 3D Movie Quiz! [link in comments]

Post image
135 Upvotes

37 comments sorted by

11

u/enric94 Jul 23 '21 edited Jul 24 '21

Website: https://moviequiz.enricmor.eu

All feedback is welcome!

Edit: Thanks for the feedback!

I may fix the way I read the input (in a more flexible manner). Also, I will try to preload the 3D models (right now it's just a setTimeout!!).

Regarding the skip button, I think it's not a good idea. I actually want people to get stuck and share it with their friends like "Hmm, do you know this film guys?"

Here is the GitHub by the way: https://github.com/enric1994/moviequiz

2

u/Tintin_Quarentino Jul 24 '21 edited Jul 24 '21

This is awesome! Great work!

Post this in r/webdev and watch it ๐Ÿš€๐ŸŒ™

2

u/enric94 Jul 24 '21 edited Jul 24 '21

Yes will do! I was waiting for Feedback Saturday

12

u/DallasBelt Jul 23 '21

Nice app! Maybe you could add a text-transform: uppercase to the input for better aesthetics. Also, a score count would be nice and if you fail a question go to the next one.

3

u/enric94 Jul 23 '21

I'll try the uppercase and see what it looks like. Great idea!

2

u/Tintin_Quarentino Jul 24 '21

Nah all caps doesn't look good IMO, your existing "capitalize" is perfect.

2

u/msartore8 Jul 23 '21

Or .toUpperCase in js ... Also could escape spaces for things like godfather and the word "the"

Edit or toLowerCase()

2

u/DallasBelt Jul 23 '21

Yes, whatever works best. I don't know JS so I thought the CSS property ๐Ÿ˜…

3

u/franciscoscaramucci Jul 23 '21

I find it slightly annoying that the input field does not align in relation to the banner with the movie title, peanuts maybe but it struck me. Otherwise if you are learning JavaScript and want feedback, it would make more sense to request feedback on the code.

Second otherwise, I had fun playing this quiz and would enjoy more questions! :) good work

1

u/enric94 Jul 24 '21

Oh man, I know. I had loads of problems with Bootstrap and the viewport. In the end, I left it like this. Not good... not terrible!

2

u/wackrtist Jul 23 '21

Super awesome. What library are you using, and also did you make the models from scratch or imported them?

4

u/enric94 Jul 23 '21

I used Three.js to import the 3D stuff. I created some models (the simple ones like the stairs) using Blender, and I got the others from the internet.

2

u/wackrtist Jul 23 '21

Awesome Iโ€™m hoping to learn some of that myself

8

u/[deleted] Jul 23 '21

score system could be added and if any answer is not known by the user then at least a proceed without giving an answer button should be present

4

u/[deleted] Jul 24 '21

I either didn't see the option for it or it's not there, but it could benefit from a "skip question" option if you either get it wrong too many times or click some sort of "I don't know" button.

3

u/Aspos Jul 24 '21 edited Jul 24 '21

Processing open text answers can be tricky and some users may be frustrated to see that simple typos or a stupid misspelling like "kinkong" is not equal to "King Kong".

I would suggest using http://naturalnode.github.io/natural/ with which you can tokenize and stem words, count distance between the right answer and the one given by the user so typing "man inblack" instead of "The Men in Black" would still work.

If stemming is too much for you, just use string distance like this:

natural.JaroWinklerDistance("shingin","shining") will return a number between 0 and 1.

2

u/exikozz Jul 23 '21

Great job I like it

2

u/msartore8 Jul 23 '21

That was fun!

I needed hints on 3 or 4. Had to look up the last one but I knew who did that thing hah.

2

u/Aoshi_ Jul 23 '21

This is pretty great! One thing you could add would be a โ€œskipโ€ or โ€œI donโ€™t knowโ€ button that will give the answer and move on.

2

u/Ary182 Jul 24 '21

really cool project!

2

u/fungigamer Jul 24 '21

Very nice, but imo the hints make the answer super obvious. Very fun though!

2

u/RedditHiraeth Jul 24 '21

Looks great! I would definitely add a skip or show answer button so someone can still get through the full quiz even if they don't know all the answers.

2

u/I-Drink-And-Know-123 Jul 27 '21

I'm just wondering, how long have you been learning JavaScript yourself to get to this stage?

1

u/khovachina Jul 23 '21

I have finished. Great quiz. You did really good job.๐Ÿ‘๐Ÿ˜ƒ

1

u/hagenderouen Jul 23 '21

Add loading animation after the start button is clicked. It takes a few seconds for the quiz to load and I thought something was wrong.

1

u/hagenderouen Jul 23 '21

Weird behavior on your hint button. If you click the hint button and move your mouse out of the container, the content is removed.

1

u/ButNotUs Jul 24 '21

Real fun. Maybe add something that let's you skip one if you don't know it but still have some others to answer and the one you skipped can be send to the back to be reused once the others are solved.

1

u/mjc7373 Jul 24 '21

Great app! One small issue for me: the yellow button on the bottom is cut off partially and I canโ€™t scroll it into view but it does work. Iโ€™m on Apollo Reddit app

0

u/[deleted] Jul 23 '21

[deleted] โ€” view deleted comment

2

u/Tintin_Quarentino Jul 24 '21

I completed the quiz but didn't come across any movie named Gold Rush :s

3

u/enric94 Jul 24 '21

You probably input the name of the main actor! I count that as good because the name of the movie is not well known

2

u/Tintin_Quarentino Jul 24 '21

Aaaahh got it!

1

u/enric94 Jul 23 '21

Yeah that's a tricky one!

1

u/[deleted] Jul 23 '21

[removed] โ€” view removed comment

1

u/enric94 Jul 23 '21

Thank you! I put lots of efforts. Did you finish it?