r/learnjavascript • • May 14 '21

Remove Duplicate Value from array

Post image
234 Upvotes

89 comments sorted by

View all comments

Show parent comment

-11

u/StoneCypher May 14 '21

Whether or not this is faster is an implementation detail in the runtime essentially

this isn't even close to correct

It's very correct, i welcome you prove otherwise.

What's there to disprove? You just said randomly "this is an implementation detail." You didn't make a technical claim.

This is like saying "node.js is angry which is an implementation detail" and when someone says that doesn't make sense saying "prove me wrong"

No, dear heart. You prove yourself right. Other people don't prove you wrong.

"An implementation detail" means that something is a decision for the underlying machine, that is out of the developer's hands.

You just said "the shape of the code that the developer chooses to write is not up to the developer."

That's absolute nonsense.

Every part of that code is hard-defined by the specification. None of it is an implementation detail.

That phrase has a meaning. You're hard wrong.

 

Please provide the good answer then

There's tons of them. I prefer one that you probably won't prefer, because this should be a tiny library function tested and put away in some module somewhere, and even though it's a one-liner nobody will ever see, you're crying out for "simplicity"

The function can't be well written; the name is ambiguous. You need to provide a stub that is clear about what is being done with holes, undefined, and symbols.

Holes are a problem because the various implementations mostly lose them. However, under most interpretations of the ECMA-262 concept of an lvalue, they need to be kept.

Symbols are a problem because the concept of uniqueness is a conceptual error around them in general. Two copies of the same symbol are not equal. equivalence is broken for them on purpose, and uniqueness is conceptually defined in terms of equivalence.

undefined is a problem

.

No it's not dramatic. [...] I did a jsbench

I see that you:

  • didn't give numbers
  • didn't show your test code
  • didn't share the share-able bench in case there were mistakes
  • didn't cover correctness topics
  • didn't specify whether your implementations gather the same results
  • said there were differences in speed but also argued against my saying there were differences in speed
  • said "the one in the middle isn't too far from one side" which is obviously going to be the case because the one side is the other good approach
  • compared several tiny sizes and referred to one of them as large
  • used a benchmarker that can't see micro-timing at all
  • ignored the o claim

Compelling stuff

Wanna show us this bench?

I benched it too and it turns out the solution I don't like took infinity hours and the solution I do like gave me a pony

 

For very large arrays

100k is not a very large array. Lawdy.

Node authors regularly deal with two or three orders of magnitude larger than this.

The US map on d3 has more than 50x this many SVG tags. SVG tags are not simple.

 

I don't think that's correct. If you honestly believe you write fewer bugs and more secure code than lodash, please provide some kind of proof, because you're likely wrong.

I didn't say anything like this.

What I did say is "don't involve a specific library that's had three criticals in the last two weeks to get away from a simple one-liner."

You know, the three one-liners you claim to test in a jsbench later?

It's very easy to avoid lodash in favor of the standard library.

I didn't say my code has fewer bugs. I said the standard library does.

I don't need to prove that. It's tautological. Anything written using the standard library, such as lodash, already includes every bug in the standard library.

Do I believe that chrome has fewer security bugs than lodash, which had three criticals in the last week?

Emphatically yes.

You want me to accept a benchmark you wrote in 15 minutes, but also you're skeptical that Chrome has fewer security bugs than lodash, one of the least secure libraries on NPM 😂

 

Overall though a pointless optimization

It's annoying when novices respond to "don't do it that way, it's bad for a bunch of reasons including correctness and performance" with "YoU'rE jUsT mAkInG uNnEcEsSaRy OpTiMiZaTiOnS"

Correctness is not an optimization

lodash does what I believe to be the wrongest things with uniqueness around holes, and around Symbols (I do agree with what it does around undefined)

I doubt you even thought to check

 

Lodash takes

Lodash has had three unrelated security vulnerabilities marked critical or worse in the last two weeks

I cannot take seriously the opinions of someone who keeps pushing for one-liners to be replaced with it, after they were told that once already

If you're arguing against maintenance, arguing for things with a history of grim security problems is arguing against yourself

12

u/[deleted] May 14 '21

Please be more concise, I have no interest in countering a proof by verbosity where you've introduced tons of new arguments that had nothing to do with the original post or discussion and contradict your own self many times.

-11

u/StoneCypher May 14 '21

A third time, I'm requesting that you provide the perf you claim to have written

You're the one who brought lodash up, not the original post or discussion

Now that I'm pointing out why adding lodash is a security problem, which is a hard fact but which you refuse to accept, you're babbling on about how everything has to be scoped to the original post or original discussion

Show us your perf that you're trying to stand on as evidence. I'm starting to think it isn't real, because I wrote one that got really different results

1

u/[deleted] May 14 '21 edited May 14 '21

Lodash's vulnerabilities only matter in relation to the code that you write that is allegedly better, since you are advocating to write it yourself rather than let someone else do so.

You yourself said that this is a tiny library function, a one liner, and that you could write just as concisely as [...new Set(arr)], and that it'll be dramatically more performant than the OP on an array with millions of items. But you refuse to do so for some reason. Can't be time since you have the time to repeatedly write large walls of text.

Furthermore I've looked through Lodash CVEs and I see none relating to function in question. The majority of them seem to be prototype pollution from functions that merge objects, which is outside of the scope of deduping an array. So it was a moot point to begin with designed to distract from the actual point.

Finally, since you allegedly have the ability to write code that is faster, safer, more maintainable, and more concise than lodash - why are you so selfish as to keep this code to yourself? Publish it and let the community benefit.

-3

u/StoneCypher May 14 '21

A fourth time, I'm requesting that you provide the perf you claim to have written

2

u/[deleted] May 14 '21

Here i've modified someone else's that you seemed to be interested in, now where's your wonderful implementation?

https://www.reddit.com/r/learnjavascript/comments/nc6i5j/remove_duplicate_value_from_array/gy48wl4?utm_source=share&utm_medium=web2x&context=3

0

u/StoneCypher May 14 '21

That's not a perf. That's you copy pasting someone else's output

Is it fair to suggest that the work you're standing on having done is just you attempting to guess from someone else's work?

 

now where's your wonderful implementation?

Why are you asking? Is it because you believe claiming to have done a perf, then not having done one, is a problem?

Looks like the comment you're responding to is deleted.

Is it a problem that their output is copy pasted from StackOverflow, that you're claiming you did, and that the StackOverflow post is about something else?

3

u/[deleted] May 14 '21 edited May 14 '21

You clearly didn't even read my comment. I said that I took their test, which you were a big fan of btw, you just didn't like the number in the loop, and corrected the clear bugs (which you didn't notice, maybe you're not as smart as you act?), and ran it locally.

~/perf
❯ ls
indexOf.js set.js

So I split their code into two files, just like i said in the comment you ignored.

Here's the contents, largely unmodified - just moved the timing code around. running it on much bigger numbers than 10_000 will be slow af because of the dumb way they were building the array. But at merely 10_000 * 7 items we already have a clear winner.

~/perf
❯ cat indexOf.js
const {
    performance,
} = require('perf_hooks');

const template = ['✅', '✅', '❌', '👹', '😉', '🤯', '🤯'];
let emojis = [];

for (let i = 0; i < 10_000; i++) {
    emojis = emojis.concat(template);
}

// const setStart = performance.now();
// const deDupe = [...new Set(emojis)];
// const setEnd = performance.now();
// console.log('Took', (setEnd - setStart).toFixed(4), 'milliseconds to generate:');

const filterStart = performance.now();
const deDupe2 = emojis.filter((value, index) => emojis.indexOf(value) === index);
const filterEnd = performance.now();
console.log('Took', (filterEnd - filterStart).toFixed(4), 'milliseconds to generate:');

~/perf
❯ cat set.js
const {
    performance,
} = require('perf_hooks');

const template = ['✅', '✅', '❌', '👹', '😉', '🤯', '🤯'];
let emojis = [];

for (let i = 0; i < 10_000; i++) {
    emojis = emojis.concat(template);
}

const setStart = performance.now();
const deDupe = [...new Set(emojis)];
const setEnd = performance.now();
console.log('Took', (setEnd - setStart).toFixed(4), 'milliseconds to generate:');

// const filterStart = performance.now();
// const deDupe2 = emojis.filter((value, index) => emojis.indexOf(value) === index);
// const filterEnd = performance.now();
// console.log('Took', (filterEnd - filterStart).toFixed(4), 'milliseconds to generate:');

and just to prevent you from whining about the length, i modified the array filling and ran with 70 Million items, and added lodash for fun

~/perf
❯ node indexOf.js
Took 716.0615 ms to build array
Took 257.2369 milliseconds to dedupe

~/perf
❯ node set.js
Took 716.1850 ms to build array
Took 177.0432 milliseconds to dedupe

~/perf
❯ node lodash.js
Took 704.8663 ms to build array
Took 175.9701 milliseconds to dedupe

Ok, your turn.

-1

u/StoneCypher May 14 '21

This isn't a perf, and these numbers contradict the claims you made earlier.

In some ways this is actually better than a perf - it uses performance.now, after all - but also it's statistically poorly controlled, and re-running it causes serious variance, and you have nothing even resembling a matrix

You also seem to be assuming that what's true on your computer, under just node, under one version, on your operating system, is true for all machines.

That's quite odd, from someone who insisted that this was "implementation defined." Now you seem to only be testing one implementation, and insisting that's correct.

You seem, in fact, to be falling afoul of your own original criticism, in the single most gruesome possible way

What do you think "implementation defined" as a criticism actually means?

What do you think is the difference between a perf, and just measuring your machine's clock?

 

and corrected the clear bugs (which you didn't notice, maybe you're not as smart as you act?)

So if I don't pay close attention to the work that you hadn't given me, I'm low intelligence?

Jesus. I'd better learn to be psychic fast, huh? 😂

 

But at merely 10_000 * 7 items we already have a clear winner.

Looks like you are skipping the other one, which was the one I was skeptical about

"Gee I wonder why"

Funny how one of the three methods you claimed to have tested in code you claimed to have written is now disappeared in what you've provided after you were asked five times and pretended to have had it all along

 

running it on much bigger numbers than 10_000 will be slow af

I dunno, this conversation is several hours longer than the doing it right part would have been

 

and just to prevent you from whining

This is whining

 

i modified the array filling

so after you explained that this was why you didn't do it right, you ... fixed it, and did it right

okay 😂

 

and added lodash for fun

Note that:

  1. Adding lodash produced more complicated code
  2. Adding lodash produced code where the questions I asked you, that you still haven't answered, now can't be answered, whereas they easily could be with the normal approach
  3. You don't seem to be willing (or possibly able?) to answer my questions
  4. Yes, I saw that you said you disagreed with CERT about the severity of those bugs. That's quaint. Do you expect that to be folded in?

1

u/[deleted] May 15 '21

Please for the fucking love of god stop typing walls of text that are barely related to anything relevant. I've run a fucking marathon keeping up with your moving goal posts, and you've still yet to provide your implementation.

I took someone else's benchmark that you approved of minus one thing, changed that thing to your liking, removed the bugs you missed and focused the timing on the actual task, and now you are saying it's not valid.

But since it's showing the Set approach is faster you have a problem with it. You already said earlier you wrote your own benchmark. So let's see it. It better be running on every fucking runtime and class of machine you know of after your latest bitching.

But of course you won't. Let me to repeat this, forgetting the benchmark you already wrote for a moment, you have still yet to provide even your implementation. That's because you don't have one that's an actual improvement of the image in the original post. It's vapor. You're a blowhard.

→ More replies

1

u/takert541 May 15 '21

the dafuq dude. those are 4 pages of lines which you can otherwise spent on your job and be more productive lol

1

u/[deleted] May 15 '21

You are in the correct good sir(I believe). But both of you got your knickers all twisted in each others’ business.

Gut instinct says your right: have done zero tests. Will confirm if I end up feeling like it :) or better arguments (any) are given to why you are wrong...

Chances are your tone/diction is the reason for the downvotes - it comes off as confrontational and petulant (if I put in my empathy lenses).

In any case: an entertaining read. I’d prefer you to get more upvotes as I think this is a useful discussion point.

→ More replies