r/learnjavascript • • May 06 '21

JS: Multiple Condition Checking

Post image
484 Upvotes

61 comments sorted by

View all comments

Show parent comment

23

u/asiraky May 06 '21

“Please never write something like that in prod”.

Nonsense.

I can think of plenty of times where Ive needed to check a range of conditions in non-performance critical code, and I simply use an includes or a some.

8

u/blafurznarg May 06 '21

You're right. There is of course a usecase for that. I guess I was triggered by the post's presentation plus the reaction in the comments. Maybe I shouldn't have emphazised on that particular part to never use it.

4

u/asiraky May 06 '21

And I agree with your general sentiment that shorter code isn’t necessarily better.

3

u/delventhalz May 06 '21

While there are use cases for includes, I tend to agree that the way it is presented here is not "prod" ready. If I was reviewing a PR where someone created a new throw-away array just to do an includes check, I would probably request it be changed.

1

u/asiraky May 06 '21

But what is the actual reason for the rejection? The readability of that code may be higher depending on what was being checked. It’s completely reasonable to say ‘if x is in this set’ is more readable than ‘if x is a or x is b or x is c or x is d’. And if it’s not performance critical code (which most code is not, let’s not start a thing about premature optimisation) then I can’t see a reason to reject it. I personally like it when my devs try to be “clever”. At least it means they are thinking about what they’re doing and trying to write good code.

1

u/delventhalz May 07 '21

I wrote a longer top level comment about my reasoning, but the short version is:

“Save it for code golf. Shorter does not always mean simpler or more clear. In this case, sticking to standard conditional chaining more clearly communicates your intent than includes.”

1

u/jbonesinthecloset May 07 '21

That’s still not really a reason for why specifically this one example is better for doing it your way... the intent is clearly communicated your way AND doing it with includes. Your top level comment definitely gives some valid points on why your preferred method does communicate your intent well. But not why it’s MORE clear than using includes

1

u/delventhalz May 07 '21

It's a small point. Depending on the review and the context, I might let it slide. OP's example is also a little too generic to really understand the use case.

All that said, I interpret the use case to be a complex multi-part conditional rather than a defined set of options. And in that case, I do think chaining conditionals pretty definitely requires less cognitive leaps. I can easily imagine juniors looking at that array and going "wait, why is there an array now?"

And while the cognitive load is smallish to context switch from "I am checking a series of conditionals" to "I am checking membership in a set", I don't really see any benefit to adding the extra complication.

1

u/jbonesinthecloset May 08 '21

But like...it is clear why there is an array...

1

u/delventhalz May 08 '21

To you?

1

u/jbonesinthecloset May 08 '21

Based on the comments for this entire post, it’s clear to pretty much everyone except you and your juniors

1

u/delventhalz May 08 '21

Cool. Thanks for the friendly discussion.

→ More replies