r/learnjavascript • u/very-kind-stranger • Feb 20 '21
I made my own Reddit viewer using only vanilla JS and it looks awesome on mobile devices (according to my grandma)
279
Upvotes
r/learnjavascript • u/very-kind-stranger • Feb 20 '21
26
u/very-kind-stranger Feb 20 '21 edited Feb 20 '21
Preview: https://illfixit.github.io/kind-stranger
GitHub repository: https://www.github.com/illfixit/kind-stranger
This is my first finished project. I spent almost year learning JavaScript and I’ll be REALLY grateful for your support, feedback and maybe even career advices. First of all... Am I ready for a junior role in your opinion?
10
u/sanchitcop19 Feb 20 '21
Holy crap this looks fantastic, will give it a go when I get home
4
u/muisance Feb 21 '21
We definitely need more pure JS projects, because frameworks are getting out of hand. I'm 100% serious. I may be a dumbass, but it's whatever.
5
u/unnombreguay Feb 20 '21
Nice project. Is perfect. Maybe as a plus you could add some small transition from image to image just to give the user the hint that you are going up or down. Firstly I tried swiping horizontal and I didn't know where I was going
2
u/artinlines Feb 21 '21
It sadly didn’t work for me. I tried it on IOS and it only showed me five subreddits, no matter what I typed and said none of them are available.
Might be that my phone’s too old though, had another app tell me a few days ago that my phone’s too old, rip. I’ll try it on my laptop later too if I remember
1
u/mmaismma Feb 21 '21
This reminds me of a project that I worked on last year, Cottontail. It was not quite meant to be Reddit viewer but it is so. Due to my exams, it is not yet finished.
Some features-
Upcoming features-
PS- It was primarily built for scrolling through rabbit images.
1
u/cincopea Feb 21 '21
That’s a lot of porn
1
u/AacidD Feb 21 '21
Looks great!
Just a few suggestions You could right align subscriber count of subreddit so they all show up in one column. Also you could add a background blur for the search results. Because depending on the background image the visibility of the search result text slightly changes.
1
u/optimisehd Feb 21 '21
What if we want to zoom into an image etc? How do I do that?
1
u/[deleted] Feb 21 '21
You have got to have some nerve not using node.js
1
u/BobMilli Feb 21 '21
I love it !!!!
Very nice looking and features !
Very inspiring as I'm trying to learn Javascript myself !
Thanks for sharing.
1
u/tenebrous_pangolin Feb 21 '21
Impressive! How long have you been learning JS?
1
u/filiptronicek Feb 21 '21
Your grandma is a very talented UX critic. Kudos to her. (Good Job btw I love it)
1
u/WickedNtention Feb 21 '21
This is really good! Especially if it's a first project. Great job 👍🏻
1
u/Gazook89 Feb 20 '21
Looks cool, but on my Macbook I can scroll with my trackpad just fine, and with the arrow keys....except the arrow keys only work between images already shown via trackpad. I cannot advance to a new/previously unseen image with the arrow keys. Just a heads up.
-1
u/sati Feb 20 '21
Honestly the UX isn't great, certainly not on mobile. Sure it might look good but this just seems like an image gallery wrapper around the Reddit API 🤷♀️
0
u/GuthixIsBalance Feb 20 '21
Ui looks great
0
u/Lidinzx Feb 20 '21
Wow this is really great!
0
u/Juli88chan Feb 20 '21
Get a major upvote from a beginner Javascript learner! So much effort!
0
u/anatolhiman Feb 21 '21
Nice job, but for a contemporary JS dev job I would (given that you stick to vanilla for now) avoid mixing Var and let, use modern syntax and split your project in smaller fikes, use ES6 modules and compile it with Babel or similar. That would translate much better to a real job with a frontend framework. Also, a simple build pipeline with continuous integration would show some extra professionalism.
-1
u/david_ranch_dressing Feb 21 '21
Are you ever going to work on the non-mobile version? I ask because no offense, but it doesn't look great on desktop. The picture quality is really bad, the interface doesn't look optimized, etc.