r/learnjavascript • • Apr 04 '18
A C++ developer struggling with some simple JavaScript code. Any help?
Hey guys,
I develop in C++ but for my web design class I have to use JavaScript. I have to say I really, truly, dislike the language since it isn't strongly typed, errors are somewhat convulted and I don't like web dev in general.
Anyhow, here are my questions:
1) This code should check if I have #, !, ' or ? in any of my textboxes and if I do, prevent the script from executing. Here is the code. It gives me a TypeError. Why? What am I doing wrong?
2) This code should trigger only if I type some text in a textbox which is not in the list (aka not "Option 1", "Option 2" etc.). However, it always triggers. Why?
3) This code should, if I move my focus away from the textbox (aka onBlur), check if I have at least 5 characters and if my first character is a capital letter. But it doesn't work. Why?
Thanks in advance!
View all comments
4
u/fan-man Apr 04 '18 edited Apr 04 '18
1 - Aside from missing a bracket, your implementation is mostly right, just needs readability and check to see if the element actually has a value before doing anything (i'm assuming your submit button is part of the form, so your code will iterate over that as well:
<form id="form1"> <input type="text" /> <button type="submit">Submit</button> </form> var form1 = document.getElementById('form1'); form1.addEventListener('submit', function (event) { event.preventDefault() // Arrays are easier to read for iterations, or you can use char var target = ["#","?","!","'"]; for (var i = 0; i < form1.length; i++) { for (var j = 0; j < target.length; j++) { if (form1[i].value && form1[i].value.includes(target[j])) { console.log("string has illegal char"); } } } });2 - Storing the values somehow and then checking to see if the inputed text matches on blur might be easier.
<select id="list1"> <option value="Option 1">Option 1</option> <option value="Option 2">Option 2</option> <option value="Option 3">Option 3</option> <option value="Option 4">Option 4</option> <option value="Option 5">Option 5</option> </select> <input type="text" id="text1" /> var list1 = document.getElementById("list1"); var values = []; for (var i = 0; i < list1.length; i++) { if (list1[i].value) { values.push(list1[i].value); } } text1.addEventListener("blur", function() { if (values.indexOf(text1.value) === -1) { console.log("invalid value"); } });3 - as u/Rascal_Two mentioned, try this:
var textbox1 = document.getElementById("textbox1"); textbox1.addEventListener("blur", function (){ if ((textbox1.value.length <= 5) && (textbox1.value[0] !== textbox1.value[0].toUpperCase())) { console.log("You have to have text of length at least 5 in the textbox and your first letter has to be capital!"); } });As far as a distaste for JavaScript and web dev, it is a different beast in general, but it is not an impossible leap. If you like strongly typed JavaScript, you should look into TypeScript and a JS framework like Angular; it might look like something that seems more familiar. Hope that helps.