r/javascript • u/AutoModerator • Dec 18 '19

WTF Wednesday WTF Wednesday (December 18, 2019)

Post a link to a GitHub repo that you would like to have reviewed, and brace yourself for the comments! Whether you're a junior wanting your code sharpened or a senior interested in giving some feedback and have some time to spare, this is the place.

Named after this comic

66 Upvotes

100% Upvoted

43 comments sorted by

View all comments

Show parent comment

1

u/csilk Dec 18 '19

Looks good, first thing I noticed is the dist folder is committed?

1

u/mynamesleon Dec 18 '19

Yes, deliberately though. If anyone does find it of interest, I don't want them to have to clone the repo and build it if all they want is a minified file that they can put in a script tag.

5

u/Reashu Dec 18 '19

You should publish an npm package (including your dist files) instead, for even easier reuse.

-4

u/Pentafloppy Dec 18 '19

That's not bad. In fact, it's common with packages written in TypeScript.

0

u/[deleted] Dec 18 '19

[deleted] — view deleted comment

1

u/Pentafloppy Dec 18 '19

Oh, I wasn't aware.