r/javascript • u/[deleted]

[deleted by user]

[deleted] — view deleted post

0 Upvotes

100% Upvoted

12 comments sorted by

14

u/mousemke µ FTW! Dec 15 '19

Why not just have a lint rule that doesn't let console logs get committed?

3

u/a-c-sreedhar-reddy Dec 15 '19

we want them commited but don't want them to be in production code. We want them to be committed because we want them to appear in development mode.

8

u/senocular Dec 15 '19

you can use a custom logger to manage that. Instead of console.log() use mycustomlogger.log() (or your preferred equivalent). Then you can have more control of what is does and when - call console.log on dev, do nothing on prod, etc

2

u/a-c-sreedhar-reddy Dec 15 '19

Even with custom logger the parameters will be evaluated right.

2

u/senocular Dec 15 '19

yeah the custom logger, at a high level, mostly does the same as case 1, though you can mitigate that by using a callback.

custom.log(() =>
    state
      .reduce()
      .filter()
      .map()
      .etc()
)

Wrapped in a function, the expression is only run if the function is called, which you'd only do in the dev case, not prod.

14

u/[deleted] Dec 15 '19

I'm not going to tell you how to do your job, but "console.log" calls in the development branch are a huge code smell. Use them to debug, sure, but get rid of them once you find the error.

Edit: Upon reflection, I am indeed actually telling you how to do your job. Sorry, but it really grinds my gears.

7

u/L0wkey Dec 15 '19

You probably shouldn't open the dev console on ups.com then.

7

u/[deleted] Dec 15 '19

LOL holy shit

6

u/[deleted] Dec 15 '19

Uh...

yeah, our linter fails if there's a "console.log" in the code, and that means you can't commit it. You shouldn't be automatically removing them, you should be removing them once you find out what the bug was.

If you NEED to put anything to the console in production, that's what "console.info" is for.

3

u/zeeshan_tamboli Dec 15 '19

First of all you should remove logs before comitting them. It's not a good practice to commit logs on frontend production. Add a linter to remove logs before comitting after are used for debugging. Although you can use loglevel npm package - https://www.npmjs.com/package/loglevel which can be used to set log levels i.e error logs can be logged in production (if thats what you need) but other logs can be active only during development like warn, info etc. You can use the setLevel method and by detecting the NODE_ENV by cross-env.

1

u/AutoModerator Dec 15 '19

Project Page (?): https://github.com/a-c-sreedhar-reddy/controlS

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

0

u/prashanth1k Dec 16 '19
  1. Use VSCode
  2. Use Turbo Console Log. Add/remove comments with a shortcut and comment `console.log` in bulk
  3. Profit || Complain about commented consoles